Only add missing modules string if there are any modules to report

This commit is contained in:
Cohee 2024-06-26 12:49:23 +00:00
parent 4e7232f13e
commit 584d0e6222
1 changed files with 5 additions and 3 deletions

View File

@ -504,7 +504,7 @@ function addExtensionScript(name, manifest) {
* @param {boolean} isDisabled - Whether the extension is disabled or not. * @param {boolean} isDisabled - Whether the extension is disabled or not.
* @param {boolean} isExternal - Whether the extension is external or not. * @param {boolean} isExternal - Whether the extension is external or not.
* @param {string} checkboxClass - The class for the checkbox HTML element. * @param {string} checkboxClass - The class for the checkbox HTML element.
* @return {string} - The HTML string that represents the extension. * @return {Promise<string>} - The HTML string that represents the extension.
*/ */
async function generateExtensionHtml(name, manifest, isActive, isDisabled, isExternal, checkboxClass) { async function generateExtensionHtml(name, manifest, isActive, isDisabled, isExternal, checkboxClass) {
const displayName = manifest.display_name; const displayName = manifest.display_name;
@ -556,8 +556,10 @@ async function generateExtensionHtml(name, manifest, isActive, isDisabled, isExt
} else if (!isDisabled) { // Neither active nor disabled } else if (!isDisabled) { // Neither active nor disabled
const requirements = new Set(manifest.requires); const requirements = new Set(manifest.requires);
modules.forEach(x => requirements.delete(x)); modules.forEach(x => requirements.delete(x));
const requirementsString = DOMPurify.sanitize([...requirements].join(', ')); if (requirements.size > 0) {
extensionHtml += `<p>Missing modules: <span class="failure">${requirementsString}</span></p>`; const requirementsString = DOMPurify.sanitize([...requirements].join(', '));
extensionHtml += `<p>Missing modules: <span class="failure">${requirementsString}</span></p>`;
}
} }
return extensionHtml; return extensionHtml;