From 49fb2f4d792cc2902c84f3706ccfe2adcc5d8d9e Mon Sep 17 00:00:00 2001 From: Cohee <18619528+Cohee1207@users.noreply.github.com> Date: Tue, 7 Jan 2025 20:24:57 +0200 Subject: [PATCH] Declare compiler in the inner scope #3272 --- src/middleware/webpack-serve.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/middleware/webpack-serve.js b/src/middleware/webpack-serve.js index 546eebc27..950e0a941 100644 --- a/src/middleware/webpack-serve.js +++ b/src/middleware/webpack-serve.js @@ -5,8 +5,6 @@ import { publicLibConfig } from '../../webpack.config.js'; export default function getWebpackServeMiddleware() { const outputPath = publicLibConfig.output?.path; const outputFile = publicLibConfig.output?.filename; - /** @type {import('webpack').Compiler|null} */ - let compiler = webpack(publicLibConfig); /** * A very spartan recreation of webpack-dev-middleware. @@ -28,12 +26,9 @@ export default function getWebpackServeMiddleware() { * @returns {Promise} */ devMiddleware.runWebpackCompiler = () => { - return new Promise((resolve) => { - if (compiler === null) { - console.warn('Webpack compiler is already closed.'); - return resolve(); - } + const compiler = webpack(publicLibConfig); + return new Promise((resolve) => { console.log(); console.log('Compiling frontend libraries...'); compiler.run((_error, stats) => { @@ -42,11 +37,7 @@ export default function getWebpackServeMiddleware() { console.log(output); console.log(); } - if (compiler === null) { - return resolve(); - } compiler.close(() => { - compiler = null; resolve(); }); });