2024-01-22 16:57:19 +00:00
|
|
|
From 3d0d89a1306c53973cc898d6e003e18826cee219 Mon Sep 17 00:00:00 2001
|
2024-01-04 12:38:55 +00:00
|
|
|
From: Thomas Gleixner <tglx@linutronix.de>
|
|
|
|
|
Date: Thu, 28 Jul 2011 13:32:57 +0200
|
|
|
|
|
Subject: [PATCH 41/62] tty/serial/omap: Make the locking RT aware
|
|
|
|
|
|
|
|
|
|
The lock is a sleeping lock and local_irq_save() is not the
|
|
|
|
|
optimsation we are looking for. Redo it to make it work on -RT and
|
|
|
|
|
non-RT.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
|
|
|
|
---
|
|
|
|
|
drivers/tty/serial/omap-serial.c | 12 ++++--------
|
|
|
|
|
1 file changed, 4 insertions(+), 8 deletions(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
|
|
|
|
|
index 7d0d2718ef59..aa216fdbcb1d 100644
|
|
|
|
|
--- a/drivers/tty/serial/omap-serial.c
|
|
|
|
|
+++ b/drivers/tty/serial/omap-serial.c
|
|
|
|
|
@@ -1241,13 +1241,10 @@ serial_omap_console_write(struct console *co, const char *s,
|
|
|
|
|
unsigned int ier;
|
|
|
|
|
int locked = 1;
|
|
|
|
|
|
|
|
|
|
- local_irq_save(flags);
|
|
|
|
|
- if (up->port.sysrq)
|
|
|
|
|
- locked = 0;
|
|
|
|
|
- else if (oops_in_progress)
|
|
|
|
|
- locked = spin_trylock(&up->port.lock);
|
|
|
|
|
+ if (up->port.sysrq || oops_in_progress)
|
|
|
|
|
+ locked = spin_trylock_irqsave(&up->port.lock, flags);
|
|
|
|
|
else
|
|
|
|
|
- spin_lock(&up->port.lock);
|
|
|
|
|
+ spin_lock_irqsave(&up->port.lock, flags);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* First save the IER then disable the interrupts
|
|
|
|
|
@@ -1274,8 +1271,7 @@ serial_omap_console_write(struct console *co, const char *s,
|
|
|
|
|
check_modem_status(up);
|
|
|
|
|
|
|
|
|
|
if (locked)
|
|
|
|
|
- spin_unlock(&up->port.lock);
|
|
|
|
|
- local_irq_restore(flags);
|
|
|
|
|
+ spin_unlock_irqrestore(&up->port.lock, flags);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int __init
|
|
|
|
|
--
|
|
|
|
|
2.43.0
|
|
|
|
|
|
