askl

src/core/hle/service/hid/errors.h

@@ -14,11 +14,22 @@ constexpr Result VibrationInvalidStyleIndex{ErrorModule::HID, 122};
 constexpr Result VibrationInvalidNpadId{ErrorModule::HID, 123};
 constexpr Result VibrationDeviceIndexOutOfRange{ErrorModule::HID, 124};
 constexpr Result InvalidSixAxisFusionRange{ErrorModule::HID, 423};
+
+constexpr Result ResultMcuInvalidHandle{ErrorModule::HID, 541};
+constexpr Result ResultMcuNotEnabled{ErrorModule::HID, 542};
+constexpr Result ResultMcuNoDeviceConnected{ErrorModule::HID, 543};
+constexpr Result ResultMcuUnknown544{ErrorModule::HID, 544};
+constexpr Result ResultMcuUnknown546{ErrorModule::HID, 546};
+constexpr Result ResultMcuUnknown548{ErrorModule::HID, 548};
+
 constexpr Result NpadIsDualJoycon{ErrorModule::HID, 601};
 constexpr Result NpadIsSameType{ErrorModule::HID, 602};
 constexpr Result InvalidNpadId{ErrorModule::HID, 709};
 constexpr Result NpadNotConnected{ErrorModule::HID, 710};
 constexpr Result InvalidArraySize{ErrorModule::HID, 715};
+
+constexpr Result ResultControllerUpdateFailed{ErrorModule::HID, 3201};
+
 constexpr Result InvalidPalmaHandle{ErrorModule::HID, 3302};
 
 } // namespace Service::HID
@@ -29,3 +40,17 @@ constexpr Result InvalidProcessorState{ErrorModule::Irsensor, 78};
 constexpr Result InvalidIrCameraHandle{ErrorModule::Irsensor, 204};
 
 } // namespace Service::IRS
+
+namespace Service::HIDBUS {
+
+constexpr Result ResultNotEnabled{ErrorModule::HIDBUS, 1};
+constexpr Result ResultControllerUpdateFailed{ErrorModule::HIDBUS, 3};
+constexpr Result ResultInvalidBusHandle{ErrorModule::HIDBUS, 4};
+constexpr Result ResultNoDeviceConnected{ErrorModule::HIDBUS, 5};
+constexpr Result ResultUknown6{ErrorModule::HIDBUS, 6};
+constexpr Result ResultPollingRecieveDataNotAvailable{ErrorModule::HIDBUS, 7};
+constexpr Result ResultDeviceEnabledNotSet{ErrorModule::HIDBUS, 8};
+constexpr Result ResultBusHandleAlreadyInitialized{ErrorModule::HIDBUS, 10};
+constexpr Result ResultInvalidBusType{ErrorModule::HIDBUS, 11};
+
+} // namespace Service::HID

src/core/hle/service/hid/hidbus.cpp

@@ -12,6 +12,8 @@
 #include "core/hle/kernel/k_shared_memory.h"
 #include "core/hle/kernel/k_transfer_memory.h"
 #include "core/hle/service/hid/hidbus.h"
+#include "core/hle/service/hid/errors.h"
+#include "core/hle/service/hid/controllers/npad.h"
 #include "core/hle/service/hid/hidbus/ringcon.h"
 #include "core/hle/service/hid/hidbus/starlink.h"
 #include "core/hle/service/hid/hidbus/stubbed.h"
@@ -47,56 +49,9 @@ HidBus::HidBus(Core::System& system_)
 
     RegisterHandlers(functions);
 
-    // Register update callbacks
-    hidbus_update_event = Core::Timing::CreateEvent(
-        "Hidbus::UpdateCallback",
-        [this](std::uintptr_t user_data, s64 time,
-               std::chrono::nanoseconds ns_late) -> std::optional<std::chrono::nanoseconds> {
-            const auto guard = LockService();
-            UpdateHidbus(user_data, ns_late);
-            return std::nullopt;
-        });
-
-    system_.CoreTiming().ScheduleLoopingEvent(hidbus_update_ns, hidbus_update_ns,
-                                              hidbus_update_event);
 }
 
 HidBus::~HidBus() {
-    system.CoreTiming().UnscheduleEvent(hidbus_update_event, 0);
-}
-
-void HidBus::UpdateHidbus(std::uintptr_t user_data, std::chrono::nanoseconds ns_late) {
-    if (is_hidbus_enabled) {
-        for (std::size_t i = 0; i < devices.size(); ++i) {
-            if (!devices[i].is_device_initializated) {
-                continue;
-            }
-            auto& device = devices[i].device;
-            device->OnUpdate();
-            auto& cur_entry = hidbus_status.entries[devices[i].handle.internal_index];
-            cur_entry.is_polling_mode = device->IsPollingMode();
-            cur_entry.polling_mode = device->GetPollingMode();
-            cur_entry.is_enabled = device->IsEnabled();
-
-            u8* shared_memory = system.Kernel().GetHidBusSharedMem().GetPointer();
-            std::memcpy(shared_memory + (i * sizeof(HidbusStatusManagerEntry)), &hidbus_status,
-                        sizeof(HidbusStatusManagerEntry));
-        }
-    }
-}
-
-std::optional<std::size_t> HidBus::GetDeviceIndexFromHandle(BusHandle handle) const {
-    for (std::size_t i = 0; i < devices.size(); ++i) {
-        const auto& device_handle = devices[i].handle;
-        if (handle.abstracted_pad_id == device_handle.abstracted_pad_id &&
-            handle.internal_index == device_handle.internal_index &&
-            handle.player_number == device_handle.player_number &&
-            handle.bus_type_id == device_handle.bus_type_id &&
-            handle.is_valid == device_handle.is_valid) {
-            return i;
-        }
-    }
-    return std::nullopt;
 }
 
 void HidBus::GetBusHandle(HLERequestContext& ctx) {
@@ -114,38 +69,9 @@ void HidBus::GetBusHandle(HLERequestContext& ctx) {
     LOG_INFO(Service_HID, "called, npad_id={}, bus_type={}, applet_resource_user_id={}",
              parameters.npad_id, parameters.bus_type, parameters.applet_resource_user_id);
 
-    bool is_handle_found = 0;
+    if (parameters.bus_type >= BusType::MaxBusType) {
-    std::size_t handle_index = 0;
+        IPC::ResponseBuilder rb{ctx, 2};
-
+        rb.Push(HIDBUS::ResultInvalidBusType);
-    for (std::size_t i = 0; i < devices.size(); i++) {
-        const auto& handle = devices[i].handle;
-        if (!handle.is_valid) {
-            continue;
-        }
-        if (static_cast<Core::HID::NpadIdType>(handle.player_number) == parameters.npad_id &&
-            handle.bus_type_id == static_cast<u8>(parameters.bus_type)) {
-            is_handle_found = true;
-            handle_index = i;
-            break;
-        }
-    }
-
-    // Handle not found. Create a new one
-    if (!is_handle_found) {
-        for (std::size_t i = 0; i < devices.size(); i++) {
-            if (devices[i].handle.is_valid) {
-                continue;
-            }
-            devices[i].handle = {
-                .abstracted_pad_id = static_cast<u8>(i),
-                .internal_index = static_cast<u8>(i),
-                .player_number = static_cast<u8>(parameters.npad_id),
-                .bus_type_id = static_cast<u8>(parameters.bus_type),
-                .is_valid = true,
-            };
-            handle_index = i;
-            break;
-        }
     }
 
     struct OutData {
@@ -155,10 +81,8 @@ void HidBus::GetBusHandle(HLERequestContext& ctx) {
     };
     static_assert(sizeof(OutData) == 0x10, "OutData has incorrect size.");
 
-    const OutData out_data{
+    OutData out_data{};
-        .is_valid = true,
+    out_data.is_valid = GetBusHandleImpl(out_data.handle, parameters.npad_id, parameters.bus_type);
-        .handle = devices[handle_index].handle,
-    };
 
     IPC::ResponseBuilder rb{ctx, 6};
     rb.Push(ResultSuccess);
@@ -175,21 +99,10 @@ void HidBus::IsExternalDeviceConnected(HLERequestContext& ctx) {
              bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
              bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
+    auto result = TranslateHidErrorToHidBusError(ResultSuccess);
 
-    if (device_index) {
-        const auto& device = devices[device_index.value()].device;
-        const bool is_attached = device->IsDeviceActivated();
-
-        IPC::ResponseBuilder rb{ctx, 3};
-        rb.Push(ResultSuccess);
-        rb.Push(is_attached);
-        return;
-    }
-
-    LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
-    rb.Push(ResultUnknown);
+    rb.Push(result);
     return;
 }
 
@@ -204,40 +117,6 @@ void HidBus::Initialize(HLERequestContext& ctx) {
              bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
              bus_handle_.player_number, bus_handle_.is_valid, applet_resource_user_id);
 
-    is_hidbus_enabled = true;
-
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        const auto entry_index = devices[device_index.value()].handle.internal_index;
-        auto& cur_entry = hidbus_status.entries[entry_index];
-
-        if (bus_handle_.internal_index == 0 && Settings::values.enable_ring_controller) {
-            MakeDevice<RingController>(bus_handle_);
-            devices[device_index.value()].is_device_initializated = true;
-            devices[device_index.value()].device->ActivateDevice();
-            cur_entry.is_in_focus = true;
-            cur_entry.is_connected = true;
-            cur_entry.is_connected_result = ResultSuccess;
-            cur_entry.is_enabled = false;
-            cur_entry.is_polling_mode = false;
-        } else {
-            MakeDevice<HidbusStubbed>(bus_handle_);
-            devices[device_index.value()].is_device_initializated = true;
-            cur_entry.is_in_focus = true;
-            cur_entry.is_connected = false;
-            cur_entry.is_connected_result = ResultSuccess;
-            cur_entry.is_enabled = false;
-            cur_entry.is_polling_mode = false;
-        }
-
-        std::memcpy(system.Kernel().GetHidBusSharedMem().GetPointer(), &hidbus_status,
-                    sizeof(hidbus_status));
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -256,27 +135,6 @@ void HidBus::Finalize(HLERequestContext& ctx) {
              bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
              bus_handle_.player_number, bus_handle_.is_valid, applet_resource_user_id);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        const auto entry_index = devices[device_index.value()].handle.internal_index;
-        auto& cur_entry = hidbus_status.entries[entry_index];
-        auto& device = devices[device_index.value()].device;
-        devices[device_index.value()].is_device_initializated = false;
-        device->DeactivateDevice();
-
-        cur_entry.is_in_focus = true;
-        cur_entry.is_connected = false;
-        cur_entry.is_connected_result = ResultSuccess;
-        cur_entry.is_enabled = false;
-        cur_entry.is_polling_mode = false;
-        std::memcpy(system.Kernel().GetHidBusSharedMem().GetPointer(), &hidbus_status,
-                    sizeof(hidbus_status));
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -305,16 +163,6 @@ void HidBus::EnableExternalDevice(HLERequestContext& ctx) {
               parameters.bus_handle.player_number, parameters.bus_handle.is_valid, parameters.inval,
               parameters.applet_resource_user_id);
 
-    const auto device_index = GetDeviceIndexFromHandle(parameters.bus_handle);
-
-    if (device_index) {
-        auto& device = devices[device_index.value()].device;
-        device->Enable(parameters.enable);
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -332,21 +180,29 @@ void HidBus::GetExternalDeviceId(HLERequestContext& ctx) {
               bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
               bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
+    u32 device_id{};
+    auto result = SetEventForSendCommandAsycResult2();
+    if (result.IsSuccess()) {
+        if (1) {
+            result = HIDBUS::ResultInvalidBusHandle;
+        }
+    }
 
-    if (device_index) {
+    if (result.IsSuccess()) {
-        const auto& device = devices[device_index.value()].device;
+        // result = GetExternalDeviceIdImpl();
-        u32 device_id = device->GetDeviceId();
+    }
+
+    if (result.IsSuccess()) {
         IPC::ResponseBuilder rb{ctx, 3};
         rb.Push(ResultSuccess);
         rb.Push<u32>(device_id);
         return;
     }
 
-    LOG_ERROR(Service_HID, "Invalid handle");
+    result = TranslateHidErrorToHidBusError(result);
+
     IPC::ResponseBuilder rb{ctx, 2};
-    rb.Push(ResultUnknown);
+    rb.Push(result);
-    return;
 }
 
 void HidBus::SendCommandAsync(HLERequestContext& ctx) {
@@ -360,16 +216,6 @@ void HidBus::SendCommandAsync(HLERequestContext& ctx) {
               data.size(), bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id,
               bus_handle_.internal_index, bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        auto& device = devices[device_index.value()].device;
-        device->SetCommand(data);
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -387,18 +233,6 @@ void HidBus::GetSendCommandAsynceResult(HLERequestContext& ctx) {
               bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
               bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        const auto& device = devices[device_index.value()].device;
-        const std::vector<u8> data = device->GetReply();
-        const u64 data_size = ctx.WriteBuffer(data);
-
-        IPC::ResponseBuilder rb{ctx, 4};
-        rb.Push(ResultSuccess);
-        rb.Push<u64>(data_size);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -416,16 +250,6 @@ void HidBus::SetEventForSendCommandAsycResult(HLERequestContext& ctx) {
              bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
              bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        const auto& device = devices[device_index.value()].device;
-        IPC::ResponseBuilder rb{ctx, 2, 1};
-        rb.Push(ResultSuccess);
-        rb.PushCopyObjects(device->GetSendCommandAsycEvent());
-        return;
-    }
-
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(ResultUnknown);
@@ -467,17 +291,6 @@ void HidBus::EnableJoyPollingReceiveMode(HLERequestContext& ctx) {
              t_mem_handle, polling_mode_, bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id,
              bus_handle_.internal_index, bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        auto& device = devices[device_index.value()].device;
-        device->SetPollingMode(polling_mode_);
-        device->SetTransferMemoryAddress(t_mem->GetSourceAddress());
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -495,16 +308,6 @@ void HidBus::DisableJoyPollingReceiveMode(HLERequestContext& ctx) {
              bus_handle_.abstracted_pad_id, bus_handle_.bus_type_id, bus_handle_.internal_index,
              bus_handle_.player_number, bus_handle_.is_valid);
 
-    const auto device_index = GetDeviceIndexFromHandle(bus_handle_);
-
-    if (device_index) {
-        auto& device = devices[device_index.value()].device;
-        device->DisablePollingMode();
-
-        IPC::ResponseBuilder rb{ctx, 2};
-        rb.Push(ResultSuccess);
-        return;
-    }
 
     LOG_ERROR(Service_HID, "Invalid handle");
     IPC::ResponseBuilder rb{ctx, 2};
@@ -521,4 +324,59 @@ void HidBus::SetStatusManagerType(HLERequestContext& ctx) {
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(ResultSuccess);
 };
+
+
+bool HidBus::GetBusHandleImpl(BusHandle& handle, Core::HID::NpadIdType npad_id, BusType bus_type) {
+    ASSERT_MSG(&handle != nullptr, "Handle is null");
+
+    if (!Controller_NPad::IsNpadIdValid(npad_id)) {
+        return false;
+    }
+
+    if (bus_type == BusType::LeftJoyRail || bus_type == BusType::RightJoyRail) {
+        return true;
+    }
+
+    if (bus_type == BusType::InternalBus) {
+        return true;
+    }
+
+    return false;
+}
+
+
+Result TranslateHidErrorToHidBusError(Result result) {
+    if (result.IsSuccess()) {
+        return result;
+    }
+    if (result.module != ErrorModule::HID) {
+        return result;
+    }
+    if (result == ResultMcuNotEnabled) {
+        return HIDBUS::ResultNotEnabled;
+    }
+    if (result == ResultMcuNoDeviceConnected) {
+        return HIDBUS::ResultNoDeviceConnected;
+    }
+    if (result == ResultMcuUnknown544) {
+        return HIDBUS::ResultUknown6;
+    }
+    if ((result.description & 0x1FFB) == 0x221) {
+        return HIDBUS::ResultPollingRecieveDataNotAvailable;
+    }
+    if (result == ResultMcuInvalidHandle) {
+        return HIDBUS::ResultInvalidBusHandle;
+    }
+    if (result == ResultMcuUnknown546) {
+        return HIDBUS::ResultDeviceEnabledNotSet;
+    }
+    if (result == ResultMcuUnknown548) {
+        return HIDBUS::ResultInvalidBusHandle;
+    }
+    if (result == ResultControllerUpdateFailed) {
+        return HIDBUS::ResultControllerUpdateFailed;
+    }
+    return result;
+}
+
 } // namespace Service::HID

src/core/hle/service/hid/hidbus.h

@@ -108,21 +108,12 @@ private:
     void DisableJoyPollingReceiveMode(HLERequestContext& ctx);
     void SetStatusManagerType(HLERequestContext& ctx);
 
-    void UpdateHidbus(std::uintptr_t user_data, std::chrono::nanoseconds ns_late);
+    bool GetBusHandleImpl(BusHandle& handle, Core::HID::NpadIdType npad_id, BusType bus_type);
-    std::optional<std::size_t> GetDeviceIndexFromHandle(BusHandle handle) const;
+    Result TranslateHidErrorToHidBusError(Result result);
+    Result SetEventForSendCommandAsycResult2();
 
-    template <typename T>
-    void MakeDevice(BusHandle handle) {
-        const auto device_index = GetDeviceIndexFromHandle(handle);
-        if (device_index) {
-            devices[device_index.value()].device = std::make_unique<T>(system, service_context);
-        }
-    }
 
-    bool is_hidbus_enabled{false};
     HidbusStatusManager hidbus_status{};
-    std::array<HidbusDevice, max_number_of_handles> devices{};
-    std::shared_ptr<Core::Timing::EventType> hidbus_update_event;
     KernelHelpers::ServiceContext service_context;
 };