kraken: Address comments from review

Fix compiler bug
2021-11-14 21:56:54 -06:00
parent f4e5f89e6f
commit 42949738f2
17 changed files with 54 additions and 66 deletions
--- a/src/input_common/input_engine.h
+++ b/src/input_common/input_engine.h
@ -166,7 +166,7 @@ public:
    };

    /// Retrieves the index number of the given hat button direction
-    virtual u8 GetHatButtonId([[maybe_unused]] const std::string direction_name) const {
+    virtual u8 GetHatButtonId([[maybe_unused]] const std::string& direction_name) const {
        return 0;
    };