octo
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

submission_package: Ensure the 'extracted' member variable is always initialized 

If an error occurs when constructing the PartitionFilesystem instance,
the constructor would be exited early, which wouldn't initialize the
extracted data member, making it possible for other code to perform an
uninitialized read by calling the public IsExtractedType() member
function. This prevents that.
This commit is contained in:
Lioncash 2018-10-03 01:47:32 -04:00
parent ccf0a9cb38
commit 37ee05f7c0
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/file_sys/submission_package.cpp
View File

@ -61,8 +61,6 @@ NSP::NSP(VirtualFile file_)
return; return;
} }
extracted = false;
SetTicketKeys(files); SetTicketKeys(files);
ReadNCAs(files); ReadNCAs(files);
} }

2
src/core/file_sys/submission_package.h
View File

@ -64,7 +64,7 @@ private:
VirtualFile file; VirtualFile file;
bool extracted; bool extracted = false;
Loader::ResultStatus status; Loader::ResultStatus status;
std::map<u64, Loader::ResultStatus> program_status; std::map<u64, Loader::ResultStatus> program_status;