Android 201

.reuse/dep5

@@ -155,7 +155,3 @@ License: MIT
 Files: externals/gamemode/*
 Copyright: Copyright 2017-2019 Feral Interactive
 License: BSD-3-Clause
-
-Files: src/android/app/debug.keystore
-Copyright: 2023 yuzu Emulator Project
-License: GPL-3.0-or-later

README.md

@@ -1,7 +1,7 @@
 | Pull Request | Commit | Title | Author | Merged? |
 |----|----|----|----|----|
-| [12499](https://github.com/yuzu-emu/yuzu-android//pull/12499) | [`31f015adc`](https://github.com/yuzu-emu/yuzu-android//pull/12499/files) | Rework time services | [Kelebek1](https://github.com/Kelebek1/) | Yes |
+| [12499](https://github.com/yuzu-emu/yuzu-android//pull/12499) | [`69acb6e3b`](https://github.com/yuzu-emu/yuzu-android//pull/12499/files) | Rework time services | [Kelebek1](https://github.com/Kelebek1/) | Yes |
-| [12749](https://github.com/yuzu-emu/yuzu-android//pull/12749) | [`e3171486d`](https://github.com/yuzu-emu/yuzu-android//pull/12749/files) | general: workarounds for SMMU syncing issues | [liamwhite](https://github.com/liamwhite/) | Yes |
+| [12579](https://github.com/yuzu-emu/yuzu-android//pull/12579) | [`748465f5a`](https://github.com/yuzu-emu/yuzu-android//pull/12579/files) | Core: Implement Device Mapping & GPU SMMU | [FernandoS27](https://github.com/FernandoS27/) | Yes |
 
 
 End of merge log. You can find the original README.md below the break.

src/android/app/build.gradle.kts

@@ -82,8 +82,8 @@ android {
     }
 
     val keystoreFile = System.getenv("ANDROID_KEYSTORE_FILE")
-    signingConfigs {
+    if (keystoreFile != null) {
-        if (keystoreFile != null) {
+        signingConfigs {
             create("release") {
                 storeFile = file(keystoreFile)
                 storePassword = System.getenv("ANDROID_KEYSTORE_PASS")
@@ -91,12 +91,6 @@ android {
                 keyPassword = System.getenv("ANDROID_KEYSTORE_PASS")
             }
         }
-        create("default") {
-            storeFile = file("$projectDir/debug.keystore")
-            storePassword = "android"
-            keyAlias = "androiddebugkey"
-            keyPassword = "android"
-        }
     }
 
     // Define build types, which are orthogonal to product flavors.
@@ -107,7 +101,7 @@ android {
             signingConfig = if (keystoreFile != null) {
                 signingConfigs.getByName("release")
             } else {
-                signingConfigs.getByName("default")
+                signingConfigs.getByName("debug")
             }
 
             resValue("string", "app_name_suffixed", "yuzu")
@@ -124,7 +118,7 @@ android {
         register("relWithDebInfo") {
             isDefault = true
             resValue("string", "app_name_suffixed", "yuzu Debug Release")
-            signingConfig = signingConfigs.getByName("default")
+            signingConfig = signingConfigs.getByName("debug")
             isMinifyEnabled = true
             isDebuggable = true
             proguardFiles(
@@ -139,7 +133,6 @@ android {
         // Signed by debug key disallowing distribution on Play Store.
         // Attaches 'debug' suffix to version and package name, allowing installation alongside the release build.
         debug {
-            signingConfig = signingConfigs.getByName("default")
             resValue("string", "app_name_suffixed", "yuzu Debug")
             isDebuggable = true
             isJniDebuggable = true

src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt

@@ -23,7 +23,6 @@ import org.yuzu.yuzu_emu.utils.Log
 import org.yuzu.yuzu_emu.utils.SerializableHelper.serializable
 import org.yuzu.yuzu_emu.model.InstallResult
 import org.yuzu.yuzu_emu.model.Patch
-import org.yuzu.yuzu_emu.model.GameVerificationResult
 
 /**
  * Class which contains methods that interact
@@ -565,26 +564,6 @@ object NativeLibrary {
      */
     external fun removeMod(programId: String, name: String)
 
-    /**
-     * Verifies all installed content
-     * @param callback UI callback for verification progress. Return true in the callback to cancel.
-     * @return Array of content that failed verification. Successful if empty.
-     */
-    external fun verifyInstalledContents(
-        callback: (max: Long, progress: Long) -> Boolean
-    ): Array<String>
-
-    /**
-     * Verifies the contents of a game
-     * @param path String path to a game
-     * @param callback UI callback for verification progress. Return true in the callback to cancel.
-     * @return Int that is meant to be converted to a [GameVerificationResult]
-     */
-    external fun verifyGameContents(
-        path: String,
-        callback: (max: Long, progress: Long) -> Boolean
-    ): Int
-
     /**
      * Gets the save location for a specific game
      *

src/android/app/src/main/java/org/yuzu/yuzu_emu/adapters/GameAdapter.kt

@@ -3,6 +3,9 @@
 
 package org.yuzu.yuzu_emu.adapters
 
+import android.content.Intent
+import android.graphics.Bitmap
+import android.graphics.drawable.LayerDrawable
 import android.net.Uri
 import android.text.TextUtils
 import android.view.LayoutInflater
@@ -12,6 +15,10 @@ import android.widget.Toast
 import androidx.appcompat.app.AppCompatActivity
 import androidx.core.content.pm.ShortcutInfoCompat
 import androidx.core.content.pm.ShortcutManagerCompat
+import androidx.core.content.res.ResourcesCompat
+import androidx.core.graphics.drawable.IconCompat
+import androidx.core.graphics.drawable.toBitmap
+import androidx.core.graphics.drawable.toDrawable
 import androidx.documentfile.provider.DocumentFile
 import androidx.lifecycle.ViewModelProvider
 import androidx.lifecycle.lifecycleScope
@@ -23,6 +30,7 @@ import kotlinx.coroutines.withContext
 import org.yuzu.yuzu_emu.HomeNavigationDirections
 import org.yuzu.yuzu_emu.R
 import org.yuzu.yuzu_emu.YuzuApplication
+import org.yuzu.yuzu_emu.activities.EmulationActivity
 import org.yuzu.yuzu_emu.databinding.CardGameBinding
 import org.yuzu.yuzu_emu.model.Game
 import org.yuzu.yuzu_emu.model.GamesViewModel
@@ -81,13 +89,36 @@ class GameAdapter(private val activity: AppCompatActivity) :
                 )
                 .apply()
 
+            val openIntent =
+                Intent(YuzuApplication.appContext, EmulationActivity::class.java).apply {
+                    action = Intent.ACTION_VIEW
+                    data = Uri.parse(game.path)
+                }
+
             activity.lifecycleScope.launch {
                 withContext(Dispatchers.IO) {
+                    val layerDrawable = ResourcesCompat.getDrawable(
+                        YuzuApplication.appContext.resources,
+                        R.drawable.shortcut,
+                        null
+                    ) as LayerDrawable
+                    layerDrawable.setDrawableByLayerId(
+                        R.id.shortcut_foreground,
+                        GameIconUtils.getGameIcon(activity, game)
+                            .toDrawable(YuzuApplication.appContext.resources)
+                    )
+                    val inset = YuzuApplication.appContext.resources
+                        .getDimensionPixelSize(R.dimen.icon_inset)
+                    layerDrawable.setLayerInset(1, inset, inset, inset, inset)
                     val shortcut =
                         ShortcutInfoCompat.Builder(YuzuApplication.appContext, game.path)
                             .setShortLabel(game.title)
-                            .setIcon(GameIconUtils.getShortcutIcon(activity, game))
+                            .setIcon(
-                            .setIntent(game.launchIntent)
+                                IconCompat.createWithAdaptiveBitmap(
+                                    layerDrawable.toBitmap(config = Bitmap.Config.ARGB_8888)
+                                )
+                            )
+                            .setIntent(openIntent)
                             .build()
                     ShortcutManagerCompat.pushDynamicShortcut(YuzuApplication.appContext, shortcut)
                 }

src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/model/IntSetting.kt

@@ -23,8 +23,7 @@ enum class IntSetting(override val key: String) : AbstractIntSetting {
     THEME("theme"),
     THEME_MODE("theme_mode"),
     OVERLAY_SCALE("control_scale"),
-    OVERLAY_OPACITY("control_opacity"),
+    OVERLAY_OPACITY("control_opacity");
-    LOCK_DRAWER("lock_drawer");
 
     override fun getInt(needsGlobal: Boolean): Int = NativeConfig.getInt(key, needsGlobal)
 

src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt

@@ -182,11 +182,11 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
             }
 
             override fun onDrawerOpened(drawerView: View) {
-                binding.drawerLayout.setDrawerLockMode(DrawerLayout.LOCK_MODE_UNLOCKED)
+                // No op
             }
 
             override fun onDrawerClosed(drawerView: View) {
-                binding.drawerLayout.setDrawerLockMode(IntSetting.LOCK_DRAWER.getInt())
+                // No op
             }
 
             override fun onDrawerStateChanged(newState: Int) {
@@ -196,28 +196,6 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
         binding.drawerLayout.setDrawerLockMode(DrawerLayout.LOCK_MODE_LOCKED_CLOSED)
         binding.inGameMenu.getHeaderView(0).findViewById<TextView>(R.id.text_game_title).text =
             game.title
-
-        binding.inGameMenu.menu.findItem(R.id.menu_lock_drawer).apply {
-            val lockMode = IntSetting.LOCK_DRAWER.getInt()
-            val titleId = if (lockMode == DrawerLayout.LOCK_MODE_LOCKED_CLOSED) {
-                R.string.unlock_drawer
-            } else {
-                R.string.lock_drawer
-            }
-            val iconId = if (lockMode == DrawerLayout.LOCK_MODE_UNLOCKED) {
-                R.drawable.ic_unlock
-            } else {
-                R.drawable.ic_lock
-            }
-
-            title = getString(titleId)
-            icon = ResourcesCompat.getDrawable(
-                resources,
-                iconId,
-                requireContext().theme
-            )
-        }
-
         binding.inGameMenu.setNavigationItemSelectedListener {
             when (it.itemId) {
                 R.id.menu_pause_emulation -> {
@@ -264,32 +242,6 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
                     true
                 }
 
-                R.id.menu_lock_drawer -> {
-                    when (IntSetting.LOCK_DRAWER.getInt()) {
-                        DrawerLayout.LOCK_MODE_UNLOCKED -> {
-                            IntSetting.LOCK_DRAWER.setInt(DrawerLayout.LOCK_MODE_LOCKED_CLOSED)
-                            it.title = resources.getString(R.string.unlock_drawer)
-                            it.icon = ResourcesCompat.getDrawable(
-                                resources,
-                                R.drawable.ic_lock,
-                                requireContext().theme
-                            )
-                        }
-
-                        DrawerLayout.LOCK_MODE_LOCKED_CLOSED -> {
-                            IntSetting.LOCK_DRAWER.setInt(DrawerLayout.LOCK_MODE_UNLOCKED)
-                            it.title = resources.getString(R.string.lock_drawer)
-                            it.icon = ResourcesCompat.getDrawable(
-                                resources,
-                                R.drawable.ic_unlock,
-                                requireContext().theme
-                            )
-                        }
-                    }
-                    NativeConfig.saveGlobalConfig()
-                    true
-                }
-
                 R.id.menu_exit -> {
                     emulationState.stop()
                     emulationViewModel.setIsEmulationStopping(true)
@@ -374,7 +326,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
                 repeatOnLifecycle(Lifecycle.State.CREATED) {
                     emulationViewModel.emulationStarted.collectLatest {
                         if (it) {
-                            binding.drawerLayout.setDrawerLockMode(IntSetting.LOCK_DRAWER.getInt())
+                            binding.drawerLayout.setDrawerLockMode(DrawerLayout.LOCK_MODE_UNLOCKED)
                             ViewUtils.showView(binding.surfaceInputOverlay)
                             ViewUtils.hideView(binding.loadingIndicator)
 

src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/GameInfoFragment.kt

@@ -21,10 +21,8 @@ import androidx.fragment.app.activityViewModels
 import androidx.navigation.findNavController
 import androidx.navigation.fragment.navArgs
 import com.google.android.material.transition.MaterialSharedAxis
-import org.yuzu.yuzu_emu.NativeLibrary
 import org.yuzu.yuzu_emu.R
 import org.yuzu.yuzu_emu.databinding.FragmentGameInfoBinding
-import org.yuzu.yuzu_emu.model.GameVerificationResult
 import org.yuzu.yuzu_emu.model.HomeViewModel
 import org.yuzu.yuzu_emu.utils.GameMetadata
 
@@ -103,38 +101,6 @@ class GameInfoFragment : Fragment() {
                 """.trimIndent()
                 copyToClipboard(args.game.title, details)
             }
-
-            buttonVerifyIntegrity.setOnClickListener {
-                ProgressDialogFragment.newInstance(
-                    requireActivity(),
-                    R.string.verifying,
-                    true
-                ) { progressCallback, _ ->
-                    val result = GameVerificationResult.from(
-                        NativeLibrary.verifyGameContents(
-                            args.game.path,
-                            progressCallback
-                        )
-                    )
-                    return@newInstance when (result) {
-                        GameVerificationResult.Success ->
-                            MessageDialogFragment.newInstance(
-                                titleId = R.string.verify_success,
-                                descriptionId = R.string.operation_completed_successfully
-                            )
-                        GameVerificationResult.Failed ->
-                            MessageDialogFragment.newInstance(
-                                titleId = R.string.verify_failure,
-                                descriptionId = R.string.verify_failure_description
-                            )
-                        GameVerificationResult.NotImplemented ->
-                            MessageDialogFragment.newInstance(
-                                titleId = R.string.verify_no_result,
-                                descriptionId = R.string.verify_no_result_description
-                            )
-                    }
-                }.show(parentFragmentManager, ProgressDialogFragment.TAG)
-            }
         }
 
         setInsets()

src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/GamePropertiesFragment.kt

@@ -4,8 +4,6 @@
 package org.yuzu.yuzu_emu.fragments
 
 import android.annotation.SuppressLint
-import android.content.pm.ShortcutInfo
-import android.content.pm.ShortcutManager
 import android.os.Bundle
 import android.text.TextUtils
 import android.view.LayoutInflater
@@ -86,24 +84,6 @@ class GamePropertiesFragment : Fragment() {
             view.findNavController().popBackStack()
         }
 
-        val shortcutManager = requireActivity().getSystemService(ShortcutManager::class.java)
-        binding.buttonShortcut.isEnabled = shortcutManager.isRequestPinShortcutSupported
-        binding.buttonShortcut.setOnClickListener {
-            viewLifecycleOwner.lifecycleScope.launch {
-                withContext(Dispatchers.IO) {
-                    val shortcut = ShortcutInfo.Builder(requireContext(), args.game.title)
-                        .setShortLabel(args.game.title)
-                        .setIcon(
-                            GameIconUtils.getShortcutIcon(requireActivity(), args.game)
-                                .toIcon(requireContext())
-                        )
-                        .setIntent(args.game.launchIntent)
-                        .build()
-                    shortcutManager.requestPinShortcut(shortcut, null)
-                }
-            }
-        }
-
         GameIconUtils.loadGameIcon(args.game, binding.imageGameScreen)
         binding.title.text = args.game.title
         binding.title.postDelayed(

src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/HomeSettingsFragment.kt

@@ -32,7 +32,6 @@ import org.yuzu.yuzu_emu.BuildConfig
 import org.yuzu.yuzu_emu.HomeNavigationDirections
 import org.yuzu.yuzu_emu.NativeLibrary
 import org.yuzu.yuzu_emu.R
-import org.yuzu.yuzu_emu.YuzuApplication
 import org.yuzu.yuzu_emu.adapters.HomeSettingAdapter
 import org.yuzu.yuzu_emu.databinding.FragmentHomeSettingsBinding
 import org.yuzu.yuzu_emu.features.DocumentProvider
@@ -141,38 +140,6 @@ class HomeSettingsFragment : Fragment() {
                     }
                 )
             )
-            add(
-                HomeSetting(
-                    R.string.verify_installed_content,
-                    R.string.verify_installed_content_description,
-                    R.drawable.ic_check_circle,
-                    {
-                        ProgressDialogFragment.newInstance(
-                            requireActivity(),
-                            titleId = R.string.verifying,
-                            cancellable = true
-                        ) { progressCallback, _ ->
-                            val result = NativeLibrary.verifyInstalledContents(progressCallback)
-                            return@newInstance if (result.isEmpty()) {
-                                MessageDialogFragment.newInstance(
-                                    titleId = R.string.verify_success,
-                                    descriptionId = R.string.operation_completed_successfully
-                                )
-                            } else {
-                                val failedNames = result.joinToString("\n")
-                                val errorMessage = YuzuApplication.appContext.getString(
-                                    R.string.verification_failed_for,
-                                    failedNames
-                                )
-                                MessageDialogFragment.newInstance(
-                                    titleId = R.string.verify_failure,
-                                    descriptionString = errorMessage
-                                )
-                            }
-                        }.show(parentFragmentManager, ProgressDialogFragment.TAG)
-                    }
-                )
-            )
             add(
                 HomeSetting(
                     R.string.share_log,

src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/MessageDialogFragment.kt

@@ -69,7 +69,7 @@ class MessageDialogFragment : DialogFragment() {
         private const val HELP_LINK = "Link"
 
         fun newInstance(
-            activity: FragmentActivity? = null,
+            activity: FragmentActivity,
             titleId: Int = 0,
             titleString: String = "",
             descriptionId: Int = 0,
@@ -86,11 +86,9 @@ class MessageDialogFragment : DialogFragment() {
                 putString(DESCRIPTION_STRING, descriptionString)
                 putInt(HELP_LINK, helpLinkId)
             }
-            if (activity != null) {
+            ViewModelProvider(activity)[MessageDialogViewModel::class.java].apply {
-                ViewModelProvider(activity)[MessageDialogViewModel::class.java].apply {
+                clear()
-                    clear()
+                this.positiveAction = positiveAction
-                    this.positiveAction = positiveAction
-                }
             }
             dialog.arguments = bundle
             return dialog

src/android/app/src/main/java/org/yuzu/yuzu_emu/model/Game.kt

@@ -3,7 +3,6 @@
 
 package org.yuzu.yuzu_emu.model
 
-import android.content.Intent
 import android.net.Uri
 import android.os.Parcelable
 import java.util.HashSet
@@ -12,7 +11,6 @@ import kotlinx.serialization.Serializable
 import org.yuzu.yuzu_emu.NativeLibrary
 import org.yuzu.yuzu_emu.R
 import org.yuzu.yuzu_emu.YuzuApplication
-import org.yuzu.yuzu_emu.activities.EmulationActivity
 import org.yuzu.yuzu_emu.utils.DirectoryInitialization
 import org.yuzu.yuzu_emu.utils.FileUtil
 import java.time.LocalDateTime
@@ -63,12 +61,6 @@ class Game(
     val addonDir: String
         get() = DirectoryInitialization.userDirectory + "/load/" + programIdHex + "/"
 
-    val launchIntent: Intent
-        get() = Intent(YuzuApplication.appContext, EmulationActivity::class.java).apply {
-            action = Intent.ACTION_VIEW
-            data = Uri.parse(path)
-        }
-
     override fun equals(other: Any?): Boolean {
         if (other !is Game) {
             return false

src/android/app/src/main/java/org/yuzu/yuzu_emu/model/GameVerificationResult.kt

@@ -1,15 +0,0 @@
-// SPDX-FileCopyrightText: 2024 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-package org.yuzu.yuzu_emu.model
-
-enum class GameVerificationResult(val int: Int) {
-    Success(0),
-    Failed(1),
-    NotImplemented(2);
-
-    companion object {
-        fun from(int: Int): GameVerificationResult =
-            entries.firstOrNull { it.int == int } ?: Success
-    }
-}

src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameIconUtils.kt

@@ -5,10 +5,7 @@ package org.yuzu.yuzu_emu.utils
 
 import android.graphics.Bitmap
 import android.graphics.BitmapFactory
-import android.graphics.drawable.LayerDrawable
 import android.widget.ImageView
-import androidx.core.content.res.ResourcesCompat
-import androidx.core.graphics.drawable.IconCompat
 import androidx.core.graphics.drawable.toBitmap
 import androidx.core.graphics.drawable.toDrawable
 import androidx.lifecycle.LifecycleOwner
@@ -88,22 +85,4 @@ object GameIconUtils {
         return imageLoader.execute(request)
             .drawable!!.toBitmap(config = Bitmap.Config.ARGB_8888)
     }
-
-    suspend fun getShortcutIcon(lifecycleOwner: LifecycleOwner, game: Game): IconCompat {
-        val layerDrawable = ResourcesCompat.getDrawable(
-            YuzuApplication.appContext.resources,
-            R.drawable.shortcut,
-            null
-        ) as LayerDrawable
-        layerDrawable.setDrawableByLayerId(
-            R.id.shortcut_foreground,
-            getGameIcon(lifecycleOwner, game).toDrawable(YuzuApplication.appContext.resources)
-        )
-        val inset = YuzuApplication.appContext.resources
-            .getDimensionPixelSize(R.dimen.icon_inset)
-        layerDrawable.setLayerInset(1, inset, inset, inset, inset)
-        return IconCompat.createWithAdaptiveBitmap(
-            layerDrawable.toBitmap(config = Bitmap.Config.ARGB_8888)
-        )
-    }
 }

src/android/app/src/main/jni/android_settings.h

@@ -63,7 +63,6 @@ struct Values {
     Settings::Setting<bool> show_input_overlay{linkage, true, "show_input_overlay",
                                                Settings::Category::Overlay};
     Settings::Setting<bool> touchscreen{linkage, true, "touchscreen", Settings::Category::Overlay};
-    Settings::Setting<s32> lock_drawer{linkage, false, "lock_drawer", Settings::Category::Overlay};
 };
 
 extern Values values;

src/android/app/src/main/jni/native.cpp

@@ -829,43 +829,6 @@ void Java_org_yuzu_yuzu_1emu_NativeLibrary_removeMod(JNIEnv* env, jobject jobj,
                               program_id, GetJString(env, jname));
 }
 
-jobject Java_org_yuzu_yuzu_1emu_NativeLibrary_verifyInstalledContents(JNIEnv* env, jobject jobj,
-                                                                      jobject jcallback) {
-    auto jlambdaClass = env->GetObjectClass(jcallback);
-    auto jlambdaInvokeMethod = env->GetMethodID(
-        jlambdaClass, "invoke", "(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;");
-    const auto callback = [env, jcallback, jlambdaInvokeMethod](size_t max, size_t progress) {
-        auto jwasCancelled = env->CallObjectMethod(jcallback, jlambdaInvokeMethod,
-                                                   ToJDouble(env, max), ToJDouble(env, progress));
-        return GetJBoolean(env, jwasCancelled);
-    };
-
-    auto& session = EmulationSession::GetInstance();
-    std::vector<std::string> result = ContentManager::VerifyInstalledContents(
-        &session.System(), session.GetContentProvider(), callback);
-    jobjectArray jresult =
-        env->NewObjectArray(result.size(), IDCache::GetStringClass(), ToJString(env, ""));
-    for (size_t i = 0; i < result.size(); ++i) {
-        env->SetObjectArrayElement(jresult, i, ToJString(env, result[i]));
-    }
-    return jresult;
-}
-
-jint Java_org_yuzu_yuzu_1emu_NativeLibrary_verifyGameContents(JNIEnv* env, jobject jobj,
-                                                              jstring jpath, jobject jcallback) {
-    auto jlambdaClass = env->GetObjectClass(jcallback);
-    auto jlambdaInvokeMethod = env->GetMethodID(
-        jlambdaClass, "invoke", "(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;");
-    const auto callback = [env, jcallback, jlambdaInvokeMethod](size_t max, size_t progress) {
-        auto jwasCancelled = env->CallObjectMethod(jcallback, jlambdaInvokeMethod,
-                                                   ToJDouble(env, max), ToJDouble(env, progress));
-        return GetJBoolean(env, jwasCancelled);
-    };
-    auto& session = EmulationSession::GetInstance();
-    return static_cast<jint>(
-        ContentManager::VerifyGameContents(&session.System(), GetJString(env, jpath), callback));
-}
-
 jstring Java_org_yuzu_yuzu_1emu_NativeLibrary_getSavePath(JNIEnv* env, jobject jobj,
                                                           jstring jprogramId) {
     auto program_id = EmulationSession::GetProgramId(env, jprogramId);

src/android/app/src/main/res/drawable/ic_lock.xml

@@ -1,9 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:height="24dp"
-    android:viewportHeight="24"
-    android:viewportWidth="24"
-    android:width="24dp">
-    <path
-        android:fillColor="?attr/colorControlNormal"
-        android:pathData="M18,8h-1L17,6c0,-2.76 -2.24,-5 -5,-5S7,3.24 7,6v2L6,8c-1.1,0 -2,0.9 -2,2v10c0,1.1 0.9,2 2,2h12c1.1,0 2,-0.9 2,-2L20,10c0,-1.1 -0.9,-2 -2,-2zM12,17c-1.1,0 -2,-0.9 -2,-2s0.9,-2 2,-2 2,0.9 2,2 -0.9,2 -2,2zM15.1,8L8.9,8L8.9,6c0,-1.71 1.39,-3.1 3.1,-3.1 1.71,0 3.1,1.39 3.1,3.1v2z" />
-</vector>

src/android/app/src/main/res/drawable/ic_shortcut.xml

@@ -1,9 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="24dp"
-    android:height="24dp"
-    android:viewportWidth="960"
-    android:viewportHeight="960">
-    <path
-        android:fillColor="?attr/colorControlNormal"
-        android:pathData="M280,920q-33,0 -56.5,-23.5T200,840v-720q0,-33 23.5,-56.5T280,40h400q33,0 56.5,23.5T760,120v160h-80v-40L280,240v480h400v-40h80v160q0,33 -23.5,56.5T680,920L280,920ZM686,520L480,520v120h-80v-120q0,-33 23.5,-56.5T480,440h206l-62,-64 56,-56 160,160 -160,160 -56,-56 62,-64Z" />
-</vector>

src/android/app/src/main/res/layout-w600dp/fragment_game_properties.xml

@@ -43,35 +43,16 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent">
 
-        <androidx.constraintlayout.widget.ConstraintLayout
+        <Button
-            android:layout_width="match_parent"
+            android:id="@+id/button_back"
+            style="?attr/materialIconButtonStyle"
+            android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_gravity="start"
             android:layout_margin="8dp"
-            android:orientation="horizontal">
+            app:icon="@drawable/ic_back"
-
+            app:iconSize="24dp"
-            <Button
+            app:iconTint="?attr/colorOnSurface" />
-                android:id="@+id/button_back"
-                style="?attr/materialIconButtonStyle"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                app:icon="@drawable/ic_back"
-                app:iconSize="24dp"
-                app:iconTint="?attr/colorOnSurface"
-                app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toTopOf="parent" />
-
-            <Button
-                android:id="@+id/button_shortcut"
-                style="?attr/materialIconButtonStyle"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                app:icon="@drawable/ic_shortcut"
-                app:iconSize="24dp"
-                app:iconTint="?attr/colorOnSurface"
-                app:layout_constraintTop_toTopOf="parent"
-                app:layout_constraintEnd_toEndOf="parent" />
-
-        </androidx.constraintlayout.widget.ConstraintLayout>
 
         <com.google.android.material.card.MaterialCardView
             style="?attr/materialCardViewElevatedStyle"

src/android/app/src/main/res/layout/fragment_game_info.xml

@@ -118,14 +118,6 @@
                 android:layout_marginTop="16dp"
                 android:text="@string/copy_details" />
 
-            <com.google.android.material.button.MaterialButton
-                android:id="@+id/button_verify_integrity"
-                style="@style/Widget.Material3.Button"
-                android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:layout_marginTop="10dp"
-                android:text="@string/verify_integrity" />
-
         </LinearLayout>
 
     </androidx.core.widget.NestedScrollView>

src/android/app/src/main/res/layout/fragment_game_properties.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.constraintlayout.widget.ConstraintLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
@@ -21,35 +22,16 @@
             android:orientation="vertical"
             android:gravity="center_horizontal">
 
-            <androidx.constraintlayout.widget.ConstraintLayout
+            <Button
-                android:layout_width="match_parent"
+                android:id="@+id/button_back"
+                style="?attr/materialIconButtonStyle"
+                android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_margin="8dp"
-                android:orientation="horizontal">
+                android:layout_gravity="start"
-
+                app:icon="@drawable/ic_back"
-                <Button
+                app:iconSize="24dp"
-                    android:id="@+id/button_back"
+                app:iconTint="?attr/colorOnSurface" />
-                    style="?attr/materialIconButtonStyle"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    app:icon="@drawable/ic_back"
-                    app:iconSize="24dp"
-                    app:iconTint="?attr/colorOnSurface"
-                    app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toTopOf="parent" />
-
-                <Button
-                    android:id="@+id/button_shortcut"
-                    style="?attr/materialIconButtonStyle"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    app:icon="@drawable/ic_shortcut"
-                    app:iconSize="24dp"
-                    app:iconTint="?attr/colorOnSurface"
-                    app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintTop_toTopOf="parent" />
-
-            </androidx.constraintlayout.widget.ConstraintLayout>
 
             <com.google.android.material.card.MaterialCardView
                 style="?attr/materialCardViewElevatedStyle"
@@ -63,7 +45,7 @@
                     android:id="@+id/image_game_screen"
                     android:layout_width="175dp"
                     android:layout_height="175dp"
-                    tools:src="@drawable/default_icon" />
+                    tools:src="@drawable/default_icon"/>
 
             </com.google.android.material.card.MaterialCardView>
 

src/android/app/src/main/res/menu/menu_in_game.xml

@@ -21,11 +21,6 @@
         android:icon="@drawable/ic_controller"
         android:title="@string/emulation_input_overlay" />
 
-    <item
-        android:id="@+id/menu_lock_drawer"
-        android:icon="@drawable/ic_unlock"
-        android:title="@string/emulation_input_overlay" />
-
     <item
         android:id="@+id/menu_exit"
         android:icon="@drawable/ic_exit"

src/android/app/src/main/res/values/strings.xml

@@ -142,8 +142,6 @@
         <item quantity="other">Successfully imported %d saves</item>
     </plurals>
     <string name="no_save_data_found">No save data found</string>
-    <string name="verify_installed_content">Verify installed content</string>
-    <string name="verify_installed_content_description">Checks all installed content for corruption</string>
 
     <!-- Applet launcher strings -->
     <string name="applets">Applet launcher</string>
@@ -290,7 +288,6 @@
     <string name="import_complete">Import complete</string>
     <string name="more_options">More options</string>
     <string name="use_global_setting">Use global setting</string>
-    <string name="operation_completed_successfully">The operation completed successfully</string>
 
     <!-- GPU driver installation -->
     <string name="select_gpu_driver">Select GPU driver</string>
@@ -355,14 +352,6 @@
     <string name="content_install_notice_description">The content that you selected does not match this game.\nInstall anyway?</string>
     <string name="confirm_uninstall">Confirm uninstall</string>
     <string name="confirm_uninstall_description">Are you sure you want to uninstall this addon?</string>
-    <string name="verify_integrity">Verify integrity</string>
-    <string name="verifying">Verifying…</string>
-    <string name="verify_success">Integrity verification succeeded!</string>
-    <string name="verify_failure">Integrity verification failed!</string>
-    <string name="verify_failure_description">File contents may be corrupt</string>
-    <string name="verify_no_result">Integrity verification couldn\'t be performed</string>
-    <string name="verify_no_result_description">File contents were not checked for validity</string>
-    <string name="verification_failed_for">Verification failed for the following files:\n%1$s</string>
 
     <!-- ROM loading errors -->
     <string name="loader_error_encrypted">Your ROM is encrypted</string>
@@ -392,8 +381,6 @@
     <string name="emulation_unpause">Unpause emulation</string>
     <string name="emulation_input_overlay">Overlay options</string>
     <string name="touchscreen">Touchscreen</string>
-    <string name="lock_drawer">Lock drawer</string>
-    <string name="unlock_drawer">Unlock drawer</string>
 
     <string name="load_settings">Loading settings…</string>
 

src/common/CMakeLists.txt

@@ -106,7 +106,6 @@ add_library(common STATIC
     precompiled_headers.h
     quaternion.h
     range_map.h
-    range_mutex.h
     reader_writer_queue.h
     ring_buffer.h
     ${CMAKE_CURRENT_BINARY_DIR}/scm_rev.cpp

src/common/range_mutex.h

@@ -1,93 +0,0 @@
-// SPDX-FileCopyrightText: 2024 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-#pragma once
-
-#include <condition_variable>
-#include <mutex>
-
-#include "common/intrusive_list.h"
-
-namespace Common {
-
-class ScopedRangeLock;
-
-class RangeMutex {
-public:
-    explicit RangeMutex() = default;
-    ~RangeMutex() = default;
-
-private:
-    friend class ScopedRangeLock;
-
-    void Lock(ScopedRangeLock& l);
-    void Unlock(ScopedRangeLock& l);
-    bool HasIntersectionLocked(ScopedRangeLock& l);
-
-private:
-    std::mutex m_mutex;
-    std::condition_variable m_cv;
-
-    using LockList = Common::IntrusiveListBaseTraits<ScopedRangeLock>::ListType;
-    LockList m_list;
-};
-
-class ScopedRangeLock : public Common::IntrusiveListBaseNode<ScopedRangeLock> {
-public:
-    explicit ScopedRangeLock(RangeMutex& mutex, u64 address, u64 size)
-        : m_mutex(mutex), m_address(address), m_size(size) {
-        if (m_size > 0) {
-            m_mutex.Lock(*this);
-        }
-    }
-    ~ScopedRangeLock() {
-        if (m_size > 0) {
-            m_mutex.Unlock(*this);
-        }
-    }
-
-    u64 GetAddress() const {
-        return m_address;
-    }
-
-    u64 GetSize() const {
-        return m_size;
-    }
-
-private:
-    RangeMutex& m_mutex;
-    const u64 m_address{};
-    const u64 m_size{};
-};
-
-inline void RangeMutex::Lock(ScopedRangeLock& l) {
-    std::unique_lock lk{m_mutex};
-    m_cv.wait(lk, [&] { return !HasIntersectionLocked(l); });
-    m_list.push_back(l);
-}
-
-inline void RangeMutex::Unlock(ScopedRangeLock& l) {
-    {
-        std::scoped_lock lk{m_mutex};
-        m_list.erase(m_list.iterator_to(l));
-    }
-    m_cv.notify_all();
-}
-
-inline bool RangeMutex::HasIntersectionLocked(ScopedRangeLock& l) {
-    const auto cur_begin = l.GetAddress();
-    const auto cur_last = l.GetAddress() + l.GetSize() - 1;
-
-    for (const auto& other : m_list) {
-        const auto other_begin = other.GetAddress();
-        const auto other_last = other.GetAddress() + other.GetSize() - 1;
-
-        if (cur_begin <= other_last && other_begin <= cur_last) {
-            return true;
-        }
-    }
-
-    return false;
-}
-
-} // namespace Common

src/common/settings.h

@@ -420,15 +420,10 @@ struct Values {
     SwitchableSetting<s64> custom_rtc{
         linkage, 0,    "custom_rtc",       Category::System, Specialization::Time,
         false,   true, &custom_rtc_enabled};
-    SwitchableSetting<s64, true> custom_rtc_offset{linkage,
+    SwitchableSetting<s64, false> custom_rtc_offset{
-                                                   0,
+        linkage, 0, "custom_rtc_offset", Category::System, Specialization::Countable, true, true};
-                                                   std::numeric_limits<int>::min(),
+    // Set on game boot, reset on stop. Seconds difference between current time and `custom_rtc`
-                                                   std::numeric_limits<int>::max(),
+    s64 custom_rtc_differential;
-                                                   "custom_rtc_offset",
-                                                   Category::System,
-                                                   Specialization::Countable,
-                                                   true,
-                                                   true};
     SwitchableSetting<bool> rng_seed_enabled{
         linkage, false, "rng_seed_enabled", Category::System, Specialization::Paired, true, true};
     SwitchableSetting<u32> rng_seed{

src/core/device_memory_manager.h

@@ -10,7 +10,6 @@
 #include <mutex>
 
 #include "common/common_types.h"
-#include "common/range_mutex.h"
 #include "common/scratch_buffer.h"
 #include "common/virtual_buffer.h"
 
@@ -205,7 +204,7 @@ private:
         (1ULL << (device_virtual_bits - page_bits)) / subentries;
     using CachedPages = std::array<CounterEntry, num_counter_entries>;
     std::unique_ptr<CachedPages> cached_pages;
-    Common::RangeMutex counter_guard;
+    std::mutex counter_guard;
     std::mutex mapping_guard;
 };
 

src/core/device_memory_manager.inc

@@ -509,7 +509,12 @@ void DeviceMemoryManager<Traits>::UnregisterProcess(Asid asid) {
 
 template <typename Traits>
 void DeviceMemoryManager<Traits>::UpdatePagesCachedCount(DAddr addr, size_t size, s32 delta) {
-    Common::ScopedRangeLock lk(counter_guard, addr, size);
+    std::unique_lock<std::mutex> lk(counter_guard, std::defer_lock);
+    const auto Lock = [&] {
+        if (!lk) {
+            lk.lock();
+        }
+    };
     u64 uncache_begin = 0;
     u64 cache_begin = 0;
     u64 uncache_bytes = 0;
@@ -544,6 +549,7 @@ void DeviceMemoryManager<Traits>::UpdatePagesCachedCount(DAddr addr, size_t size
             }
             uncache_bytes += Memory::YUZU_PAGESIZE;
         } else if (uncache_bytes > 0) {
+            Lock();
             MarkRegionCaching(memory_device_inter, uncache_begin << Memory::YUZU_PAGEBITS,
                               uncache_bytes, false);
             uncache_bytes = 0;
@@ -554,6 +560,7 @@ void DeviceMemoryManager<Traits>::UpdatePagesCachedCount(DAddr addr, size_t size
             }
             cache_bytes += Memory::YUZU_PAGESIZE;
         } else if (cache_bytes > 0) {
+            Lock();
             MarkRegionCaching(memory_device_inter, cache_begin << Memory::YUZU_PAGEBITS, cache_bytes,
                               true);
             cache_bytes = 0;
@@ -561,10 +568,12 @@ void DeviceMemoryManager<Traits>::UpdatePagesCachedCount(DAddr addr, size_t size
         vpage++;
     }
     if (uncache_bytes > 0) {
+        Lock();
         MarkRegionCaching(memory_device_inter, uncache_begin << Memory::YUZU_PAGEBITS, uncache_bytes,
                           false);
     }
     if (cache_bytes > 0) {
+        Lock();
         MarkRegionCaching(memory_device_inter, cache_begin << Memory::YUZU_PAGEBITS, cache_bytes,
                           true);
     }

src/core/hle/service/glue/time/static.cpp

@@ -284,10 +284,9 @@ void StaticService::Handle_GetClockSnapshotFromSystemClockContext(HLERequestCont
     LOG_DEBUG(Service_Time, "called.");
 
     IPC::RequestParser rp{ctx};
-    auto clock_type{rp.PopEnum<Service::PSC::Time::TimeType>()};
-    [[maybe_unused]] auto alignment{rp.Pop<u32>()};
     auto user_context{rp.PopRaw<Service::PSC::Time::SystemClockContext>()};
     auto network_context{rp.PopRaw<Service::PSC::Time::SystemClockContext>()};
+    auto clock_type{rp.PopEnum<Service::PSC::Time::TimeType>()};
 
     Service::PSC::Time::ClockSnapshot snapshot{};
     auto res =

src/core/hle/service/hid/hid_system_server.cpp

@@ -533,7 +533,7 @@ void IHidSystemServer::EnableAppletToGetInput(HLERequestContext& ctx) {
              parameters.is_enabled, parameters.applet_resource_user_id);
 
     GetResourceManager()->EnableInput(parameters.applet_resource_user_id, parameters.is_enabled);
-    GetResourceManager()->GetNpad()->EnableAppletToGetInput(parameters.applet_resource_user_id);
+    // GetResourceManager()->GetNpad()->EnableInput(parameters.applet_resource_user_id);
 
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(ResultSuccess);
@@ -596,7 +596,7 @@ void IHidSystemServer::EnableAppletToGetPadInput(HLERequestContext& ctx) {
              parameters.is_enabled, parameters.applet_resource_user_id);
 
     GetResourceManager()->EnablePadInput(parameters.applet_resource_user_id, parameters.is_enabled);
-    GetResourceManager()->GetNpad()->EnableAppletToGetInput(parameters.applet_resource_user_id);
+    // GetResourceManager()->GetNpad()->EnableInput(parameters.applet_resource_user_id);
 
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(ResultSuccess);

src/core/hle/service/psc/time/service_manager.cpp

@@ -119,21 +119,15 @@ void ServiceManager::Handle_GetStaticServiceAsServiceManager(HLERequestContext&
 void ServiceManager::Handle_SetupStandardSteadyClockCore(HLERequestContext& ctx) {
     LOG_DEBUG(Service_Time, "called.");
 
-    struct Parameters {
-        bool reset_detected;
-        Common::UUID clock_source_id;
-        s64 rtc_offset;
-        s64 internal_offset;
-        s64 test_offset;
-    };
-    static_assert(sizeof(Parameters) == 0x30);
-
     IPC::RequestParser rp{ctx};
-    auto params{rp.PopRaw<Parameters>()};
+    auto clock_source_id{rp.PopRaw<Common::UUID>()};
+    auto rtc_offset{rp.Pop<s64>()};
+    auto internal_offset{rp.Pop<s64>()};
+    auto test_offset{rp.Pop<s64>()};
+    auto is_rtc_reset_detected{rp.Pop<bool>()};
 
-    auto res = SetupStandardSteadyClockCore(params.clock_source_id, params.rtc_offset,
+    auto res = SetupStandardSteadyClockCore(clock_source_id, rtc_offset, internal_offset,
-                                            params.internal_offset, params.test_offset,
+                                            test_offset, is_rtc_reset_detected);
-                                            params.reset_detected);
 
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(res);
@@ -168,16 +162,11 @@ void ServiceManager::Handle_SetupStandardNetworkSystemClockCore(HLERequestContex
 void ServiceManager::Handle_SetupStandardUserSystemClockCore(HLERequestContext& ctx) {
     LOG_DEBUG(Service_Time, "called.");
 
-    struct Parameters {
-        bool automatic_correction;
-        SteadyClockTimePoint time_point;
-    };
-    static_assert(sizeof(Parameters) == 0x20);
-
     IPC::RequestParser rp{ctx};
-    auto params{rp.PopRaw<Parameters>()};
+    auto time_point{rp.PopRaw<SteadyClockTimePoint>()};
+    auto automatic_correction{rp.Pop<bool>()};
 
-    auto res = SetupStandardUserSystemClockCore(params.time_point, params.automatic_correction);
+    auto res = SetupStandardUserSystemClockCore(time_point, automatic_correction);
 
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(res);
@@ -186,21 +175,16 @@ void ServiceManager::Handle_SetupStandardUserSystemClockCore(HLERequestContext&
 void ServiceManager::Handle_SetupTimeZoneServiceCore(HLERequestContext& ctx) {
     LOG_DEBUG(Service_Time, "called.");
 
-    struct Parameters {
-        u32 location_count;
-        LocationName name;
-        SteadyClockTimePoint time_point;
-        RuleVersion rule_version;
-    };
-    static_assert(sizeof(Parameters) == 0x50);
-
     IPC::RequestParser rp{ctx};
-    auto params{rp.PopRaw<Parameters>()};
+    auto name{rp.PopRaw<LocationName>()};
+    auto time_point{rp.PopRaw<SteadyClockTimePoint>()};
+    auto rule_version{rp.PopRaw<RuleVersion>()};
+    auto location_count{rp.Pop<u32>()};
 
     auto rule_buffer{ctx.ReadBuffer()};
 
-    auto res = SetupTimeZoneServiceCore(params.name, params.time_point, params.rule_version,
+    auto res =
-                                        params.location_count, rule_buffer);
+        SetupTimeZoneServiceCore(name, time_point, rule_version, location_count, rule_buffer);
 
     IPC::ResponseBuilder rb{ctx, 2};
     rb.Push(res);
@@ -302,22 +286,11 @@ void ServiceManager::Handle_GetClosestAlarmInfo(HLERequestContext& ctx) {
     s64 time{};
     auto res = GetClosestAlarmInfo(is_valid, alarm_info, time);
 
-    struct OutParameters {
+    IPC::ResponseBuilder rb{ctx, 5 + sizeof(AlarmInfo) / sizeof(u32)};
-        bool is_valid;
-        AlarmInfo alarm_info;
-        s64 time;
-    };
-    static_assert(sizeof(OutParameters) == 0x20);
-
-    OutParameters out_params{
-        .is_valid = is_valid,
-        .alarm_info = alarm_info,
-        .time = time,
-    };
-
-    IPC::ResponseBuilder rb{ctx, 2 + sizeof(OutParameters) / sizeof(u32)};
     rb.Push(res);
-    rb.PushRaw<OutParameters>(out_params);
+    rb.PushRaw<AlarmInfo>(alarm_info);
+    rb.Push<bool>(is_valid);
+    rb.Push<s64>(time);
 }
 
 // =============================== Implementations ===========================

src/core/hle/service/psc/time/static.cpp

@@ -277,10 +277,9 @@ void StaticService::Handle_GetClockSnapshotFromSystemClockContext(HLERequestCont
     LOG_DEBUG(Service_Time, "called.");
 
     IPC::RequestParser rp{ctx};
-    auto clock_type{rp.PopEnum<TimeType>()};
-    [[maybe_unused]] auto alignment{rp.Pop<u32>()};
     auto user_context{rp.PopRaw<SystemClockContext>()};
     auto network_context{rp.PopRaw<SystemClockContext>()};
+    auto clock_type{rp.PopEnum<TimeType>()};
 
     ClockSnapshot snapshot{};
     auto res =

src/core/hle/service/psc/time/steady_clock.cpp

@@ -15,12 +15,12 @@ SteadyClock::SteadyClock(Core::System& system_, std::shared_ptr<TimeManager> man
     // clang-format off
          static const FunctionInfo functions[] = {
         {0, &SteadyClock::Handle_GetCurrentTimePoint, "GetCurrentTimePoint"},
-        {2, &SteadyClock::Handle_GetTestOffset, "GetTestOffset"},
+        {1, &SteadyClock::Handle_GetTestOffset, "GetTestOffset"},
-        {3, &SteadyClock::Handle_SetTestOffset, "SetTestOffset"},
+        {2, &SteadyClock::Handle_SetTestOffset, "SetTestOffset"},
-        {100, &SteadyClock::Handle_GetRtcValue, "GetRtcValue"},
+        {3, &SteadyClock::Handle_GetRtcValue, "GetRtcValue"},
-        {101, &SteadyClock::Handle_IsRtcResetDetected, "IsRtcResetDetected"},
+        {4, &SteadyClock::Handle_IsRtcResetDetected, "IsRtcResetDetected"},
-        {102, &SteadyClock::Handle_GetSetupResultValue, "GetSetupResultValue"},
+        {5, &SteadyClock::Handle_GetSetupResultValue, "GetSetupResultValue"},
-        {200, &SteadyClock::Handle_GetInternalOffset, "GetInternalOffset"},
+        {6, &SteadyClock::Handle_GetInternalOffset, "GetInternalOffset"},
     };
     // clang-format on
     RegisterHandlers(functions);

src/core/memory.cpp

@@ -1093,20 +1093,6 @@ bool Memory::InvalidateNCE(Common::ProcessAddress vaddr, size_t size) {
         [&] { rasterizer = true; });
     if (rasterizer) {
         impl->InvalidateGPUMemory(ptr, size);
-
-        const auto type = impl->current_page_table->pointers[vaddr >> YUZU_PAGEBITS].Type();
-        if (type == Common::PageType::RasterizerCachedMemory) {
-            // Check if device mapped. If not, this bugged and we can unmark.
-            DAddr addr{};
-            Common::ScratchBuffer<u32> buffer;
-            impl->gpu_device_memory->ApplyOpOnPointer(ptr, buffer,
-                                                      [&](DAddr address) { addr = address; });
-
-            if (addr == 0) {
-                LOG_ERROR(HW_Memory, "Fixing unmapped cached region {:#x}", GetInteger(vaddr));
-                impl->RasterizerMarkRegionCached(GetInteger(vaddr), size, false);
-            }
-        }
     }
 
 #ifdef __linux__

src/frontend_common/content_manager.h

@@ -11,12 +11,10 @@
 #include "core/file_sys/content_archive.h"
 #include "core/file_sys/mode.h"
 #include "core/file_sys/nca_metadata.h"
-#include "core/file_sys/patch_manager.h"
 #include "core/file_sys/registered_cache.h"
 #include "core/file_sys/submission_package.h"
 #include "core/hle/service/filesystem/filesystem.h"
 #include "core/loader/loader.h"
-#include "core/loader/nca.h"
 
 namespace ContentManager {
 
@@ -27,12 +25,6 @@ enum class InstallResult {
     BaseInstallAttempted,
 };
 
-enum class GameVerificationResult {
-    Success,
-    Failed,
-    NotImplemented,
-};
-
 /**
  * \brief Removes a single installed DLC
  * \param fs_controller [FileSystemController] reference from the Core::System instance
@@ -127,14 +119,14 @@ inline bool RemoveMod(const Service::FileSystem::FileSystemController& fs_contro
  * \param system Raw pointer to the system instance
  * \param vfs Raw pointer to the VfsFilesystem instance in Core::System
  * \param filename Path to the NSP file
- * \param callback Callback to report the progress of the installation. The first size_t
+ * \param callback Optional callback to report the progress of the installation. The first size_t
  * parameter is the total size of the virtual file and the second is the current progress. If you
- * return true to the callback, it will cancel the installation as soon as possible.
+ * return false to the callback, it will cancel the installation as soon as possible.
  * \return [InstallResult] representing how the installation finished
  */
-inline InstallResult InstallNSP(Core::System* system, FileSys::VfsFilesystem* vfs,
+inline InstallResult InstallNSP(
-                                const std::string& filename,
+    Core::System* system, FileSys::VfsFilesystem* vfs, const std::string& filename,
-                                const std::function<bool(size_t, size_t)>& callback) {
+    const std::function<bool(size_t, size_t)>& callback = std::function<bool(size_t, size_t)>()) {
     const auto copy = [callback](const FileSys::VirtualFile& src, const FileSys::VirtualFile& dest,
                                  std::size_t block_size) {
         if (src == nullptr || dest == nullptr) {
@@ -192,15 +184,15 @@ inline InstallResult InstallNSP(Core::System* system, FileSys::VfsFilesystem* vf
  * \param filename Path to the NCA file
  * \param registered_cache Raw pointer to the registered cache that the NCA will be installed to
  * \param title_type Type of NCA package to install
- * \param callback Callback to report the progress of the installation. The first size_t
+ * \param callback Optional callback to report the progress of the installation. The first size_t
  * parameter is the total size of the virtual file and the second is the current progress. If you
- * return true to the callback, it will cancel the installation as soon as possible.
+ * return false to the callback, it will cancel the installation as soon as possible.
  * \return [InstallResult] representing how the installation finished
  */
-inline InstallResult InstallNCA(FileSys::VfsFilesystem* vfs, const std::string& filename,
+inline InstallResult InstallNCA(
-                                FileSys::RegisteredCache* registered_cache,
+    FileSys::VfsFilesystem* vfs, const std::string& filename,
-                                const FileSys::TitleType title_type,
+    FileSys::RegisteredCache* registered_cache, const FileSys::TitleType title_type,
-                                const std::function<bool(size_t, size_t)>& callback) {
+    const std::function<bool(size_t, size_t)>& callback = std::function<bool(size_t, size_t)>()) {
     const auto copy = [callback](const FileSys::VirtualFile& src, const FileSys::VirtualFile& dest,
                                  std::size_t block_size) {
         if (src == nullptr || dest == nullptr) {
@@ -243,129 +235,4 @@ inline InstallResult InstallNCA(FileSys::VfsFilesystem* vfs, const std::string&
     }
 }
 
-/**
- * \brief Verifies the installed contents for a given ManualContentProvider
- * \param system Raw pointer to the system instance
- * \param provider Raw pointer to the content provider that's tracking indexed games
- * \param callback Callback to report the progress of the installation. The first size_t
- * parameter is the total size of the installed contents and the second is the current progress. If
- * you return true to the callback, it will cancel the installation as soon as possible.
- * \return A list of entries that failed to install. Returns an empty vector if successful.
- */
-inline std::vector<std::string> VerifyInstalledContents(
-    Core::System* system, FileSys::ManualContentProvider* provider,
-    const std::function<bool(size_t, size_t)>& callback) {
-    // Get content registries.
-    auto bis_contents = system->GetFileSystemController().GetSystemNANDContents();
-    auto user_contents = system->GetFileSystemController().GetUserNANDContents();
-
-    std::vector<FileSys::RegisteredCache*> content_providers;
-    if (bis_contents) {
-        content_providers.push_back(bis_contents);
-    }
-    if (user_contents) {
-        content_providers.push_back(user_contents);
-    }
-
-    // Get associated NCA files.
-    std::vector<FileSys::VirtualFile> nca_files;
-
-    // Get all installed IDs.
-    size_t total_size = 0;
-    for (auto nca_provider : content_providers) {
-        const auto entries = nca_provider->ListEntriesFilter();
-
-        for (const auto& entry : entries) {
-            auto nca_file = nca_provider->GetEntryRaw(entry.title_id, entry.type);
-            if (!nca_file) {
-                continue;
-            }
-
-            total_size += nca_file->GetSize();
-            nca_files.push_back(std::move(nca_file));
-        }
-    }
-
-    // Declare a list of file names which failed to verify.
-    std::vector<std::string> failed;
-
-    size_t processed_size = 0;
-    bool cancelled = false;
-    auto nca_callback = [&](size_t nca_processed, size_t nca_total) {
-        cancelled = callback(total_size, processed_size + nca_processed);
-        return !cancelled;
-    };
-
-    // Using the NCA loader, determine if all NCAs are valid.
-    for (auto& nca_file : nca_files) {
-        Loader::AppLoader_NCA nca_loader(nca_file);
-
-        auto status = nca_loader.VerifyIntegrity(nca_callback);
-        if (cancelled) {
-            break;
-        }
-        if (status != Loader::ResultStatus::Success) {
-            FileSys::NCA nca(nca_file);
-            const auto title_id = nca.GetTitleId();
-            std::string title_name = "unknown";
-
-            const auto control = provider->GetEntry(FileSys::GetBaseTitleID(title_id),
-                                                    FileSys::ContentRecordType::Control);
-            if (control && control->GetStatus() == Loader::ResultStatus::Success) {
-                const FileSys::PatchManager pm{title_id, system->GetFileSystemController(),
-                                               *provider};
-                const auto [nacp, logo] = pm.ParseControlNCA(*control);
-                if (nacp) {
-                    title_name = nacp->GetApplicationName();
-                }
-            }
-
-            if (title_id > 0) {
-                failed.push_back(
-                    fmt::format("{} ({:016X}) ({})", nca_file->GetName(), title_id, title_name));
-            } else {
-                failed.push_back(fmt::format("{} (unknown)", nca_file->GetName()));
-            }
-        }
-
-        processed_size += nca_file->GetSize();
-    }
-    return failed;
-}
-
-/**
- * \brief Verifies the contents of a given game
- * \param system Raw pointer to the system instance
- * \param game_path Patch to the game file
- * \param callback Callback to report the progress of the installation. The first size_t
- * parameter is the total size of the installed contents and the second is the current progress. If
- * you return true to the callback, it will cancel the installation as soon as possible.
- * \return GameVerificationResult representing how the verification process finished
- */
-inline GameVerificationResult VerifyGameContents(
-    Core::System* system, const std::string& game_path,
-    const std::function<bool(size_t, size_t)>& callback) {
-    const auto loader = Loader::GetLoader(
-        *system, system->GetFilesystem()->OpenFile(game_path, FileSys::Mode::Read));
-    if (loader == nullptr) {
-        return GameVerificationResult::NotImplemented;
-    }
-
-    bool cancelled = false;
-    auto loader_callback = [&](size_t processed, size_t total) {
-        cancelled = callback(total, processed);
-        return !cancelled;
-    };
-
-    const auto status = loader->VerifyIntegrity(loader_callback);
-    if (cancelled || status == Loader::ResultStatus::ErrorIntegrityVerificationNotImplemented) {
-        return GameVerificationResult::NotImplemented;
-    }
-
-    if (status == Loader::ResultStatus::ErrorIntegrityVerificationFailed) {
-        return GameVerificationResult::Failed;
-    }
-    return GameVerificationResult::Success;
-}
-
 } // namespace ContentManager

src/hid_core/frontend/emulated_controller.cpp

@@ -1240,17 +1240,12 @@ bool EmulatedController::SetVibration(DeviceIndex device_index, const VibrationV
     if (!output_devices[index]) {
         return false;
     }
-
-    last_vibration_value = vibration;
-
-    if (!Settings::values.vibration_enabled) {
-        return false;
-    }
-
     const auto player_index = Service::HID::NpadIdTypeToIndex(npad_id_type);
     const auto& player = Settings::values.players.GetValue()[player_index];
     const f32 strength = static_cast<f32>(player.vibration_strength) / 100.0f;
 
+    last_vibration_value = vibration;
+
     if (!player.vibration_enabled) {
         return false;
     }

src/hid_core/resources/npad/npad.cpp

@@ -480,10 +480,6 @@ void NPad::OnUpdate(const Core::Timing::CoreTiming& core_timing) {
                 continue;
             }
 
-            if (!data->flag.enable_pad_input) {
-                continue;
-            }
-
             RequestPadStateUpdate(aruid, controller.device->GetNpadIdType());
             auto& pad_state = controller.npad_pad_state;
             auto& libnx_state = controller.npad_libnx_state;
@@ -1320,13 +1316,4 @@ void NPad::UpdateHandheldAbstractState() {
     abstracted_pads[NpadIdTypeToIndex(Core::HID::NpadIdType::Handheld)].Update();
 }
 
-void NPad::EnableAppletToGetInput(u64 aruid) {
-    std::scoped_lock lock{mutex};
-    std::scoped_lock shared_lock{*applet_resource_holder.shared_mutex};
-
-    for (auto& abstract_pad : abstracted_pads) {
-        abstract_pad.EnableAppletToGetInput(aruid);
-    }
-}
-
 } // namespace Service::HID

src/hid_core/resources/npad/npad.h

@@ -153,8 +153,6 @@ public:
 
     void UpdateHandheldAbstractState();
 
-    void EnableAppletToGetInput(u64 aruid);
-
 private:
     struct NpadControllerData {
         NpadInternalState* shared_memory = nullptr;

src/video_core/buffer_cache/buffer_cache.h

@@ -1546,10 +1546,7 @@ void BufferCache<P>::ImmediateUploadMemory([[maybe_unused]] Buffer& buffer,
             std::span<const u8> upload_span;
             const DAddr device_addr = buffer.CpuAddr() + copy.dst_offset;
             if (IsRangeGranular(device_addr, copy.size)) {
-                auto* const ptr = device_memory.GetPointer<u8>(device_addr);
+                upload_span = std::span(device_memory.GetPointer<u8>(device_addr), copy.size);
-                if (ptr != nullptr) {
-                    upload_span = std::span(ptr, copy.size);
-                }
             } else {
                 if (immediate_buffer.empty()) {
                     immediate_buffer = ImmediateBuffer(largest_copy);

src/video_core/renderer_opengl/renderer_opengl.cpp

@@ -243,12 +243,10 @@ void RendererOpenGL::LoadFBToScreenInfo(const Tegra::FramebufferConfig& framebuf
     const u64 size_in_bytes{Tegra::Texture::CalculateSize(
         true, bytes_per_pixel, framebuffer.stride, framebuffer.height, 1, block_height_log2, 0)};
     const u8* const host_ptr{device_memory.GetPointer<u8>(framebuffer_addr)};
-    if (host_ptr != nullptr) {
+    const std::span<const u8> input_data(host_ptr, size_in_bytes);
-        const std::span<const u8> input_data(host_ptr, size_in_bytes);
+    Tegra::Texture::UnswizzleTexture(gl_framebuffer_data, input_data, bytes_per_pixel,
-        Tegra::Texture::UnswizzleTexture(gl_framebuffer_data, input_data, bytes_per_pixel,
+                                     framebuffer.width, framebuffer.height, 1, block_height_log2,
-                                         framebuffer.width, framebuffer.height, 1,
+                                     0);
-                                         block_height_log2, 0);
-    }
 
     glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0);
     glPixelStorei(GL_UNPACK_ROW_LENGTH, static_cast<GLint>(framebuffer.stride));

src/video_core/renderer_vulkan/vk_blit_screen.cpp

@@ -230,11 +230,9 @@ void BlitScreen::Draw(const Tegra::FramebufferConfig& framebuffer,
         const u64 tiled_size{Tegra::Texture::CalculateSize(true, bytes_per_pixel,
                                                            framebuffer.stride, framebuffer.height,
                                                            1, block_height_log2, 0)};
-        if (host_ptr != nullptr) {
+        Tegra::Texture::UnswizzleTexture(
-            Tegra::Texture::UnswizzleTexture(
+            mapped_span.subspan(image_offset, linear_size), std::span(host_ptr, tiled_size),
-                mapped_span.subspan(image_offset, linear_size), std::span(host_ptr, tiled_size),
+            bytes_per_pixel, framebuffer.width, framebuffer.height, 1, block_height_log2, 0);
-                bytes_per_pixel, framebuffer.width, framebuffer.height, 1, block_height_log2, 0);
-        }
 
         const VkBufferImageCopy copy{
             .bufferOffset = image_offset,

src/video_core/renderer_vulkan/vk_query_cache.cpp

@@ -1064,6 +1064,8 @@ public:
                 }
             });
         }
+        auto* ptr = device_memory.GetPointer<u8>(new_query->dependant_address);
+        ASSERT(ptr != nullptr);
 
         new_query->dependant_manage = must_manage_dependance;
         pending_flush_queries.push_back(index);
@@ -1102,11 +1104,9 @@ public:
                 tfb_streamer.Free(query->dependant_index);
             } else {
                 u8* pointer = device_memory.GetPointer<u8>(query->dependant_address);
-                if (pointer != nullptr) {
+                u32 result;
-                    u32 result;
+                std::memcpy(&result, pointer, sizeof(u32));
-                    std::memcpy(&result, pointer, sizeof(u32));
+                num_vertices = static_cast<u64>(result) / query->stride;
-                    num_vertices = static_cast<u64>(result) / query->stride;
-                }
             }
             query->value = [&]() -> u64 {
                 switch (query->topology) {
@@ -1360,9 +1360,7 @@ bool QueryCacheRuntime::HostConditionalRenderingCompareValues(VideoCommon::Looku
     const auto check_value = [&](DAddr address) {
         u8* ptr = impl->device_memory.GetPointer<u8>(address);
         u64 value{};
-        if (ptr != nullptr) {
+        std::memcpy(&value, ptr, sizeof(value));
-            std::memcpy(&value, ptr, sizeof(value));
-        }
         return value == 0;
     };
     std::array<VideoCommon::LookupData*, 2> objects{&object_1, &object_2};

src/yuzu/main.cpp

@@ -2786,6 +2786,16 @@ void GMainWindow::OnGameListVerifyIntegrity(const std::string& game_path) {
         QMessageBox::warning(this, tr("Integrity verification couldn't be performed!"),
                              tr("File contents were not checked for validity."));
     };
+    const auto Failed = [this] {
+        QMessageBox::critical(this, tr("Integrity verification failed!"),
+                              tr("File contents may be corrupt."));
+    };
+
+    const auto loader = Loader::GetLoader(*system, vfs->OpenFile(game_path, FileSys::Mode::Read));
+    if (loader == nullptr) {
+        NotImplemented();
+        return;
+    }
 
     QProgressDialog progress(tr("Verifying integrity..."), tr("Cancel"), 0, 100, this);
     progress.setWindowModality(Qt::WindowModal);
@@ -2793,26 +2803,30 @@ void GMainWindow::OnGameListVerifyIntegrity(const std::string& game_path) {
     progress.setAutoClose(false);
     progress.setAutoReset(false);
 
-    const auto QtProgressCallback = [&](size_t total_size, size_t processed_size) {
+    const auto QtProgressCallback = [&](size_t processed_size, size_t total_size) {
+        if (progress.wasCanceled()) {
+            return false;
+        }
+
         progress.setValue(static_cast<int>((processed_size * 100) / total_size));
-        return progress.wasCanceled();
+        return true;
     };
 
-    const auto result =
+    const auto status = loader->VerifyIntegrity(QtProgressCallback);
-        ContentManager::VerifyGameContents(system.get(), game_path, QtProgressCallback);
+    if (progress.wasCanceled() ||
-    progress.close();
+        status == Loader::ResultStatus::ErrorIntegrityVerificationNotImplemented) {
-    switch (result) {
-    case ContentManager::GameVerificationResult::Success:
-        QMessageBox::information(this, tr("Integrity verification succeeded!"),
-                                 tr("The operation completed successfully."));
-        break;
-    case ContentManager::GameVerificationResult::Failed:
-        QMessageBox::critical(this, tr("Integrity verification failed!"),
-                              tr("File contents may be corrupt."));
-        break;
-    case ContentManager::GameVerificationResult::NotImplemented:
         NotImplemented();
+        return;
     }
+
+    if (status == Loader::ResultStatus::ErrorIntegrityVerificationFailed) {
+        Failed();
+        return;
+    }
+
+    progress.close();
+    QMessageBox::information(this, tr("Integrity verification succeeded!"),
+                             tr("The operation completed successfully."));
 }
 
 void GMainWindow::OnGameListCopyTID(u64 program_id) {
@@ -4107,6 +4121,10 @@ void GMainWindow::OnOpenYuzuFolder() {
 }
 
 void GMainWindow::OnVerifyInstalledContents() {
+    // Declare sizes.
+    size_t total_size = 0;
+    size_t processed_size = 0;
+
     // Initialize a progress dialog.
     QProgressDialog progress(tr("Verifying integrity..."), tr("Cancel"), 0, 100, this);
     progress.setWindowModality(Qt::WindowModal);
@@ -4114,25 +4132,93 @@ void GMainWindow::OnVerifyInstalledContents() {
     progress.setAutoClose(false);
     progress.setAutoReset(false);
 
+    // Declare a list of file names which failed to verify.
+    std::vector<std::string> failed;
+
     // Declare progress callback.
-    auto QtProgressCallback = [&](size_t total_size, size_t processed_size) {
+    auto QtProgressCallback = [&](size_t nca_processed, size_t nca_total) {
-        progress.setValue(static_cast<int>((processed_size * 100) / total_size));
+        if (progress.wasCanceled()) {
-        return progress.wasCanceled();
+            return false;
+        }
+        progress.setValue(static_cast<int>(((processed_size + nca_processed) * 100) / total_size));
+        return true;
     };
 
-    const std::vector<std::string> result =
+    // Get content registries.
-        ContentManager::VerifyInstalledContents(system.get(), provider.get(), QtProgressCallback);
+    auto bis_contents = system->GetFileSystemController().GetSystemNANDContents();
+    auto user_contents = system->GetFileSystemController().GetUserNANDContents();
+
+    std::vector<FileSys::RegisteredCache*> content_providers;
+    if (bis_contents) {
+        content_providers.push_back(bis_contents);
+    }
+    if (user_contents) {
+        content_providers.push_back(user_contents);
+    }
+
+    // Get associated NCA files.
+    std::vector<FileSys::VirtualFile> nca_files;
+
+    // Get all installed IDs.
+    for (auto nca_provider : content_providers) {
+        const auto entries = nca_provider->ListEntriesFilter();
+
+        for (const auto& entry : entries) {
+            auto nca_file = nca_provider->GetEntryRaw(entry.title_id, entry.type);
+            if (!nca_file) {
+                continue;
+            }
+
+            total_size += nca_file->GetSize();
+            nca_files.push_back(std::move(nca_file));
+        }
+    }
+
+    // Using the NCA loader, determine if all NCAs are valid.
+    for (auto& nca_file : nca_files) {
+        Loader::AppLoader_NCA nca_loader(nca_file);
+
+        auto status = nca_loader.VerifyIntegrity(QtProgressCallback);
+        if (progress.wasCanceled()) {
+            break;
+        }
+        if (status != Loader::ResultStatus::Success) {
+            FileSys::NCA nca(nca_file);
+            const auto title_id = nca.GetTitleId();
+            std::string title_name = "unknown";
+
+            const auto control = provider->GetEntry(FileSys::GetBaseTitleID(title_id),
+                                                    FileSys::ContentRecordType::Control);
+            if (control && control->GetStatus() == Loader::ResultStatus::Success) {
+                const FileSys::PatchManager pm{title_id, system->GetFileSystemController(),
+                                               *provider};
+                const auto [nacp, logo] = pm.ParseControlNCA(*control);
+                if (nacp) {
+                    title_name = nacp->GetApplicationName();
+                }
+            }
+
+            if (title_id > 0) {
+                failed.push_back(
+                    fmt::format("{} ({:016X}) ({})", nca_file->GetName(), title_id, title_name));
+            } else {
+                failed.push_back(fmt::format("{} (unknown)", nca_file->GetName()));
+            }
+        }
+
+        processed_size += nca_file->GetSize();
+    }
+
     progress.close();
 
-    if (result.empty()) {
+    if (failed.size() > 0) {
-        QMessageBox::information(this, tr("Integrity verification succeeded!"),
+        auto failed_names = QString::fromStdString(fmt::format("{}", fmt::join(failed, "\n")));
-                                 tr("The operation completed successfully."));
-    } else {
-        const auto failed_names =
-            QString::fromStdString(fmt::format("{}", fmt::join(result, "\n")));
         QMessageBox::critical(
             this, tr("Integrity verification failed!"),
             tr("Verification failed for the following files:\n\n%1").arg(failed_names));
+    } else {
+        QMessageBox::information(this, tr("Integrity verification succeeded!"),
+                                 tr("The operation completed successfully."));
     }
 }