Vulkan: add temporary workaround for AMDVLK
This commit is contained in:
parent
6a1ecab2dd
commit
b99f94a7ff
|
@ -350,6 +350,8 @@ struct Values {
|
||||||
linkage, false, "disable_shader_loop_safety_checks", Category::RendererDebug};
|
linkage, false, "disable_shader_loop_safety_checks", Category::RendererDebug};
|
||||||
Setting<bool> enable_renderdoc_hotkey{linkage, false, "renderdoc_hotkey",
|
Setting<bool> enable_renderdoc_hotkey{linkage, false, "renderdoc_hotkey",
|
||||||
Category::RendererDebug};
|
Category::RendererDebug};
|
||||||
|
// TODO: remove this once AMDVLK supports VK_EXT_depth_bias_control
|
||||||
|
bool renderer_amdvlk_depth_bias_workaround{};
|
||||||
|
|
||||||
// System
|
// System
|
||||||
SwitchableSetting<Language, true> language_index{linkage,
|
SwitchableSetting<Language, true> language_index{linkage,
|
||||||
|
|
|
@ -381,6 +381,10 @@ struct System::Impl {
|
||||||
room_member->SendGameInfo(game_info);
|
room_member->SendGameInfo(game_info);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Workarounds:
|
||||||
|
// Activate this in Super Smash Brothers Ultimate, it only affects AMD cards using AMDVLK
|
||||||
|
Settings::values.renderer_amdvlk_depth_bias_workaround = program_id == 0x1006A800016E000ULL;
|
||||||
|
|
||||||
status = SystemResultStatus::Success;
|
status = SystemResultStatus::Success;
|
||||||
return status;
|
return status;
|
||||||
}
|
}
|
||||||
|
@ -440,6 +444,9 @@ struct System::Impl {
|
||||||
room_member->SendGameInfo(game_info);
|
room_member->SendGameInfo(game_info);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Workarounds
|
||||||
|
Settings::values.renderer_amdvlk_depth_bias_workaround = false;
|
||||||
|
|
||||||
LOG_DEBUG(Core, "Shutdown OK");
|
LOG_DEBUG(Core, "Shutdown OK");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -1050,6 +1050,9 @@ void RasterizerVulkan::UpdateDepthBias(Tegra::Engines::Maxwell3D::Regs& regs) {
|
||||||
if (device.IsExtDepthBiasControlSupported()) {
|
if (device.IsExtDepthBiasControlSupported()) {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
if (!Settings::values.renderer_amdvlk_depth_bias_workaround) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
// the base formulas can be obtained from here:
|
// the base formulas can be obtained from here:
|
||||||
// https://docs.microsoft.com/en-us/windows/win32/direct3d11/d3d10-graphics-programming-guide-output-merger-stage-depth-bias
|
// https://docs.microsoft.com/en-us/windows/win32/direct3d11/d3d10-graphics-programming-guide-output-merger-stage-depth-bias
|
||||||
const double rescale_factor =
|
const double rescale_factor =
|
||||||
|
|
|
@ -1051,6 +1051,13 @@ void Device::RemoveUnsuitableExtensions() {
|
||||||
RemoveExtensionFeatureIfUnsuitable(extensions.custom_border_color, features.custom_border_color,
|
RemoveExtensionFeatureIfUnsuitable(extensions.custom_border_color, features.custom_border_color,
|
||||||
VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
|
VK_EXT_CUSTOM_BORDER_COLOR_EXTENSION_NAME);
|
||||||
|
|
||||||
|
// VK_EXT_depth_bias_control
|
||||||
|
extensions.depth_bias_control =
|
||||||
|
features.depth_bias_control.depthBiasControl &&
|
||||||
|
features.depth_bias_control.leastRepresentableValueForceUnormRepresentation;
|
||||||
|
RemoveExtensionFeatureIfUnsuitable(extensions.depth_bias_control, features.depth_bias_control,
|
||||||
|
VK_EXT_DEPTH_BIAS_CONTROL_EXTENSION_NAME);
|
||||||
|
|
||||||
// VK_EXT_depth_clip_control
|
// VK_EXT_depth_clip_control
|
||||||
extensions.depth_clip_control = features.depth_clip_control.depthClipControl;
|
extensions.depth_clip_control = features.depth_clip_control.depthClipControl;
|
||||||
RemoveExtensionFeatureIfUnsuitable(extensions.depth_clip_control, features.depth_clip_control,
|
RemoveExtensionFeatureIfUnsuitable(extensions.depth_clip_control, features.depth_clip_control,
|
||||||
|
|
|
@ -456,8 +456,7 @@ public:
|
||||||
|
|
||||||
/// Returns true if the device supports VK_EXT_depth_bias_control.
|
/// Returns true if the device supports VK_EXT_depth_bias_control.
|
||||||
bool IsExtDepthBiasControlSupported() const {
|
bool IsExtDepthBiasControlSupported() const {
|
||||||
return extensions.depth_bias_control && features.depth_bias_control.depthBiasControl &&
|
return extensions.depth_bias_control;
|
||||||
features.depth_bias_control.leastRepresentableValueForceUnormRepresentation;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Returns true if the device supports VK_EXT_shader_viewport_index_layer.
|
/// Returns true if the device supports VK_EXT_shader_viewport_index_layer.
|
||||||
|
|
Loading…
Reference in New Issue