From e620754c159cb2ce2057f9d8f9e9722513500819 Mon Sep 17 00:00:00 2001 From: Zhiyuan Zheng Date: Fri, 19 Mar 2021 21:33:03 +0100 Subject: [PATCH 1/3] Fixed #59 --- src/screens/Compose.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/screens/Compose.tsx b/src/screens/Compose.tsx index 608e9b39..1fff369b 100644 --- a/src/screens/Compose.tsx +++ b/src/screens/Compose.tsx @@ -280,7 +280,14 @@ const ScreenCompose: React.FC = ({ composePost(params, composeState) .then(() => { haptics('Success') - dispatch(updateStoreReview(1)) + if ( + Platform.OS === 'ios' && + Platform.constants.osVersion === '13.3' + ) { + // https://github.com/tooot-app/app/issues/59 + } else { + dispatch(updateStoreReview(1)) + } const queryKey: QueryKeyTimeline = [ 'Timeline', { page: 'Following' } From 15cf29d952446ea80e2c1017dc14658a40103a8e Mon Sep 17 00:00:00 2001 From: Zhiyuan Zheng Date: Fri, 19 Mar 2021 21:44:52 +0100 Subject: [PATCH 2/3] Remove all FastImage --- src/components/GracefullyImage.tsx | 2 +- src/components/Parse/Emojis.tsx | 5 ++--- src/screens/Compose/DraftsList/Root.tsx | 4 ++-- src/screens/Compose/EditAttachment/Image.tsx | 5 ++--- src/screens/Compose/Root/Footer/Attachments.tsx | 12 +++++++++--- src/screens/Tabs.tsx | 5 ++--- src/screens/Tabs/Shared/Account/Header.tsx | 5 ++--- .../Tabs/Shared/Account/Information/Avatar.tsx | 2 +- 8 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/components/GracefullyImage.tsx b/src/components/GracefullyImage.tsx index 33f658a5..f7da33b2 100644 --- a/src/components/GracefullyImage.tsx +++ b/src/components/GracefullyImage.tsx @@ -19,7 +19,7 @@ import { Blurhash } from 'react-native-blurhash' export interface Props { hidden?: boolean - uri: { preview?: string; original: string; remote?: string } + uri: { preview?: string; original?: string; remote?: string } blurhash?: string dimension?: { width: number; height: number } onPress?: () => void diff --git a/src/components/Parse/Emojis.tsx b/src/components/Parse/Emojis.tsx index 00ce337c..c27d4407 100644 --- a/src/components/Parse/Emojis.tsx +++ b/src/components/Parse/Emojis.tsx @@ -3,8 +3,7 @@ import { StyleConstants } from '@utils/styles/constants' import { adaptiveScale } from '@utils/styles/scaling' import { useTheme } from '@utils/styles/ThemeManager' import React, { useMemo } from 'react' -import { StyleSheet, Text } from 'react-native' -import FastImage from 'react-native-fast-image' +import { Image, StyleSheet, Text } from 'react-native' import { useSelector } from 'react-redux' const regexEmoji = new RegExp(/(:[A-Za-z0-9_]+:)/) @@ -70,7 +69,7 @@ const ParseEmojis = React.memo( {/* When emoji starts a paragraph, lineHeight will break */} {i === 0 ? : null} - = ({ timestamp }) => { {item.attachments?.uploads.length ? ( {item.attachments.uploads.map((attachment, index) => ( - = ({ index }) => { return ( <> - { key={index} style={[styles.container, { width: calculateWidth(item) }]} > - case 'Tab-Me': return instanceActive !== -1 ? ( - = ({ account, limitHeight = false }) => { const topInset = useSafeAreaInsets().top return ( - = ({ account, myInfo }) => { ) From 6f0a0c43fead7115f1f0cfd4a6d29a4af8ea469f Mon Sep 17 00:00:00 2001 From: Zhiyuan Zheng Date: Fri, 19 Mar 2021 22:18:23 +0100 Subject: [PATCH 3/3] Try to capture more information --- src/api/general.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/api/general.ts b/src/api/general.ts index 56cda191..330d15c5 100644 --- a/src/api/general.ts +++ b/src/api/general.ts @@ -60,7 +60,8 @@ const apiGeneral = async ({ }) .catch(error => { if (sentry) { - Sentry.Native.captureException(error, { extra: error }) + Sentry.Native.setExtras(error.response) + Sentry.Native.captureException(error) } if (error.response) {