From 0c70cc26a67b9c8167b9536410d4bc74b05ef133 Mon Sep 17 00:00:00 2001 From: xmflsct Date: Sun, 6 Feb 2022 23:55:49 +0100 Subject: [PATCH 1/4] New translations timeline.json (Chinese Simplified) --- src/i18n/zh-Hans/components/timeline.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/i18n/zh-Hans/components/timeline.json b/src/i18n/zh-Hans/components/timeline.json index 52592cd7..45772dfd 100644 --- a/src/i18n/zh-Hans/components/timeline.json +++ b/src/i18n/zh-Hans/components/timeline.json @@ -12,7 +12,7 @@ "message": "居然刷到底了,喝杯 <0 /> 吧" }, "lookback": { - "message": "上次阅读至" + "message": "最后阅读于" }, "refresh": { "fetchPreviousPage": "较新于此的嘟嘟", From 311020285d4d3a5cd478f0547de67c17f63e4fef Mon Sep 17 00:00:00 2001 From: Zhiyuan Zheng Date: Tue, 8 Feb 2022 22:19:24 +0100 Subject: [PATCH 2/4] Improved translation response --- package.json | 2 +- src/api/tooot.ts | 4 +++- src/components/Timeline/Shared/Translate.tsx | 21 ++++++++++++++------ src/i18n/en/components/timeline.json | 4 +++- src/utils/queryHooks/translate.ts | 18 ++++++++++++----- 5 files changed, 35 insertions(+), 14 deletions(-) diff --git a/package.json b/package.json index 4684fad2..5c0627f1 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "native": "220206", "major": 3, "minor": 4, - "patch": 0, + "patch": 1, "expo": "44.0.0" }, "description": "tooot app for Mastodon", diff --git a/src/api/tooot.ts b/src/api/tooot.ts index 8017944a..a2d206b5 100644 --- a/src/api/tooot.ts +++ b/src/api/tooot.ts @@ -53,7 +53,9 @@ const apiTooot = async ({ Accept: '*/*', ...headers }, - ...(body && { data: body }) + ...(body && { data: body }), + validateStatus: status => + url.includes('translate') ? status < 500 : status === 200 }) .then(response => { return Promise.resolve({ diff --git a/src/components/Timeline/Shared/Translate.tsx b/src/components/Timeline/Shared/Translate.tsx index 0a4ce2ca..b078b1b8 100644 --- a/src/components/Timeline/Shared/Translate.tsx +++ b/src/components/Timeline/Shared/Translate.tsx @@ -32,6 +32,9 @@ const TimelineTranslate = React.memo( const settingsLanguage = useSelector(getSettingsLanguage) + if (Localization.locale.includes(tootLanguage)) { + return null + } if (settingsLanguage?.includes(tootLanguage)) { return null } @@ -88,13 +91,19 @@ const TimelineTranslate = React.memo( {isError ? t('shared.translate.failed') : isSuccess - ? t('shared.translate.succeed', { - provider: data?.provider, - source: data?.sourceLanguage - }) + ? typeof data?.error === 'string' + ? t(`shared.translate.${data.error}`) + : t('shared.translate.succeed', { + provider: data?.provider, + source: data?.sourceLanguage + }) : t('shared.translate.default')} + + {__DEV__ - ? ` Source: ${status.language}; Target: ${settingsLanguage}` + ? ` Source: ${status.language}; Target: ${ + Localization.locale || settingsLanguage || 'en' + }` : undefined} {isLoading ? ( @@ -105,7 +114,7 @@ const TimelineTranslate = React.memo( /> ) : null} - {data + {data && data.error === undefined ? data.text.map((d, i) => ( Date: Tue, 8 Feb 2022 22:26:55 +0100 Subject: [PATCH 3/4] New translations timeline.json (Chinese Simplified) --- src/i18n/zh-Hans/components/timeline.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/i18n/zh-Hans/components/timeline.json b/src/i18n/zh-Hans/components/timeline.json index 45772dfd..b5be0d81 100644 --- a/src/i18n/zh-Hans/components/timeline.json +++ b/src/i18n/zh-Hans/components/timeline.json @@ -81,7 +81,9 @@ "translate": { "default": "翻译", "succeed": "由{{provider}}翻译自{{source}}", - "failed": "翻译失败" + "failed": "翻译失败", + "source_not_supported": "不支持嘟文的语言", + "target_not_supported": "不支持目标翻译语言" }, "header": { "shared": { From 6e406db70362898f004457276856d9d7ad8c43fc Mon Sep 17 00:00:00 2001 From: Zhiyuan Zheng Date: Tue, 8 Feb 2022 22:49:59 +0100 Subject: [PATCH 4/4] Fix cannot switch language to English --- src/screens/Tabs/Me/Settings/App.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screens/Tabs/Me/Settings/App.tsx b/src/screens/Tabs/Me/Settings/App.tsx index a8852885..18dc2b61 100644 --- a/src/screens/Tabs/Me/Settings/App.tsx +++ b/src/screens/Tabs/Me/Settings/App.tsx @@ -64,7 +64,7 @@ const SettingsApp: React.FC = () => { cancelButtonIndex: options.length - 1 }, buttonIndex => { - if (!buttonIndex) return + if (buttonIndex === undefined) return if (buttonIndex < options.length - 1) { analytics('settings_language_press', { current: i18n.language,