ec01975549
audio_core: pass in memory reference
...
Because HLE::Source is initialized as an array in the member initializer, it is hard to let it accept the reference on ctor, so it has a second init stage performed by DspHle::Impl::Impl
2018-12-05 20:16:42 -05:00
008ef1fd71
DSP: Add a comment about physical address masking
...
See @wwylele's comment on PR 4483 for more details on what causes this behavior.
2018-12-03 12:22:11 -07:00
3aff585f32
DSP: Add address mask for physical pointers to audio data buffers
...
Hardware testing indicated that FFFFFFFC is the correct mask for all audio formats (mono and stereo PCM8, mono and stereo PCM16, and ADPCM). This fixes broken audio in Luigi's Mansion: Dark Moon and a few other games.
2018-12-03 01:07:55 -07:00
9458e4d8ec
CoreTiming: wrap into class
2018-11-04 10:26:38 -05:00
b4062abc11
cubeb_sink: ignore null-name device when selecting
...
We already ignore them on listing devices. We should do the same when selecting devices. This fix a crash when opening a specific device while there is a null device in the list
2018-10-26 09:17:44 -04:00
1d59c8f792
Logging: Change the TimeStretch::Process log from debug to trace level.
...
This function is called too many times and makes the debug logging basically unusable due to the spam.
2018-10-06 16:55:05 +02:00
7db46da4fc
Merge pull request #4247 from FearlessTobi/port-1314
...
Port yuzu-emu/yuzu#1314 : "audio_core/time_stretch: Silence truncation warnings in Process()"
2018-09-22 12:02:51 -04:00
bcb1aaf05c
cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
...
The parameter of the lambda was shadowing the variable that was being
assigned to.
2018-09-22 12:55:40 +02:00
553bdb2ae4
audio_core/time_stretch: Silence truncation warnings in Process()
...
The SoundTouch API only accepts uint amount of samples.
2018-09-22 12:52:13 +02:00
bb9e92c77c
Merge pull request #4194 from MerryMage/audiofifo
...
audio_core: Simplify sink interface
2018-09-21 13:30:51 +01:00
93bd630d40
audio_core/sink_details: Change std::string parameter into std::string_view
...
The given string is only ever used for lookup and comparison, so we can
just utilize a non-owning view to string data here
2018-09-15 15:48:24 +02:00
a6cf2e1f9d
cubeb_sink: Improve logging
2018-09-09 08:37:34 +01:00
675ffc1024
dsp_interface: Move volume control to audio thread
...
We also clamp the linear volume value to [0.0, 1.0].
Do nothing if linear volume is 1.0.
2018-09-08 22:24:51 +01:00
eed55a813e
time_stretch: Simplify audio stretcher
2018-09-08 22:09:26 +01:00
f34711219a
audio_core: Simplify sink interface
2018-09-08 22:09:26 +01:00
7d8f115185
Prefix all size_t with std::
...
done automatically by executing regex replace `([^:0-9a-zA-Z_])size_t([^0-9a-zA-Z_])` -> `$1std::size_t$2`
2018-09-06 16:03:28 -04:00
b130dd6842
Merge pull request #4161 from FearlessTobi/port-1139
...
Port #1139 from yuzu: "bit_field: Convert ToBool() into explicit operator bool"
2018-09-02 09:53:50 +01:00
488694d01f
Replace ToBool() with static_cast()
2018-09-01 15:50:57 +02:00
7daed185cb
cubeb_sink: Protect queue against multithreaded access
2018-08-31 18:44:19 +01:00
29e5dec986
sink_details: Deduplicate long std::function repetition
...
We can just use type aliases to avoid needing to write the same long
type twice
2018-08-23 17:03:09 +02:00
50b58da56c
sink_details: std::move std::function instances
...
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
2018-08-23 17:03:00 +02:00
c35a251d86
Merge pull request #3985 from BreadFish64/fix-warnings
...
core: clean up warnings
2018-08-02 11:14:57 -06:00
14b0435df2
Merge pull request #3994 from FearlessTobi/replace-clamp-functions
...
Remove MathUtil::Clamp and replace it with its std:: counterpart
2018-08-02 11:08:07 -06:00
74cd98ecad
core: clean up warnings
2018-08-01 14:10:23 -05:00
8f70e9a318
service/dsp: Addressed comments about function name and pointer type
2018-07-29 15:18:30 -04:00
71e1d6e25d
Fix compile errors
2018-07-26 13:23:25 +02:00
b840c63386
service/dsp: Clean up global state
2018-07-24 16:15:37 -04:00
7a3e126a4f
Replace MathUtil::Clamp with its std counterpart
2018-07-24 19:08:17 +02:00
2f8c9c8126
Merge pull request #3831 from FearlessTobi/add-volume-slider
...
citra_qt: Add a volume slider
2018-07-18 09:56:47 -06:00
47d283a1e4
Merge pull request #3909 from MerryMage/rm-SetDevice
...
sink_details: Tidy-up device listing code
2018-07-12 20:49:29 +01:00
7d642b25e9
sink: Make auto device name a constant
2018-07-12 15:56:37 +01:00
c39daa3c01
service/dsp: Migrate to ServiceFramework ( #3915 )
...
* service/dsp: Migrate to ServiceFramework
* service/dsp: Removed redundant buffer copy
* service/dsp: Addressed comment about pushing u32 instead of bool
* service/dsp: Fix clang format
* service/dsp: Addressed comment about minimizing global state
* service/dsp: Addressed comments and fixed log call issue
* service/dsp: Fix missed clang format
2018-07-12 17:54:26 +03:00
a780f3821e
citra_qt: Add a volume slider
2018-07-03 17:26:50 +02:00
d269beab0d
sink_details: Listing available devices should be separate from sink construction
2018-07-02 14:09:17 +01:00
ce5a5412ae
sink_details: Remove unnecessary lambdas
2018-07-02 13:26:14 +01:00
05fc17b88a
sink: Remove unnecessary SetDevice method
...
Unused, doesn't do anything.
2018-07-02 13:23:40 +01:00
0eab948728
reformat all files with clang-format
2018-06-29 16:56:12 +03:00
7c5a76e58b
log: replace all NGLOG with LOG
2018-06-29 14:18:07 +03:00
04139e26bd
cubeb_sink: Skip devices without a name
...
Previously this would crash.
2018-05-31 21:01:48 -05:00
ce6d9e2e28
externals: Don't build cubeb with tests
2018-05-31 21:01:48 -05:00
35c43aa293
audio_core: Only include cubeb if it's available
2018-05-31 21:01:48 -05:00
af73dd45f0
audio_core: Implement a cubeb audio sink
2018-05-31 21:01:48 -05:00
38e2b6c8d8
Undo changes to unrelated files and fix formatting
2018-03-25 00:54:40 +08:00
df816b5eaf
Address review comments
...
* Convert %x to {:x}
* Convert {0:#010x} to {:#010x}
* Remove `? true : false` statement
* Remove `.c_str()` for strings
2018-03-24 22:25:50 +08:00
693b190274
audio_core: Migrate logging macros
...
Follow-up of #3533
Replace prefix of all logging macros from LOG to NGLOG
2018-03-24 21:45:58 +08:00
f61141e86a
Update the entire application to use the new clang format style
2018-03-09 10:54:43 -07:00
90b835758f
decode: Fix PCM8 decoding
...
Signal range is -32767 to 32768, not -127 to 128.
2018-02-25 12:42:21 +00:00
adf9a19095
fixup! audio_core: Remove global state
2018-02-04 22:23:51 +00:00
ab3d53131a
audio_core: Remove global state
2018-02-03 15:15:17 +00:00
80ed0f03ac
cmake: add missing ${...} for variables inside generator expressions
2017-12-23 03:00:15 +02:00
