octo/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shader: Handle out-of-bounds uniform access via address register. (#16)

Browse Source
This commit is contained in:
Steveice10
2023-01-10 03:23:39 -08:00
committed by GitHub
parent 9c206db630
commit e2076f2385
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/video_core/renderer_opengl/gl_shader_decompiler.cpp
View File

@ -333,8 +333,9 @@ private:
return fmt::format("reg_tmp{}", index); return fmt::format("reg_tmp{}", index);
case RegisterType::FloatUniform: case RegisterType::FloatUniform:
if (address_register_index != 0) { if (address_register_index != 0) {
return fmt::format("uniforms.f[{} + address_registers.{}]", index, // TODO: Verify hardware behavior of out-of-bounds register number.
"xyz"[address_register_index - 1]); return fmt::format("({0} + address_registers.{1} < 96 ? uniforms.f[{0} + address_registers.{1}] : vec4(0))",
index, "xyz"[address_register_index - 1]);
} }
return fmt::format("uniforms.f[{}]", index); return fmt::format("uniforms.f[{}]", index);
default: default: