From b714114ab07ea422eecc3a7e8e5e1ba6a2409f01 Mon Sep 17 00:00:00 2001 From: Narr the Reg Date: Fri, 27 Jan 2023 22:31:41 -0600 Subject: [PATCH] yuzu: config: Avoid reading deleted object --- src/citra_qt/configuration/input_profiles.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/citra_qt/configuration/input_profiles.cpp b/src/citra_qt/configuration/input_profiles.cpp index e10537c9c..7adcfcf0f 100644 --- a/src/citra_qt/configuration/input_profiles.cpp +++ b/src/citra_qt/configuration/input_profiles.cpp @@ -57,13 +57,16 @@ std::vector InputProfiles::GetInputProfileNames() { std::vector profile_names; profile_names.reserve(map_profiles.size()); - for (const auto& [profile_name, config] : map_profiles) { + auto it = map_profiles.cbegin(); + while (it != map_profiles.cend()) { + const auto& [profile_name, config] = *it; if (!ProfileExistsInFilesystem(profile_name)) { - DeleteProfile(profile_name); + it = map_profiles.erase(it); continue; } profile_names.push_back(profile_name); + ++it; } std::stable_sort(profile_names.begin(), profile_names.end());