octo/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rasterizer_cache: More texture pack nonsense

Browse Source 
* Some packs turn out have mipmaps but not the base level of a texture. Handle this to avoid black textures at a distance
This commit is contained in:
GPUCode
2023-02-26 19:03:21 +02:00
parent f04a6a4d83
commit 74e75f1996
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/video_core/rasterizer_cache/rasterizer_cache.h
View File

@ -916,12 +916,20 @@ bool RasterizerCache<T>::UploadCustomSurface(const Surface& surface, const Surfa
const bool is_base_level = level == 0;
const Texture& texture = custom_tex_manager.GetTexture(load_info, upload_data);
// The old texture pack system did not support mipmaps so older packs might do
// wonky things. For example Henriko's pack has mipmaps larger than the base
// level. To avoid crashes just don't upload mipmaps for custom surfaces
if (custom_tex_manager.CompatibilityMode() && surface->IsCustom() && !is_base_level) {
if (custom_tex_manager.CompatibilityMode() && !is_base_level) {
// Pack provides mipmap but not the base level. Fallback to normal upload
if (!surface->IsCustom() && texture) {
return false;
}
// Pack provides base level but not any mipmaps.
// We can't fallback to normal upload so ignore it.
// The base level should already have generated mips for us.
if (surface->IsCustom() && !texture) {
return true;
}
}
if (!texture) {
return false;
}