ad92be5b9c
Refactor saving downloads to cache
...
Moved writing to happen immediately after the download to reduce duplicated code and number of return values from the download function.
2019-11-08 10:17:12 +01:00
4c156784c8
Refactor calculation of update delay when reading cache
...
Set the default delay once at the top instead of before every early return.
2019-11-08 10:17:12 +01:00
e818eeb800
Refactor reading a URL's content to own function
...
No longer shadows `url` package with variable of the same name.
2019-11-08 10:17:12 +01:00
d851c9eeb6
Refactor signature verification to own function
...
The cache is no longer destroyed whenever any signature verification fails.
The public key is stored on the Source struct for future use.
2019-11-08 10:17:12 +01:00
da0d7fe841
Fix various timing inconsistencies
...
When comparing times in tests, it's necessary to control the `now` value to ensure slow test runs don't fail incorrectly.
Both cache and download code had been using refreshDelay to set the next prefetch delay, which by default meant the 1st prefetch was 3 days after startup - this has now been corrected to match the 1 day expectation.
Enabling some of the cache tests revealed some other incorrect failures in the test that were also fixed.
2019-11-08 10:17:12 +01:00
03dea47130
Remove dead code paths
...
These paths were unreachable because XTransport.Get already checks the same conditions.
2019-11-08 10:17:12 +01:00
af0629856c
Add unit tests for sources.go
...
Tests cover most of the cache and download related code paths and specify the expected result of various starting states and external failure modes.
Where the current code's behaviour doesn't match a test's expectations, the test is disabled and annotated with a TODO until it can be fixed.
Added dependency on `github.com/powerman/check` and ran `go mod vendor`.
2019-11-08 10:17:12 +01:00
503bfb877b
go mod tidy
...
```console
$ go mod tidy -v
(snip)
unused github.com/agl/ed25519
```
Also add base .gitattributes file to normalize line endings in the repository across differing developer environments.
2019-11-08 10:17:12 +01:00
e6a4a4ffda
Update deps
2019-11-05 01:32:38 +01:00
b76db70a6c
Revert "cleanup: estimators: simplify blindAdjust"
...
This reverts commit c699e7bec4
2019-11-05 01:16:22 +01:00
17a675021e
No one ever completes // TODO things
2019-11-05 01:10:57 +01:00
da3f30871f
Revert "fix: proxy: Trigger query logging plugins using defer"
...
This reverts commit fc9509a8c8
2019-11-05 00:54:03 +01:00
14862c2fc7
defer is slow and not worth it here
2019-11-05 00:37:46 +01:00
316c5ca6b1
Don't return immediately on non-Windows system if netprobe_timout is -1
...
Fixes #1016
2019-11-04 17:14:31 +01:00
9852a289f8
Increase the default cache size and minimum TTL
2019-11-03 17:31:41 +01:00
e0c37f92fc
Add a comment about why DoH addresses from stamps don't expire
2019-11-03 00:33:17 +01:00
0f332c644d
Set a minimum TTL when caching resolver IPs
...
Comcast having a 30 sec TTL is silly
2019-11-02 02:01:03 +01:00
63ed3b4fef
Update comment
2019-11-02 01:52:51 +01:00
a84a789a8a
Keep resolving if needed
2019-11-02 01:50:35 +01:00
d932d5fdfc
Inverse test
2019-11-02 01:20:28 +01:00
6032c3b79b
Add a grace TTL for expired cached IPs
...
And some comments to make the code more readable
2019-11-01 23:19:07 +01:00
0dc69eacd5
resolveHostWithCache -> resolveWithCache
2019-11-01 23:10:36 +01:00
b30904f20b
lowercase
2019-11-01 23:06:42 +01:00
8d191cdcf1
Rename CheckResolver to IsIPAndPort for clarity
2019-11-01 23:05:17 +01:00
3cef651b07
Rename resolveHost() to resolveHostWithCache() for clarity
...
(but to be honest, I don't understand anything to that code any more)
2019-11-01 23:00:39 +01:00
e028f4d483
Don't delete cached server IP addresses
...
If we can't update an entry, keep the previous one.
2019-11-01 22:55:06 +01:00
3db3de0a91
Use SystemResolverTTL as a minimum timeout for cached resolver IPs
2019-11-01 21:47:13 +01:00
97e4c44223
remove err return values that are never set
2019-11-01 17:13:14 +01:00
36808cdec7
remove unused patternType return
2019-11-01 17:13:14 +01:00
a0d9412a25
run goimports
2019-11-01 17:13:14 +01:00
cd675913b2
Fix copy-paste oversight
...
I think these variables are always both nil or both not nil, but maybe in the future they might not be.
2019-11-01 09:07:57 +00:00
816acb9d8d
move ConfigLoad into AppMain
2019-10-31 18:55:44 +01:00
2f7e057996
move flags parsing into main()
2019-10-31 18:55:44 +01:00
116f985b96
Bump
2019-10-31 18:12:13 +01:00
c5bda9e2ae
Update deps
2019-10-31 18:00:44 +01:00
59c3d5121d
Add brackets around cached IPv6 IP addresses
...
Fixes #1005
2019-10-31 17:55:54 +01:00
1c9924e055
check error that was being erroneously shadowed
2019-10-31 17:55:26 +01:00
971b08bcec
No more beta
2019-10-31 17:54:04 +01:00
06b0976786
Remove the serverInfo rwlock; just use the global serversInfo rwlock
2019-10-31 17:50:56 +01:00
3a68f90c37
Back to 2.0.29 beta 3 ( ceed905196)
2019-10-31 17:50:19 +01:00
fb1fc14317
Revert "refactoring of pull 980"
...
This reverts commit 6fa420a8e0
2019-10-31 17:36:59 +01:00
7636a78d74
Revert "avoid LoadConfig twice"
...
This reverts commit 8f2c438c70
2019-10-31 17:36:32 +01:00
828af28658
Revert "move ConfigLoad and InitPluginsGlobals to appMain"
...
This reverts commit b67d19ffb3
2019-10-31 17:36:28 +01:00
393195066e
Up
2019-10-31 16:50:38 +01:00
ac0425835b
Update ChangeLog
2019-10-31 16:42:36 +01:00
71e3cf4aef
Add brackets around cached IPv6 IP addresses
...
Fixes #1005
2019-10-31 16:38:43 +01:00
b67d19ffb3
move ConfigLoad and InitPluginsGlobals to appMain
2019-10-31 15:04:12 +01:00
8f2c438c70
avoid LoadConfig twice
2019-10-31 15:04:12 +01:00
65de188423
don't use syscall directly
2019-10-31 15:04:12 +01:00
6fa420a8e0
refactoring of pull 980
...
follow up on https://github.com/DNSCrypt/dnscrypt-proxy/pull/980#issuecomment-548153169
2019-10-31 15:04:12 +01:00
William Elwood
Frank Denis
Alison Winters
Will Elwood
Eric Lagergren
Vladimir Bauer