From aceb8b30f71fd414c61e4301f784b38b369ab1a6 Mon Sep 17 00:00:00 2001 From: Frank Denis Date: Sat, 20 Jan 2018 20:37:02 +0100 Subject: [PATCH] AAAA filter: Reject instead of sending an empty response Empty responses can cause issues with CNAME records --- dnscrypt-proxy/plugin_block_ipv6.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dnscrypt-proxy/plugin_block_ipv6.go b/dnscrypt-proxy/plugin_block_ipv6.go index 79a8d431..eca40b77 100644 --- a/dnscrypt-proxy/plugin_block_ipv6.go +++ b/dnscrypt-proxy/plugin_block_ipv6.go @@ -33,11 +33,6 @@ func (plugin *PluginBlockIPv6) Eval(pluginsState *PluginsState, msg *dns.Msg) er if question.Qclass != dns.ClassINET || question.Qtype != dns.TypeAAAA { return nil } - synth, err := EmptyResponseFromMessage(msg) - if err != nil { - return err - } - pluginsState.synthResponse = synth - pluginsState.action = PluginsActionSynth + pluginsState.action = PluginsActionReject return nil }