From 0f462cd5118562e2991216ceb90ba9f57100de05 Mon Sep 17 00:00:00 2001
From: Maicol Battistini <maicolbattistini@live.it>
Date: Thu, 3 Feb 2022 00:15:31 +0100
Subject: [PATCH] fix: Fix snackbar quando il salvataggio fallisce

---
 .idea/inspectionProfiles/Project_Default.xml  |  1 +
 resources/js/Components/Pages/RecordsPage.tsx | 30 ++++++++++-------
 resources/js/typings/misc.ts                  | 32 +++++++++++++++++++
 3 files changed, 52 insertions(+), 11 deletions(-)

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index 0203198bc..5c24b70ab 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -2,6 +2,7 @@
   <profile version="1.0">
     <option name="myName" value="Project Default" />
     <inspection_tool class="ContractViolationInspection" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="ES6MissingAwait" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
     <inspection_tool class="ES6UnusedImports" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="EditorConfigPartialOverride" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
     <inspection_tool class="Eslint" enabled="true" level="WARNING" enabled_by_default="true" />
diff --git a/resources/js/Components/Pages/RecordsPage.tsx b/resources/js/Components/Pages/RecordsPage.tsx
index 2256c8edc..cf78bc7e6 100644
--- a/resources/js/Components/Pages/RecordsPage.tsx
+++ b/resources/js/Components/Pages/RecordsPage.tsx
@@ -31,11 +31,13 @@ import type {
   TextAreaT,
   TextFieldT
 } from '../../typings';
+import {JSONAPI} from '../../typings';
 import {
   getFormData,
   isFormValid,
   showSnackbar
 } from '../../utils';
+import type {Select} from '../../WebComponents';
 import DataTable from '../DataTable/DataTable';
 import TableCell from '../DataTable/TableCell';
 import TableColumn from '../DataTable/TableColumn';
@@ -43,7 +45,6 @@ import TableRow from '../DataTable/TableRow';
 import LoadingButton from '../LoadingButton';
 import Mdi from '../Mdi';
 import Page from '../Page';
-import {Select} from '../../WebComponents';
 
 export type ColumnT = {
   id?: string
@@ -388,14 +389,14 @@ export class RecordsPage extends Page {
         }
 
         this.rows.put(model.getId(), model);
-        loading.hide();
         m.redraw();
         await showSnackbar(__('Record salvato'), 4000);
       }
     } else {
-      loading.hide();
       await showSnackbar(__('Campi non validi. Controlla i dati inseriti'));
     }
+
+    loading.hide();
   }
 
   async setter(model: IModel, data: Collection<File | string>) {
@@ -410,16 +411,23 @@ export class RecordsPage extends Page {
 
     await this.saveFields(model, relations, data);
 
-    // Save relations
-    for (const [relation, relatedModel] of Object.entries(relations)) {
-      const response = await relatedModel.save();
-      if (response.getModelId()) {
-        model.setRelation(relation, response.getModel());
+    try {
+      // Save relations
+      for (const [relation, relatedModel] of Object.entries(relations)) {
+        const response = await relatedModel.save();
+        if (response.getModelId()) {
+          model.setRelation(relation, response.getModel());
+        }
       }
-    }
 
-    const response = await model.save();
-    return response.getModelId();
+      const response = await model.save();
+      return response.getModelId();
+    } catch (error) {
+      const {errors} = (error as JSONAPI.RequestError).response.data;
+      const errorMessage = errors.map((error_) => error_.detail)
+        .join(';\n');
+      void showSnackbar(__('Errore durante il salvataggio: :error', {error: errorMessage}), false);
+    }
   }
 
   // eslint-disable-next-line @typescript-eslint/require-await
diff --git a/resources/js/typings/misc.ts b/resources/js/typings/misc.ts
index 99ecc3f2b..13a682fd7 100644
--- a/resources/js/typings/misc.ts
+++ b/resources/js/typings/misc.ts
@@ -13,3 +13,35 @@ export type JSXElement<T> = Omit<Partial<T>, 'children' | 'style'>
   style?: string | CSSStyleDeclaration
 };
 
+export declare namespace JSONAPI {
+
+  export interface Trace {
+    file: string;
+    line: number;
+    function: string;
+    class: string;
+    type: string;
+  }
+
+  export interface Meta {
+    exception: string;
+    file: string;
+    line: number;
+    trace: Trace[];
+  }
+
+  export interface Error {
+    detail: string;
+    meta: Meta;
+    status: string;
+    title: string;
+  }
+
+  export interface RequestError {
+    response: {
+      data: {
+        errors: JSONAPI.Error[]
+      }
+    };
+  }
+}