Commit Graph

280 Commits

Author SHA1 Message Date
Kat Gerasimova b7e0d93ce1 Do not require kittykat's PR to include a sign-off 2022-10-26 10:17:26 +01:00
jonnyandrew 31811bb7e0
Fix crash by disabling Flipper on API 22 and below (#7428)
* Disable Flipper on API 21 and below - only affects debug builds.

Due to a bug: https://github.com/facebook/flipper/issues/3572

* Add jonnyandrew to PR sign-off allowlist

Co-authored-by: Benoit Marty <benoit.marty@gmail.com>
2022-10-21 17:36:31 +01:00
Benoit Marty 3864d937d9 Set warnWhenNotUsingParallelGC to false, because it fails the build. 2022-10-17 15:52:55 +02:00
Benoit Marty 5214751218 Let the doctor be less strict and just warn.
Keep the useful log "Is CI build: $isCiBuild".
2022-10-17 15:00:39 +02:00
Benoit Marty ea9874adca
Merge pull request #7355 from vector-im/feature/bma/check_script
Fix the check script, some folders have changed.
2022-10-13 13:53:08 +02:00
Benoit Marty 1a9b3941ae Fix the check script, some folders have changed. 2022-10-13 12:51:23 +02:00
Benoit Marty 652069d520 Manage new Android 13 notification permission. 2022-10-06 18:56:23 +02:00
Amit Kumar aad2eed396
Add initial Sentry setup for crashes and perf tracking (#7141)
* Add initial Sentry setup for crashes and perf tracking

* Fix failing analytics tests

* Reformat code to fix style issue

* Close sentry when user signs out

* Add initial unit tests for Sentry

* Remove unused import

* Exclude amitkma from signoff requirements for PRs
2022-10-05 16:49:14 +05:30
Benoit Marty 0c4510250b
Merge pull request #7241 from vector-im/feature/bma/gradle_doctor
Set up Gradle doctor
2022-09-27 18:48:05 +02:00
Benoit Marty 67d899dce4 Deactivate some gradle doctor checks on the CI. 2022-09-27 14:34:51 +02:00
Benoit Marty 974ac49594 Add default configuration of Gradle Doctor to the project.
Will allow to tweak the configuration if necessary.
2022-09-27 10:20:02 +02:00
Adam Brown 1fab6e69c5 adding origin of bash script url 2022-09-26 10:26:39 +01:00
Adam Brown 9ef4975025 adding github action to validate screenshot files are commited with git lfs 2022-09-26 10:26:38 +01:00
Benoit Marty 56189a2d5d
Merge pull request #7211 from vector-im/feature/bma/prevent_modification_of_translations
Prevent modification of translations
2022-09-23 10:46:38 +02:00
Benoit Marty cefe2e9ef4 Add a rule to Danger to check that translation files are not modified by developers. 2022-09-22 17:03:45 +02:00
Benoit Marty d8436874e2 Fix `StaticFieldLeak` issue (context).
Make VectorLocal an injectable class.
2022-09-22 16:32:14 +02:00
Benoit Marty 7e8a39e6de Suppress `LaunchActivityFromNotification`. This is fine here, this is the notification for the diagnostic, we do not want to start an Activity. 2022-09-22 16:32:14 +02:00
Benoit Marty 1ff4a5f212 Ignore `AlwaysShowAction` lint issue. Also make it an error, so that developer has to explicitly disable the warning. 2022-09-22 16:32:14 +02:00
Benoit Marty b9c28ba4ce
Merge branch 'develop' into feature/bma/android12 2022-09-21 16:24:30 +02:00
bmarty 925fffac45 Sync Emojis 2022-09-19 00:03:51 +00:00
Benoit Marty 842a9bbd55 Add dataExtractionRules, applicable to Android 12. Exclude everything from being backed up. Also properly support Android 11. 2022-09-16 23:01:29 +02:00
bmarty 0c4707c315 Sync Emojis 2022-09-12 00:06:34 +00:00
Adam Brown feb1a2a876 including vector-app in the code_quality script 2022-08-31 09:16:01 +01:00
Adam Brown 4d3e21d046 reusing lint file 2022-08-31 09:16:00 +01:00
Benoit Marty 5f0b26ae39 Remove FragmentModule 2022-08-23 18:47:23 +02:00
Benoit Marty 7883a6c617 Rename gl to gl-ES to be PlayStore compatible, and unignore this language. 2022-08-23 15:16:12 +02:00
Benoit Marty 8857decc87
Merge pull request #6701 from vector-im/sync-emojis
Sync Emojis
2022-08-17 16:32:55 +02:00
Benoit Marty 6ac88a9420 Add a check on suspicious string template.
Especially we want to ensure that the app does not log unexpected content.
2022-08-16 16:05:40 +02:00
Benoit Marty 1389262c3f Let danger check for frozen classes 2022-08-16 11:41:30 +02:00
Benoit Marty 08fff48065 Revert "Simple check to prevent frozen class modificaiton"
This reverts commit 28ca03cc67.
2022-08-16 11:14:01 +02:00
bmarty ecfa7db07d Sync Emojis 2022-08-15 00:03:34 +00:00
Adam Brown a2768ccab7 ignoring the gl locale from the play store upload step as it's unsupported 2022-08-09 16:22:21 +01:00
Michael Kaye 09a91c4541
Make it easier to find developer sign-off instructions (#6739)
* Make it easier to find sign-off instructions by linking directly to DCO docs from danger message.
2022-08-04 15:54:53 +01:00
Adam Brown 1497650146
Merge pull request #6715 from vector-im/feature/adm/danger-reviewers
Fix danger reviewers PR comment
2022-08-02 14:15:26 +01:00
Adam Brown 3fe7a9d8d5
Merge pull request #6588 from vector-im/dependabot/gradle/io.gitlab.arturbosch.detekt-1.21.0
Bump io.gitlab.arturbosch.detekt from 1.20.0 to 1.21.0
2022-08-02 12:56:45 +01:00
Adam Brown c99f67bea4 reading users field from the reviews object for calculating if reviewers have been set 2022-08-02 12:34:36 +01:00
Adam Brown ba5d6c9108 replacing all danger mutable lets with const 2022-08-02 12:19:16 +01:00
Adam Brown 7d120f94f6 reading the reviewers length from the github object as per the dsl 2022-08-02 12:17:48 +01:00
Benoit Marty 725ed00759 Change some severities 2022-07-29 15:41:36 +02:00
Benoit Marty d60695806f Do not require a changelog file for PR created by Dependabot. 2022-07-29 15:18:04 +02:00
Benoit Marty c41f0dd0cf Do not request PR created by Dependabot to include a Sign-off.
Dependabot includes a sign-off in its commits, but if the team adds extra commits, we will have the warning that a sign off is required.
2022-07-29 15:13:55 +02:00
Benoit Marty 56691f613e Setup Danger to Element Android project. 2022-07-29 10:02:40 +02:00
Benoit Marty a52a2504ef We do not use TravisCI anymore. 2022-07-29 10:02:40 +02:00
Benoit Marty 2d761385a1 Detekt: disable rule `UseCheckOrError` 2022-07-19 15:02:21 +02:00
Benoit Marty b4f833cb0d Detekt: disable rule `InstanceOfCheckForException` 2022-07-19 15:02:21 +02:00
Benoit Marty 7616912411
Merge pull request #6436 from vector-im/feature/bma/activity_fragment_1_5_0
Upgrade androidx activity and fragment to 1.5.0
2022-07-06 11:44:22 +02:00
Benoit Marty aae6e20f9c Migration to activity 1.5.0. Rework menu management 2022-07-01 17:06:02 +02:00
Valere 28ca03cc67 Simple check to prevent frozen class modificaiton 2022-07-01 11:54:30 +02:00
Benoit Marty ba8fcf9de3 Suppress issue on a tool. 2022-06-17 12:17:09 +02:00
Benoit Marty 5b185152c6 Remove non needed extra spaces: add a check 2022-05-20 09:48:05 +02:00