Commit Graph

353 Commits

Author SHA1 Message Date
Benoit Marty 6ac88a9420 Add a check on suspicious string template.
Especially we want to ensure that the app does not log unexpected content.
2022-08-16 16:05:40 +02:00
Benoit Marty 1389262c3f Let danger check for frozen classes 2022-08-16 11:41:30 +02:00
Benoit Marty 08fff48065 Revert "Simple check to prevent frozen class modificaiton"
This reverts commit 28ca03cc67.
2022-08-16 11:14:01 +02:00
bmarty ecfa7db07d Sync Emojis 2022-08-15 00:03:34 +00:00
Adam Brown a2768ccab7 ignoring the gl locale from the play store upload step as it's unsupported 2022-08-09 16:22:21 +01:00
Michael Kaye 09a91c4541
Make it easier to find developer sign-off instructions (#6739)
* Make it easier to find sign-off instructions by linking directly to DCO docs from danger message.
2022-08-04 15:54:53 +01:00
Adam Brown 1497650146
Merge pull request #6715 from vector-im/feature/adm/danger-reviewers
Fix danger reviewers PR comment
2022-08-02 14:15:26 +01:00
Adam Brown 3fe7a9d8d5
Merge pull request #6588 from vector-im/dependabot/gradle/io.gitlab.arturbosch.detekt-1.21.0
Bump io.gitlab.arturbosch.detekt from 1.20.0 to 1.21.0
2022-08-02 12:56:45 +01:00
Adam Brown c99f67bea4 reading users field from the reviews object for calculating if reviewers have been set 2022-08-02 12:34:36 +01:00
Adam Brown ba5d6c9108 replacing all danger mutable lets with const 2022-08-02 12:19:16 +01:00
Adam Brown 7d120f94f6 reading the reviewers length from the github object as per the dsl 2022-08-02 12:17:48 +01:00
Benoit Marty 725ed00759 Change some severities 2022-07-29 15:41:36 +02:00
Benoit Marty d60695806f Do not require a changelog file for PR created by Dependabot. 2022-07-29 15:18:04 +02:00
Benoit Marty c41f0dd0cf Do not request PR created by Dependabot to include a Sign-off.
Dependabot includes a sign-off in its commits, but if the team adds extra commits, we will have the warning that a sign off is required.
2022-07-29 15:13:55 +02:00
Benoit Marty 56691f613e Setup Danger to Element Android project. 2022-07-29 10:02:40 +02:00
Benoit Marty a52a2504ef We do not use TravisCI anymore. 2022-07-29 10:02:40 +02:00
Benoit Marty 2d761385a1 Detekt: disable rule `UseCheckOrError` 2022-07-19 15:02:21 +02:00
Benoit Marty b4f833cb0d Detekt: disable rule `InstanceOfCheckForException` 2022-07-19 15:02:21 +02:00
Benoit Marty 7616912411
Merge pull request #6436 from vector-im/feature/bma/activity_fragment_1_5_0
Upgrade androidx activity and fragment to 1.5.0
2022-07-06 11:44:22 +02:00
Benoit Marty aae6e20f9c Migration to activity 1.5.0. Rework menu management 2022-07-01 17:06:02 +02:00
Valere 28ca03cc67 Simple check to prevent frozen class modificaiton 2022-07-01 11:54:30 +02:00
Benoit Marty ba8fcf9de3 Suppress issue on a tool. 2022-06-17 12:17:09 +02:00
Benoit Marty 5b185152c6 Remove non needed extra spaces: add a check 2022-05-20 09:48:05 +02:00
Benoit Marty e00a9278d5 Detekt: Enable OutdatedDocumentation 2022-05-20 09:47:54 +02:00
Benoit Marty 12644e9915
Merge pull request #5947 from vector-im/feature/bma/renaming
Small changes
2022-05-18 16:27:48 +02:00
Benoit Marty 4c95aafe10 Detekt: enable and fix EndOfSentenceFormat 2022-05-16 08:54:07 +02:00
Benoit Marty cf3e34e548 Detekt: add rules about comment 2022-05-13 09:51:14 +02:00
Benoit Marty b70bc20b99 This is now detected by detekt 2022-05-12 22:53:07 +02:00
Benoit Marty 03ec9946ff Detekt: fix ConstructorParameterNaming
UserProperties fix is also in https://github.com/matrix-org/matrix-analytics-events/pull/62
2022-05-12 22:17:56 +02:00
Benoit Marty 6f3b9c78b0 Detekt: fix FunctionParameterNaming 2022-05-12 17:56:05 +02:00
Benoit Marty c303b9afd3 Ignore more rules 2022-05-12 17:54:30 +02:00
Benoit Marty c5f9546605 Ignore more rules 2022-05-12 17:23:41 +02:00
Benoit Marty 824f029e20 "TODO:" is forbidden by Detekt 2022-05-12 17:06:52 +02:00
Benoit Marty 7d6c27eed5 Ignore rule 2022-05-12 17:05:19 +02:00
Benoit Marty 9834371e18 Detekt: configure and ignore some rules. 2022-05-12 16:56:49 +02:00
Benoit Marty c02fb87bc9 Set up detekt gradle plugin 2022-05-12 16:41:36 +02:00
Benoit Marty 8e319067ad Add diag request for Synapse 2022-05-05 15:34:23 +02:00
Benoit Marty 133d1972a3 Check more modules 2022-05-05 15:03:59 +02:00
Benoit Marty 32bc93c87d Ensure the `Clock` interface is used. 2022-05-03 15:02:34 +02:00
Benoit Marty c8aefd5828 Update issue hint 2022-04-13 13:42:15 +02:00
Benoit Marty f4fba2dd2d Check usage of `import org.matrix.android.sdk.internal` app side 2022-04-12 15:38:20 +02:00
Benoit Marty 1a53d2c8da python3 2022-04-07 09:30:52 +02:00
Benoit Marty 4d19d0370d `matrix-sdk-android-rx` module has been replaced by `matrix-sdk-android-flow` 2022-04-06 14:34:23 +02:00
Benoit Marty 963b2dfa57 Ignore false positive on static analysis tools
Until 2023-01-01Z !
2022-03-29 19:38:10 +02:00
Benoit Marty 587948c1b9 Bump Jitsi lib from 5.0.1 to 5.0.2
https://github.com/jitsi/jitsi-meet-release-notes/blob/master/CHANGELOG-MOBILE-SDKS.md#502-2022-03-29
2022-03-29 18:24:44 +02:00
Benoit Marty 0d2d1339e0 Bump Jitsi lib from 3.10.0 to 5.0.1 2022-03-29 16:29:35 +02:00
Benoit Marty 2055e7a27d Add link to the changelog 2022-03-29 15:48:53 +02:00
Benoit Marty 03fee2a131 The `.exhaustive` trick is not needed anymore in Kotlin 1.6.0
https://kotlinlang.org/docs/whatsnew16.html#stable-exhaustive-when-statements-for-enum-sealed-and-boolean-subjects
2022-03-22 16:14:15 +01:00
Michael Kaye 4a8aeadbcf
Merge pull request #5471 from vector-im/michaelk/ci_script_improvements
CI Script improvements
2022-03-21 15:06:11 +00:00
bmarty ffb007e96d Sync Emojis 2022-03-21 00:03:12 +00:00
Michael Kaye 314f32ed45 If a FileNotFound exception occurs, log a simple message indicating the tests may
have not run.
2022-03-10 10:24:41 +00:00
Michael Kaye 2d5b25cfad Remove the printing of file name to the log as it's doubling up information. 2022-03-03 20:39:41 +00:00
Michael Kaye 7837d1d6d6 Wrap up the argument list; it can be long 2022-03-02 10:05:07 +00:00
Michael Kaye 0ce59989a5 Log xml files we render.
We seem to be missing some tests here (?)
2022-02-25 11:07:03 +00:00
Michael Kaye 9ddcaffebf Adjust script to handle XML files 2022-02-24 16:36:43 +00:00
Michael Kaye 70c9418a5e Fix typo in script 2022-02-24 14:48:03 +00:00
Michael Kaye 4d86f5f2fd Correct name of script 2022-02-24 14:48:02 +00:00
Michael Kaye fbf29f6f1e Quick hack python to render the xml test output including times in a easy to read format. 2022-02-24 14:47:23 +00:00
Michael Kaye 779b5db363 Add a python script to cleanly display outputs in the github logs 2022-02-24 14:46:31 +00:00
Ahmed Radhouane Belkilani 91ab4726ad #3296
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
2022-02-23 11:34:43 +01:00
bmarty ff1c307ca0 Sync Emojis 2022-02-14 00:03:37 +00:00
ariskotsomitopoulos b2a2fe2710 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/relation/RelationService.kt
#	tools/check/forbidden_strings_in_code.txt
#	vector/build.gradle
#	vector/src/main/java/im/vector/app/core/di/FragmentModule.kt
#	vector/src/main/java/im/vector/app/core/resources/UserPreferencesProvider.kt
#	vector/src/main/java/im/vector/app/features/command/Command.kt
#	vector/src/main/java/im/vector/app/features/command/CommandParser.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewState.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/search/SearchResultItem.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/TimelineEventController.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/factory/MessageItemFactory.kt
#	vector/src/main/java/im/vector/app/features/navigation/Navigator.kt
#	vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt
#	vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt
#	vector/src/main/res/layout/fragment_timeline.xml
#	vector/src/main/res/xml/vector_settings_labs.xml
2022-01-27 17:11:26 +02:00
Benoit Marty 76599af088 Add default description for nl-NL 2022-01-25 19:05:20 +01:00
Benoit Marty 17de88e5f6 Remove the check on number of enum class.
Now that we have more developers, we can have conflict because ot the number of exception. Let's hope we will not do the mistake...
2022-01-24 18:12:41 +01:00
Benoit Marty 58197b8853 Fix enum class warning 2022-01-20 15:37:57 +01:00
ariskotsomitopoulos 3bd21d04d8 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TokenChunkEventPersistor.kt
#	tools/check/forbidden_strings_in_code.txt
2022-01-11 14:09:49 +02:00
Valere 3f0122be01 Update nb of enum classes 2022-01-10 09:44:11 +01:00
ariskotsomitopoulos ac5caccdf9 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CommonTestHelper.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/model/EventEntity.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/DefaultTimeline.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TokenChunkEventPersistor.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
#	tools/check/forbidden_strings_in_code.txt
#	vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
#	vector/src/main/res/menu/menu_timeline.xml
2022-01-07 13:29:43 +02:00
Adam Brown 12abd3b019 updating enum class counter 2022-01-06 10:25:41 +00:00
Benoit Marty 48e15b1c36 Restore line deleted during GitHub conflict fixing by mistake 2022-01-04 16:15:25 +01:00
Benoit Marty 7bbea52e66
Merge branch 'develop' into feature/bma/math_final 2022-01-04 16:13:23 +01:00
Benoit Marty 2dc88d1477 Fix code quality 2022-01-03 20:22:57 +01:00
Benoit Marty b39caeb04d 2 new enums 2022-01-03 15:27:59 +01:00
ariskotsomitopoulos 0d9bc188d7 Fix code quality issues 2021-12-26 00:48:11 +02:00
Benoit Marty 4949a06343 Use stable build tools for the release. 2021-12-14 16:37:52 +01:00
Benoit Marty be33a53e56 code quality 2021-12-14 09:06:43 +01:00
Benoit Marty a40e60ba8f Merge branch 'develop' into feature/bma/posthog 2021-12-13 23:18:14 +01:00
Benoit Marty d3a1746475 Use id from existing views instead of "hard-coded" values
And improve our extension
2021-12-07 16:56:27 +01:00
Benoit Marty 673cbb29de Merge branch 'develop' into feature/bma/posthog 2021-12-07 14:26:31 +01:00
Benoit Marty 88605b65b7
Merge pull request #4628 from vector-im/feature/bma/compressVideo
Add script to compress video and convert to gif file
2021-12-03 18:13:20 +01:00
Benoit Marty b2dce51fc2 Add script to compress video and convert to gif file 2021-12-03 17:30:30 +01:00
Adam Brown 6a3d4044ef removing unused imports and increasing enum allowance 2021-12-03 15:30:55 +00:00
Benoit Marty 055c9be9ce Add a script to import the plan to Element-Android project 2021-12-02 14:10:03 +01:00
Benoit Marty 6cb8a2458f Remove extra new lines in XML 2021-12-01 23:06:49 +01:00
Benoit Marty 6624039413 Use `@id` and not `@+id` when referencing ids in layouts - RelativeLayout and toolbarId 2021-12-01 22:44:07 +01:00
Benoit Marty e106ff8de0 Use `@id` and not `@+id` when referencing ids in layouts - ConstraintLayout 2021-12-01 22:19:33 +01:00
Benoit Marty 2d17156861 Use `@id` and not `@+id` when referencing ids in layouts - accessibilityTraversal 2021-12-01 22:16:28 +01:00
Benoit Marty 6d3df0d802 Use `@id` and not `@+id` when referencing ids in layouts - ConstraintLayout 2021-12-01 22:13:21 +01:00
Benoit Marty e233915c0f Jitsi android-sdk-3.1.0 -> android-sdk-3.10.0 2021-11-18 15:58:40 +01:00
Benoit Marty 855b672f48
Add content scanner service (#4392)
* Add content scanner APIs

* Move to content scanner matrix SDK to FOSS

* Update file service

* Refactoring

* Replace matrix callbacks by coroutines

* Fix lint errors

* Add changelog

Co-authored-by: yostyle <yoanp@element.io>
2021-11-17 11:18:20 +01:00
Benoit Marty be3aafeef2
Merge pull request #4433 from vector-im/feature/bma/android12
Android12
2021-11-16 13:27:33 +01:00
Benoit Marty aa3f36b7b7 Target API 31 - Android 12 - #4262 2021-11-15 12:24:48 +01:00
bmarty a33bcbb81a Sync Emojis 2021-11-15 00:01:55 +00:00
yostyle 6ddf3f6e5a Fix lint errors 2021-11-10 22:31:23 +01:00
Benoit Marty 8f854d725d ./fastlane/metadata/android/vi/full_description.txt now exists 2021-11-04 13:01:40 +01:00
Adam Brown d3234b33d3 increase enum class allowance by 1 2021-10-26 20:03:10 +01:00
Benoit Marty efc1e9b87c
Merge pull request #4217 from vector-im/sync-emojis
Sync Emojis
2021-10-12 14:54:36 +02:00
ariskotsomitopoulos ccc4a43737 Sync Emojis 2021-10-11 14:13:18 +00:00
ganfra 3bdf264a53 Merge develop into feature/fga/mavericks_2 2021-10-08 10:49:43 +02:00
ganfra 606cddc826 Mavericks 2: replace MvRxViewModelFactory by MavericksViewModelFactory 2021-10-01 17:11:53 +02:00
Benoit Marty 920f467231 Disqble some check, not true anymore 2021-10-01 14:11:26 +02:00
ganfra f6b81b36d0 Mavericks 2: switch from MvRxState to MavericksState 2021-10-01 10:08:06 +02:00
Benoit Marty b5614a1cd5 SQ descriptions are now available 2021-09-29 14:18:52 +02:00
Adam Brown 712b8ede14 adding benchmarking script to start monitoring build times
- makes use of the gradle-profiler to run the build multiple times
- currently uses reduced warm up/iteration count as the build takes a long time, can be increased once the build time is reduced
2021-09-23 16:20:41 +01:00
Valere 8fd784e275 Improve leave space (all + none) 2021-09-16 09:20:25 +02:00
Benoit Marty 2239d710db Handle missing descriptions for SQ 2021-09-08 17:30:02 +02:00
Valere aaa9c7e795 fix rebase 2021-07-30 19:05:47 +02:00
Valere 5adceaca23 Code quality 2021-07-30 18:44:14 +02:00
Onuray Sahin 1aa706dee5 Lint fixes. 2021-07-30 15:25:02 +03:00
Valere 57c75f8039 Ugrade unstable room notice in settings
default update parent, clean migrate bottomsheet layout
2021-06-24 09:38:52 +02:00
Benoit Marty d6363a6e1b Update template and use a more power full configuration 2021-06-18 21:35:09 +02:00
Benoit Marty eea18fb71c Rename towncrier folder from newsfragment to changelog.d 2021-06-18 21:33:50 +02:00
Benoit Marty 1538a62e37
Merge pull request #3523 from vector-im/feature/bma/preparing_release
Preparing release 1.1.10
2021-06-18 10:26:44 +02:00
Benoit Marty dd1f65dd6f Run ./tools/import_emojis.py
Only a small issue is fixed
2021-06-18 10:25:37 +02:00
Benoit Marty 930675d4c9 Add a formatted version of emoji_picker_datasource.json. Not included in the APK. 2021-06-18 10:25:37 +02:00
Benoit Marty 618333c022 Add the link to list of available language on the PlayStore 2021-06-18 09:33:23 +02:00
Benoit Marty ad0b1f02f6 Add the script to upload metadata to GooglePlay
fix script
2021-06-17 18:30:24 +02:00
Benoit Marty ece9d19d8c Rename again the style to follow Android convention (G's review) 2021-06-16 11:59:08 +02:00
Benoit Marty 858bbfd8d2 Rename style to follow naming conventions
And move some files to the module
2021-06-15 21:37:27 +02:00
Benoit Marty a67f8ca4dc Add some missing style. Default is not workong (?) 2021-06-15 19:00:07 +02:00
Benoit Marty f0b28742ac textSize *sp -> style 2021-06-15 10:30:54 +02:00
Benoit Marty 03df4aac77 Cleanup 2021-06-14 21:46:05 +02:00
Benoit Marty 3473d669d3 Use MaterialToolbar and AppBarLayout in all screens 2021-06-11 10:12:31 +02:00
Benoit Marty 047c59eba0 Rework colors management 2021-06-09 15:36:20 +02:00
Benoit Marty a9c61dc309 Fix code quality 2021-05-21 15:02:14 +02:00
Benoit Marty 2462c871b2 Update the CI tool. 2021-05-20 17:14:35 +02:00
Benoit Marty 9df11d6873 Configure towncrier tool 2021-05-20 16:41:29 +02:00
Benoit Marty 278b0d7f75 Sign APK with build tools 30.0.3 2021-05-12 16:20:55 +02:00
Valere eb18b23528 Add option to send beta feedback 2021-05-12 10:47:52 +02:00
Valere 8146d8ab1e Add Rooms to space 2021-04-28 11:15:58 +02:00
Valere 49381db2e3 cleaning 2021-04-28 11:15:58 +02:00
Valere 48fef45ce3 Code quality 2021-04-28 11:15:58 +02:00
oogm a4a3777722 Update import_emojis.py to retain keyword order 2021-04-08 22:14:41 +02:00
Benoit Marty b423d5da4c typo 2021-04-07 19:00:02 +02:00
Valere 41176c3e26 Support only notif display mode
+ code quality fixes
2021-03-31 18:04:27 +02:00
oogm a40adb903a Update emoji import script to ease execution, output smaller .json files and capitalize emoji names 2021-03-26 17:21:02 +01:00
oogm 7453509df4 Merge remote-tracking branch 'upstream/develop' into develop 2021-03-26 14:09:21 +01:00
Benoit Marty 274aef8f24 Code qual 2021-03-22 19:15:06 +01:00
oogm 0fc102461c Update import_emojis.py to pull keywords from emojilib, update quick reactions 2021-03-19 22:24:43 +01:00
oogm 51650fd899 Add script to pull emojis from Unicode.org as a file 2021-03-16 16:26:20 +01:00
Benoit Marty c9c4a203d1 Code quality 2021-03-10 11:10:23 +01:00
Benoit Marty e401252c03
Merge pull request #2956 from vector-im/feature/bma/scripts
Add a script to download and install APK from Buildkite
2021-03-04 14:01:30 +01:00
Benoit Marty 0b5135b841 Add a script to download and install APK from Buildkite 2021-03-03 20:37:19 +01:00
Benoit Marty 7eec98ea23 Ensure we will not use the template string by mistake 2021-03-03 18:08:05 +01:00
Benoit Marty b8498aecd9 Code quality 2021-03-03 15:17:41 +01:00
Benoit Marty 259ead106f Fix code quality issue 2021-03-03 09:28:35 +01:00
Benoit Marty c181f7e421 Please code quality check 2021-02-23 10:31:58 +01:00
Benoit Marty 14fc31be07 Add homeserver version check 2021-02-19 21:27:25 +01:00
Benoit Marty a4b5f79e8f Add capability to download only one artifact 2021-02-17 18:59:40 +01:00
Benoit Marty 1ec4424c0a Upgrade Jitsi library from 2.9.3 to 3.1.0 2021-02-10 12:15:32 +01:00