From f843dddc3a3ca040003b9ef34dec446225179dec Mon Sep 17 00:00:00 2001 From: Valere Date: Mon, 15 Nov 2021 16:48:12 +0100 Subject: [PATCH] Cleaning --- .../android/sdk/internal/crypto/DefaultCryptoService.kt | 4 ++-- .../matrix/android/sdk/internal/crypto/OneTimeKeysUploader.kt | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt index fd9a549e2e..19ba5c21dc 100755 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt @@ -434,9 +434,9 @@ internal class DefaultCryptoService @Inject constructor( deviceListManager.refreshOutdatedDeviceLists() // The presence of device_unused_fallback_key_types indicates that the server supports fallback keys. // If there's no unused signed_curve25519 fallback key we need a new one. - if (syncResponse.deviceUnusedFallbackKeyTypes != null + if (syncResponse.deviceUnusedFallbackKeyTypes != null && // Generate a fallback key only if the server does not already have an unused fallback key. - && !syncResponse.deviceUnusedFallbackKeyTypes.contains(KEY_SIGNED_CURVE_25519_TYPE)) { + !syncResponse.deviceUnusedFallbackKeyTypes.contains(KEY_SIGNED_CURVE_25519_TYPE)) { oneTimeKeysUploader.setNeedsNewFallback() } diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/OneTimeKeysUploader.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/OneTimeKeysUploader.kt index 93624c402d..7759e04c7c 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/OneTimeKeysUploader.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/OneTimeKeysUploader.kt @@ -147,7 +147,6 @@ internal class OneTimeKeysUploader @Inject constructor( olmDevice.markKeysAsPublished() needNewFallbackKey = false - if (response.hasOneTimeKeyCountsForAlgorithm(MXKey.KEY_SIGNED_CURVE_25519_TYPE)) { // Maybe upload other keys return keysThisLoop + uploadOTK(response.oneTimeKeyCountsForAlgorithm(MXKey.KEY_SIGNED_CURVE_25519_TYPE), keyLimit) @@ -177,7 +176,6 @@ internal class OneTimeKeysUploader @Inject constructor( oneTimeJson["signed_curve25519:$key_id"] = k } - val fallbackJson = mutableMapOf() if (needNewFallbackKey) { val fallbackCurve25519Map = olmDevice.getFallbackKey()?.get(OlmAccount.JSON_KEY_ONE_TIME_KEY).orEmpty()