Add changelog, address review comments.
This commit is contained in:
parent
e1cad01d54
commit
e6a2d50b92
1
changelog.d/7285.misc
Normal file
1
changelog.d/7285.misc
Normal file
@ -0,0 +1 @@
|
||||
Refactor TimelineFragment, split it into MessageComposerFragment and VoiceRecorderFragment.
|
@ -41,7 +41,7 @@ import androidx.core.view.isInvisible
|
||||
import androidx.core.view.isVisible
|
||||
import androidx.lifecycle.Lifecycle
|
||||
import androidx.lifecycle.lifecycleScope
|
||||
import com.airbnb.mvrx.existingViewModel
|
||||
import com.airbnb.mvrx.activityViewModel
|
||||
import com.airbnb.mvrx.withState
|
||||
import com.google.android.material.dialog.MaterialAlertDialogBuilder
|
||||
import com.vanniktech.emoji.EmojiPopup
|
||||
@ -156,8 +156,8 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
|
||||
private lateinit var attachmentsHelper: AttachmentsHelper
|
||||
private lateinit var attachmentTypeSelector: AttachmentTypeSelectorView
|
||||
|
||||
private val timelineViewModel: TimelineViewModel by existingViewModel()
|
||||
private val messageComposerViewModel: MessageComposerViewModel by existingViewModel()
|
||||
private val timelineViewModel: TimelineViewModel by activityViewModel()
|
||||
private val messageComposerViewModel: MessageComposerViewModel by activityViewModel()
|
||||
private lateinit var sharedActionViewModel: MessageSharedActionViewModel
|
||||
|
||||
override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentComposerBinding {
|
||||
|
@ -21,7 +21,7 @@ import android.view.LayoutInflater
|
||||
import android.view.View
|
||||
import android.view.ViewGroup
|
||||
import androidx.core.view.isVisible
|
||||
import com.airbnb.mvrx.existingViewModel
|
||||
import com.airbnb.mvrx.activityViewModel
|
||||
import com.airbnb.mvrx.withState
|
||||
import dagger.hilt.android.AndroidEntryPoint
|
||||
import im.vector.app.R
|
||||
@ -46,8 +46,8 @@ class VoiceRecorderFragment : VectorBaseFragment<FragmentVoiceRecorderBinding>()
|
||||
@Inject lateinit var audioMessagePlaybackTracker: AudioMessagePlaybackTracker
|
||||
@Inject lateinit var clock: Clock
|
||||
|
||||
private val timelineViewModel: TimelineViewModel by existingViewModel()
|
||||
private val messageComposerViewModel: MessageComposerViewModel by existingViewModel()
|
||||
private val timelineViewModel: TimelineViewModel by activityViewModel()
|
||||
private val messageComposerViewModel: MessageComposerViewModel by activityViewModel()
|
||||
|
||||
private val permissionVoiceMessageLauncher = registerForPermissionsResult { allGranted, deniedPermanently ->
|
||||
if (allGranted) {
|
||||
|
Loading…
x
Reference in New Issue
Block a user