filippodb/SchildiChat-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

No ned to add/remove chips locally in KeywordPreference.

Browse Source
This commit is contained in:
David Langley 2021-08-27 11:52:00 +01:00
parent 1127a05a3e
commit dbc76c7aee
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vector/src/main/java/im/vector/app/core/preference/KeywordPreference.kt
View File

@ -94,7 +94,6 @@ class KeywordPreference : VectorPreference {
if (keyword.isEmpty()) { if (keyword.isEmpty()) {
return false return false
} }
_keywords.add(keyword)
listener?.didAddKeyword(keyword) listener?.didAddKeyword(keyword)
onPreferenceChangeListener?.onPreferenceChange(this, _keywords) onPreferenceChangeListener?.onPreferenceChange(this, _keywords)
notifyChanged() notifyChanged()
@ -123,7 +122,6 @@ class KeywordPreference : VectorPreference {
if (!keywordsEnabled) { if (!keywordsEnabled) {
return@setOnCloseIconClickListener return@setOnCloseIconClickListener
} }
_keywords.remove(keyword)
listener?.didRemoveKeyword(keyword) listener?.didRemoveKeyword(keyword)
onPreferenceChangeListener?.onPreferenceChange(this, _keywords) onPreferenceChangeListener?.onPreferenceChange(this, _keywords)
notifyChanged() notifyChanged()

4
vector/src/main/java/im/vector/app/features/settings/notifications/VectorSettingsKeywordAndMentionsNotificationPreferenceFragment.kt
View File

@ -148,7 +148,7 @@ class VectorSettingsKeywordAndMentionsNotificationPreferenceFragment
hideLoadingView() hideLoadingView()
// Already added to UI, no-op on success // Already added to UI, no-op on success
result.onFailure { result.onFailure {
// Just display an error on failure, keywords will update when push rules refreshed // Just display an error on failure, keywords have not been added to the UI
activity?.toast(errorFormatter.toHumanReadable(it)) activity?.toast(errorFormatter.toHumanReadable(it))
} }
} }
@ -166,7 +166,7 @@ class VectorSettingsKeywordAndMentionsNotificationPreferenceFragment
hideLoadingView() hideLoadingView()
// Already added to UI, no-op on success // Already added to UI, no-op on success
result.onFailure { result.onFailure {
// Just display an error on failure, keywords will update when push rules refreshed // Just display an error on failure, keywords have not been added to the UI
activity?.toast(errorFormatter.toHumanReadable(it)) activity?.toast(errorFormatter.toHumanReadable(it))
} }
} }