a11y fixes

This commit is contained in:
Valere 2021-02-23 11:52:29 +01:00
parent 883f70306f
commit d8a3229819
3 changed files with 25 additions and 20 deletions

View File

@ -16,25 +16,25 @@
style="@style/VectorToolbarStyle" style="@style/VectorToolbarStyle"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="?actionBarSize" android:layout_height="?actionBarSize"
app:navigationIcon="@drawable/ic_x_18dp" android:elevation="4dp"
android:elevation="4dp"> app:navigationIcon="@drawable/ic_x_18dp">
<androidx.constraintlayout.widget.ConstraintLayout <androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent"> android:layout_height="match_parent">
<!-- <ImageView--> <!-- <ImageView-->
<!-- android:id="@+id/spacePreviewClose"--> <!-- android:id="@+id/spacePreviewClose"-->
<!-- android:layout_width="@dimen/layout_touch_size"--> <!-- android:layout_width="@dimen/layout_touch_size"-->
<!-- android:layout_height="@dimen/layout_touch_size"--> <!-- android:layout_height="@dimen/layout_touch_size"-->
<!-- android:clickable="true"--> <!-- android:clickable="true"-->
<!-- android:focusable="true"--> <!-- android:focusable="true"-->
<!-- android:foreground="?attr/selectableItemBackground"--> <!-- android:foreground="?attr/selectableItemBackground"-->
<!-- android:scaleType="center"--> <!-- android:scaleType="center"-->
<!-- android:src="@drawable/ic_x_18dp"--> <!-- android:src="@drawable/ic_x_18dp"-->
<!-- app:layout_constraintBottom_toBottomOf="parent"--> <!-- app:layout_constraintBottom_toBottomOf="parent"-->
<!-- app:layout_constraintStart_toStartOf="parent"--> <!-- app:layout_constraintStart_toStartOf="parent"-->
<!-- app:layout_constraintTop_toTopOf="parent" />--> <!-- app:layout_constraintTop_toTopOf="parent" />-->
<ImageView <ImageView
android:id="@+id/spacePreviewToolbarAvatar" android:id="@+id/spacePreviewToolbarAvatar"
@ -42,6 +42,7 @@
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginTop="8dp" android:layout_marginTop="8dp"
android:layout_marginBottom="8dp" android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"
@ -96,16 +97,16 @@
<View <View
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="1dp" android:layout_height="1dp"
android:background="?list_divider_color"/> android:background="?list_divider_color" />
<LinearLayout <LinearLayout
android:id="@+id/spacePreviewButtonBar" android:id="@+id/spacePreviewButtonBar"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:gravity="center_horizontal" android:layout_margin="8dp"
android:elevation="2dp" android:elevation="2dp"
android:orientation="horizontal" android:gravity="center_horizontal"
android:layout_margin="8dp"> android:orientation="horizontal">
<com.google.android.material.button.MaterialButton <com.google.android.material.button.MaterialButton
android:id="@+id/spacePreviewDeclineInviteButton" android:id="@+id/spacePreviewDeclineInviteButton"

View File

@ -16,6 +16,7 @@
android:layout_height="42dp" android:layout_height="42dp"
android:layout_gravity="center" android:layout_gravity="center"
android:layout_marginStart="@dimen/layout_horizontal_margin" android:layout_marginStart="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:duplicateParentState="true" android:duplicateParentState="true"
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator" app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
@ -44,6 +45,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginEnd="21dp" android:layout_marginEnd="21dp"
android:importantForAccessibility="no"
android:src="@drawable/ic_arrow_right" android:src="@drawable/ic_arrow_right"
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator" app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"

View File

@ -10,8 +10,8 @@
<im.vector.app.features.spaces.preview.SpaceTabView <im.vector.app.features.spaces.preview.SpaceTabView
android:id="@+id/spaceChildTabView" android:id="@+id/spaceChildTabView"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_marginStart="8dp" android:layout_height="match_parent"
android:layout_height="match_parent" /> android:layout_marginStart="8dp" />
<androidx.constraintlayout.widget.ConstraintLayout <androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent" android:layout_width="match_parent"
@ -31,6 +31,7 @@
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginStart="8dp" android:layout_marginStart="8dp"
android:layout_marginTop="12dp" android:layout_marginTop="12dp"
android:contentDescription="@string/avatar"
android:scaleType="centerInside" android:scaleType="centerInside"
android:visibility="visible" android:visibility="visible"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
@ -77,6 +78,7 @@
android:layout_width="18dp" android:layout_width="18dp"
android:layout_height="18dp" android:layout_height="18dp"
android:layout_marginEnd="4dp" android:layout_marginEnd="4dp"
android:importantForAccessibility="no"
android:src="@drawable/ic_room_profile_member_list" android:src="@drawable/ic_room_profile_member_list"
app:layout_constraintBottom_toBottomOf="@+id/spaceChildMemberCountText" app:layout_constraintBottom_toBottomOf="@+id/spaceChildMemberCountText"
app:layout_constraintEnd_toStartOf="@+id/spaceChildMemberCountText" app:layout_constraintEnd_toStartOf="@+id/spaceChildMemberCountText"