filippodb
/
SchildiChat-android
mirror of https://github.com/SchildiChat/SchildiChat-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enhance crypto posthog errors with more details

This commit is contained in:
ariskotsomitopoulos 2022-04-20 16:40:12 +03:00
parent e0556cd5e6
commit d240e3c453
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
vector/src/main/java/im/vector/app/features/analytics/DecryptionFailureTracker.kt
View File

@ -29,6 +29,7 @@ import kotlinx.coroutines.flow.onEach
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.matrix.android.sdk.api.session.crypto.MXCryptoError import org.matrix.android.sdk.api.session.crypto.MXCryptoError
import org.matrix.android.sdk.api.session.room.timeline.TimelineEvent import org.matrix.android.sdk.api.session.room.timeline.TimelineEvent
import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
import javax.inject.Singleton import javax.inject.Singleton
@ -38,7 +39,7 @@ private data class DecryptionFailure(
val failedEventId: String, val failedEventId: String,
val error: MXCryptoError.ErrorType val error: MXCryptoError.ErrorType
) )
private typealias DetailedErrorName = Pair<String, Error.Name>
private const val GRACE_PERIOD_MILLIS = 4_000 private const val GRACE_PERIOD_MILLIS = 4_000
private const val CHECK_INTERVAL = 2_000L private const val CHECK_INTERVAL = 2_000L
@ -112,7 +113,7 @@ class DecryptionFailureTracker @Inject constructor(
private fun checkFailures() { private fun checkFailures() {
val now = clock.epochMillis() val now = clock.epochMillis()
val aggregatedErrors: Map<Error.Name, List<String>> val aggregatedErrors: Map<DetailedErrorName, List<String>>
synchronized(failures) { synchronized(failures) {
val toReport = mutableListOf<DecryptionFailure>() val toReport = mutableListOf<DecryptionFailure>()
failures.removeAll { failure -> failures.removeAll { failure ->
@ -136,20 +137,19 @@ class DecryptionFailureTracker @Inject constructor(
// for now we ignore events already reported even if displayed again? // for now we ignore events already reported even if displayed again?
.filter { alreadyReported.contains(it).not() } .filter { alreadyReported.contains(it).not() }
.forEach { failedEventId -> .forEach { failedEventId ->
analyticsTracker.capture(Error(failedEventId, Error.Domain.E2EE, aggregation.key)) analyticsTracker.capture(Error(aggregation.key.first, Error.Domain.E2EE, aggregation.key.second))
alreadyReported.add(failedEventId) alreadyReported.add(failedEventId)
} }
} }
} }
private fun MXCryptoError.ErrorType.toAnalyticsErrorName(): Error.Name { private fun MXCryptoError.ErrorType.toAnalyticsErrorName(): DetailedErrorName {
val detailed = "$name | mxc_crypto_error_type"
return when (this) { return when (this) {
MXCryptoError.ErrorType.UNKNOWN_INBOUND_SESSION_ID -> Error.Name.OlmKeysNotSentError MXCryptoError.ErrorType.UNKNOWN_INBOUND_SESSION_ID -> Pair(detailed, Error.Name.OlmKeysNotSentError)
MXCryptoError.ErrorType.OLM -> { MXCryptoError.ErrorType.OLM -> Pair(detailed, Error.Name.OlmUnspecifiedError)
Error.Name.OlmUnspecifiedError MXCryptoError.ErrorType.UNKNOWN_MESSAGE_INDEX -> Pair(detailed, Error.Name.OlmIndexError)
} else -> Pair(detailed, Error.Name.UnknownError)
MXCryptoError.ErrorType.UNKNOWN_MESSAGE_INDEX -> Error.Name.OlmIndexError
else -> Error.Name.UnknownError
} }
} }
} }

1
vector/src/main/java/im/vector/app/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
View File

@ -138,6 +138,7 @@ class TimelineItemFactory @Inject constructor(
} }
}.also { }.also {
if (it != null && event.isEncrypted()) { if (it != null && event.isEncrypted()) {
// Timber.i("----> ${event.eventId} encryption error found")
decryptionFailureTracker.e2eEventDisplayedInTimeline(event) decryptionFailureTracker.e2eEventDisplayedInTimeline(event)
} }
} }