Merge pull request #7382 from vector-im/feature/bma/nicer_doctor

Let the doctor be less strict and just warn.
This commit is contained in:
Benoit Marty 2022-10-18 10:28:25 +02:00 committed by GitHub
commit cf590c1887
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions

View File

@ -54,7 +54,8 @@ doctor {
/** /**
* Warn when not using parallel GC. Parallel GC is faster for build type tasks and is no longer the default in Java 9+. * Warn when not using parallel GC. Parallel GC is faster for build type tasks and is no longer the default in Java 9+.
*/ */
warnWhenNotUsingParallelGC = !isCiBuild // Note: Actually, if set to true, it fails the build. See https://lightrun.com/answers/runningcode-gradle-doctor-warnwhennotusingparallelgc-fails-the-build-warn-is-a-confusing-keyword-here
warnWhenNotUsingParallelGC = false
/** /**
* Throws an error when the `Delete` or `clean` task has dependencies. * Throws an error when the `Delete` or `clean` task has dependencies.
* If a clean task depends on other tasks, clean can be reordered and made to run after the tasks that would produce * If a clean task depends on other tasks, clean can be reordered and made to run after the tasks that would produce
@ -82,7 +83,7 @@ doctor {
/** /**
* Fail on any `JAVA_HOME` issues. * Fail on any `JAVA_HOME` issues.
*/ */
failOnError.set(!isCiBuild) failOnError.set(false)
/** /**
* Extra message text, if any, to show with the Gradle Doctor message. This is useful if you have a wiki page or * Extra message text, if any, to show with the Gradle Doctor message. This is useful if you have a wiki page or
* other instructions that you want to link for developers on your team if they encounter an issue. * other instructions that you want to link for developers on your team if they encounter an issue.