From c6593f0cee4faa5cad4ab645887942d67d28bd04 Mon Sep 17 00:00:00 2001 From: ariskotsomitopoulos Date: Tue, 22 Mar 2022 13:57:20 +0200 Subject: [PATCH] PR remarks --- .../database/lightweight/LightweightSettingsStorage.kt | 4 ++-- .../main/java/im/vector/app/features/home/HomeActivity.kt | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/lightweight/LightweightSettingsStorage.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/lightweight/LightweightSettingsStorage.kt index 65c98ab872..069e539e2c 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/lightweight/LightweightSettingsStorage.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/lightweight/LightweightSettingsStorage.kt @@ -24,13 +24,13 @@ import javax.inject.Inject /** * The purpose of this class is to provide an alternative and lightweight way to store settings/data - * on the sdi without using the database. This should be used just for sdk/user preferences and + * on the sdk without using the database. This should be used just for sdk/user preferences and * not for large data sets */ class LightweightSettingsStorage @Inject constructor( context: Context, - val matrixConfiguration: MatrixConfiguration + private val matrixConfiguration: MatrixConfiguration ) { private val sdkDefaultPrefs = PreferenceManager.getDefaultSharedPreferences(context.applicationContext) diff --git a/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt b/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt index dbeb5d5b8f..2e9ab0efcb 100644 --- a/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt +++ b/vector/src/main/java/im/vector/app/features/home/HomeActivity.kt @@ -90,7 +90,7 @@ import javax.inject.Inject data class HomeActivityArgs( val clearNotification: Boolean, val accountCreation: Boolean, - val existingSession: Boolean = false, + val hasExistingSession: Boolean = false, val inviteNotificationRoomId: String? = null ) : Parcelable @@ -280,7 +280,7 @@ class HomeActivity : if (checkSession) { // We should check session to ensure we will only clear cache if needed val args = intent.getParcelableExtra(Mavericks.KEY_ARG) - if (args?.existingSession == true) { + if (args?.hasExistingSession == true) { // existingSession --> Will be true only if we came from an existing active session Timber.i("----> Migrating threads from an existing session..") handleThreadsMigration() @@ -597,7 +597,7 @@ class HomeActivity : val args = HomeActivityArgs( clearNotification = clearNotification, accountCreation = accountCreation, - existingSession = existingSession, + hasExistingSession = existingSession, inviteNotificationRoomId = inviteNotificationRoomId )