Renames call option to be more agnostic

This commit is contained in:
ericdecanini 2022-03-22 17:56:07 +01:00
parent f722b2eb85
commit bfd31de05e
4 changed files with 8 additions and 8 deletions

View File

@ -88,7 +88,7 @@ import org.matrix.android.sdk.api.session.room.model.Membership
fun render(roomDetailViewState: RoomDetailViewState) {
val summary = roomDetailViewState.asyncRoomSummary()
val newState = if (summary?.membership != Membership.JOIN ||
roomDetailViewState.isWebRTCCallOptionAvailable() ||
roomDetailViewState.isCallOptionAvailable() ||
!roomDetailViewState.isAllowedToManageWidgets ||
roomDetailViewState.jitsiState.widgetId == null) {
State.Unmount

View File

@ -87,7 +87,7 @@ data class RoomDetailViewState(
rootThreadEventId = args.threadTimelineArgs?.rootThreadEventId
)
fun isWebRTCCallOptionAvailable() = asyncRoomSummary.invoke()?.isDirect ?: true
fun isCallOptionAvailable() = asyncRoomSummary.invoke()?.isDirect ?: true
fun isSearchAvailable() = asyncRoomSummary()?.isEncrypted == false

View File

@ -714,10 +714,10 @@ class TimelineViewModel @AssistedInject constructor(
R.id.timeline_setting -> true
R.id.invite -> state.canInvite
R.id.open_matrix_apps -> true
R.id.voice_call -> state.isWebRTCCallOptionAvailable()
R.id.video_call -> state.isWebRTCCallOptionAvailable() || state.jitsiState.confId == null || state.jitsiState.hasJoined
R.id.voice_call -> state.isCallOptionAvailable()
R.id.video_call -> state.isCallOptionAvailable() || state.jitsiState.confId == null || state.jitsiState.hasJoined
// Show Join conference button only if there is an active conf id not joined. Otherwise fallback to default video disabled. ^
R.id.join_conference -> !state.isWebRTCCallOptionAvailable() && state.jitsiState.confId != null && !state.jitsiState.hasJoined
R.id.join_conference -> !state.isCallOptionAvailable() && state.jitsiState.confId != null && !state.jitsiState.hasJoined
R.id.search -> state.isSearchAvailable()
R.id.menu_timeline_thread_list -> vectorPreferences.areThreadMessagesEnabled()
R.id.dev_tools -> vectorPreferences.developerMode()

View File

@ -25,7 +25,7 @@
android:title="@string/action_video_call"
android:visible="false"
app:iconTint="?colorPrimary"
app:showAsAction="always"
app:showAsAction="ifRoom"
tools:visible="true" />
<item
@ -34,7 +34,7 @@
android:title="@string/call"
android:visible="false"
app:iconTint="?colorPrimary"
app:showAsAction="always"
app:showAsAction="ifRoom"
tools:visible="true" />
<item
@ -43,7 +43,7 @@
android:visible="false"
app:iconTint="?colorPrimary"
app:actionLayout="@layout/view_thread_notification_badge"
app:showAsAction="always"
app:showAsAction="ifRoom"
tools:visible="true" />
<item android:id="@+id/join_conference"