Simplify code

This commit is contained in:
Benoit Marty 2020-02-20 18:05:53 +01:00
parent d867b1345f
commit b85c76b172
2 changed files with 8 additions and 20 deletions

View File

@ -122,9 +122,9 @@ object MatrixPatterns {
*/ */
fun isEventId(str: String?): Boolean { fun isEventId(str: String?): Boolean {
return str != null return str != null
&& (str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER && (str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER
|| str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER_V3 || str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER_V3
|| str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER_V4) || str matches PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER_V4)
} }
/** /**
@ -144,14 +144,6 @@ object MatrixPatterns {
* @return null if not found or if matrixId is null * @return null if not found or if matrixId is null
*/ */
fun extractServerNameFromId(matrixId: String?): String? { fun extractServerNameFromId(matrixId: String?): String? {
if (matrixId == null) { return matrixId?.substringAfter(":", missingDelimiterValue = "")?.takeIf { it.isNotEmpty() }
return null
}
val index = matrixId.indexOf(":")
return if (index == -1) {
null
} else matrixId.substring(index + 1)
} }
} }

View File

@ -297,15 +297,11 @@ class RoomDetailViewModel @AssistedInject constructor(@Assisted initialState: Ro
if (isRoomJoined) { if (isRoomJoined) {
setState { copy(tombstoneEventHandling = Success(roomId)) } setState { copy(tombstoneEventHandling = Success(roomId)) }
} else { } else {
val viaServer = MatrixPatterns.extractServerNameFromId(action.event.senderId).let { val viaServers = MatrixPatterns.extractServerNameFromId(action.event.senderId)
if (it.isNullOrBlank()) { ?.let { listOf(it) }
emptyList() .orEmpty()
} else {
listOf(it)
}
}
session.rx() session.rx()
.joinRoom(roomId, viaServers = viaServer) .joinRoom(roomId, viaServers = viaServers)
.map { roomId } .map { roomId }
.execute { .execute {
copy(tombstoneEventHandling = it) copy(tombstoneEventHandling = it)