Merge pull request #7058 from vector-im/fix/mna/run-sonar-only-when-token-available
CI: only run sonarqube task when token is known
This commit is contained in:
commit
b501770fa9
7
.github/workflows/tests.yml
vendored
7
.github/workflows/tests.yml
vendored
@ -70,12 +70,15 @@ jobs:
|
|||||||
./gradlew unitTestsWithCoverage $CI_GRADLE_ARG_PROPERTIES
|
./gradlew unitTestsWithCoverage $CI_GRADLE_ARG_PROPERTIES
|
||||||
./gradlew instrumentationTestsWithCoverage $CI_GRADLE_ARG_PROPERTIES
|
./gradlew instrumentationTestsWithCoverage $CI_GRADLE_ARG_PROPERTIES
|
||||||
./gradlew generateCoverageReport $CI_GRADLE_ARG_PROPERTIES
|
./gradlew generateCoverageReport $CI_GRADLE_ARG_PROPERTIES
|
||||||
- run: ./gradlew sonarqube $CI_GRADLE_ARG_PROPERTIES
|
|
||||||
if: always() # we may have failed a previous step and retried, that's OK
|
# we may have failed a previous step and retried, that's OK
|
||||||
|
- name: Publish results to Sonar
|
||||||
env:
|
env:
|
||||||
GITHUB_TOKEN: ${{ secrets.SONARQUBE_GITHUB_API_TOKEN }} # Needed to get PR information, if any
|
GITHUB_TOKEN: ${{ secrets.SONARQUBE_GITHUB_API_TOKEN }} # Needed to get PR information, if any
|
||||||
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
|
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
|
||||||
ORG_GRADLE_PROJECT_SONAR_LOGIN: ${{ secrets.SONAR_TOKEN }}
|
ORG_GRADLE_PROJECT_SONAR_LOGIN: ${{ secrets.SONAR_TOKEN }}
|
||||||
|
if: ${{ always() && env.GITHUB_TOKEN != '' && env.SONAR_TOKEN != '' && env.ORG_GRADLE_PROJECT_SONAR_LOGIN != '' }}
|
||||||
|
run: ./gradlew sonarqube $CI_GRADLE_ARG_PROPERTIES
|
||||||
|
|
||||||
- name: Format unit test results
|
- name: Format unit test results
|
||||||
if: always()
|
if: always()
|
||||||
|
1
changelog.d/7057.misc
Normal file
1
changelog.d/7057.misc
Normal file
@ -0,0 +1 @@
|
|||||||
|
CI: only run sonarqube task when token is known
|
Loading…
x
Reference in New Issue
Block a user