catching username availabilty exceptions and handling as user facing error

This commit is contained in:
Adam Brown 2022-08-04 11:58:31 +01:00
parent 825ba77bb2
commit a4ea47e740
3 changed files with 43 additions and 18 deletions

View File

@ -193,25 +193,32 @@ class OnboardingViewModel @AssistedInject constructor(
} }
private suspend fun checkUserNameAvailability(userName: String) { private suspend fun checkUserNameAvailability(userName: String) {
when (val result = registrationWizard.registrationAvailable(userName)) { runCatching { registrationWizard.registrationAvailable(userName) }.fold(
RegistrationAvailability.Available -> { onSuccess = { result ->
setState { when (result) {
copy( RegistrationAvailability.Available -> {
registrationState = RegistrationState( setState {
isUserNameAvailable = true, copy(
selectedMatrixId = when { registrationState = RegistrationState(
userName.isMatrixId() -> userName isUserNameAvailable = true,
else -> "@$userName:${selectedHomeserver.userFacingUrl.toReducedUrl()}" selectedMatrixId = when {
}, userName.isMatrixId() -> userName
) else -> "@$userName:${selectedHomeserver.userFacingUrl.toReducedUrl()}"
) },
} )
} )
}
}
is RegistrationAvailability.NotAvailable -> { is RegistrationAvailability.NotAvailable -> {
_viewEvents.post(OnboardingViewEvents.Failure(result.failure)) _viewEvents.post(OnboardingViewEvents.Failure(result.failure))
} }
} }
},
onFailure = {
_viewEvents.post(OnboardingViewEvents.Failure(it))
}
)
} }
private fun withAction(action: OnboardingAction, block: (OnboardingAction) -> Unit) { private fun withAction(action: OnboardingAction, block: (OnboardingAction) -> Unit) {

View File

@ -390,6 +390,20 @@ class OnboardingViewModelTest {
.finish() .finish()
} }
@Test
fun `given available username throws, when a register username is entered, then emits error`() = runTest {
viewModelWith(initialRegistrationState(A_HOMESERVER_URL))
fakeAuthenticationService.givenRegistrationWizard(FakeRegistrationWizard().also { it.givenUserNameIsAvailableThrows(A_USERNAME, AN_ERROR) })
val test = viewModel.test()
viewModel.handle(OnboardingAction.UserNameEnteredAction.Registration(A_USERNAME))
test
.assertStates(initialState)
.assertEvents(OnboardingViewEvents.Failure(AN_ERROR))
.finish()
}
@Test @Test
fun `given available username, when a register username is entered, then emits available registration state`() = runTest { fun `given available username, when a register username is entered, then emits available registration state`() = runTest {
viewModelWith(initialRegistrationState(A_HOMESERVER_URL)) viewModelWith(initialRegistrationState(A_HOMESERVER_URL))

View File

@ -57,6 +57,10 @@ class FakeRegistrationWizard : RegistrationWizard by mockk(relaxed = false) {
coEvery { registrationAvailable(userName) } returns RegistrationAvailability.Available coEvery { registrationAvailable(userName) } returns RegistrationAvailability.Available
} }
fun givenUserNameIsAvailableThrows(userName: String, cause: Throwable) {
coEvery { registrationAvailable(userName) } throws cause
}
fun givenUserNameIsUnavailable(userName: String, failure: Failure.ServerError) { fun givenUserNameIsUnavailable(userName: String, failure: Failure.ServerError) {
coEvery { registrationAvailable(userName) } returns RegistrationAvailability.NotAvailable(failure) coEvery { registrationAvailable(userName) } returns RegistrationAvailability.NotAvailable(failure)
} }