mirror of
https://github.com/SchildiChat/SchildiChat-android.git
synced 2024-12-26 17:43:11 +01:00
Code review fixes.
This commit is contained in:
parent
33e5a206bd
commit
a13ba13fb5
@ -128,6 +128,7 @@ fun checkPermissions(permissionsToBeGranted: List<String>,
|
||||
.setPositiveButton(R.string.ok) { _, _ ->
|
||||
activityResultLauncher.launch(missingPermissions.toTypedArray())
|
||||
}
|
||||
.setNegativeButton(R.string.action_not_now, null)
|
||||
.show()
|
||||
} else {
|
||||
// some permissions are not granted, ask permissions
|
||||
|
@ -19,7 +19,7 @@ package im.vector.app.features.location
|
||||
import android.app.Activity
|
||||
import im.vector.app.core.utils.openAppSettingsPage
|
||||
|
||||
class DefaultLocationSharingSettingsNavigator constructor(val activity: Activity?) : LocationSharingSettingsNavigator {
|
||||
class DefaultLocationSharingNavigator constructor(val activity: Activity?) : LocationSharingNavigator {
|
||||
|
||||
override var goingToAppSettings: Boolean = false
|
||||
|
@ -54,7 +54,7 @@ class LocationSharingFragment @Inject constructor(
|
||||
|
||||
private val viewModel: LocationSharingViewModel by fragmentViewModel()
|
||||
|
||||
private val locationSharingNavigator: LocationSharingSettingsNavigator by lazy { DefaultLocationSharingSettingsNavigator(activity) }
|
||||
private val locationSharingNavigator: LocationSharingNavigator by lazy { DefaultLocationSharingNavigator(activity) }
|
||||
|
||||
// Keep a ref to handle properly the onDestroy callback
|
||||
private var mapView: WeakReference<MapView>? = null
|
||||
|
@ -16,7 +16,7 @@
|
||||
|
||||
package im.vector.app.features.location
|
||||
|
||||
interface LocationSharingSettingsNavigator {
|
||||
interface LocationSharingNavigator {
|
||||
var goingToAppSettings: Boolean
|
||||
fun quit()
|
||||
fun goToAppSettings()
|
Loading…
Reference in New Issue
Block a user