From 5f1aad76e6124539318c765387953a39d45c2ebd Mon Sep 17 00:00:00 2001 From: chagai95 <31655082+chagai95@users.noreply.github.com> Date: Mon, 2 May 2022 09:11:47 +0200 Subject: [PATCH 1/2] don't pause timer when call is held This is also the way it is implemented in web and the correct way --- .../im/vector/app/features/call/webrtc/WebRtcCall.kt | 9 --------- 1 file changed, 9 deletions(-) diff --git a/vector/src/main/java/im/vector/app/features/call/webrtc/WebRtcCall.kt b/vector/src/main/java/im/vector/app/features/call/webrtc/WebRtcCall.kt index fed61c3b15..f0db3e199f 100644 --- a/vector/src/main/java/im/vector/app/features/call/webrtc/WebRtcCall.kt +++ b/vector/src/main/java/im/vector/app/features/call/webrtc/WebRtcCall.kt @@ -670,15 +670,11 @@ class WebRtcCall( isRemoteOnHold = true isLocalOnHold = true direction = RtpTransceiver.RtpTransceiverDirection.SEND_ONLY - timer.pause() } else { isRemoteOnHold = false isLocalOnHold = wasLocalOnHold onCallBecomeActive(this@WebRtcCall) direction = RtpTransceiver.RtpTransceiverDirection.SEND_RECV - if (!isLocalOnHold) { - timer.resume() - } } for (transceiver in peerConnection?.transceivers ?: emptyList()) { transceiver.direction = direction @@ -941,11 +937,6 @@ class WebRtcCall( wasLocalOnHold = nowOnHold if (prevOnHold != nowOnHold) { isLocalOnHold = nowOnHold - if (nowOnHold) { - timer.pause() - } else { - timer.resume() - } listeners.forEach { tryOrNull { it.onHoldUnhold() } } From ac7dd2cef34812b00baa52a812b6f76e53b755db Mon Sep 17 00:00:00 2001 From: chagai95 <31655082+chagai95@users.noreply.github.com> Date: Mon, 2 May 2022 09:13:46 +0200 Subject: [PATCH 2/2] Create 5885.bugfix --- changelog.d/5885.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/5885.bugfix diff --git a/changelog.d/5885.bugfix b/changelog.d/5885.bugfix new file mode 100644 index 0000000000..a555ad0e98 --- /dev/null +++ b/changelog.d/5885.bugfix @@ -0,0 +1 @@ +Don't pause timer when call is held.