filippodb
/
SchildiChat-android
mirror of https://github.com/SchildiChat/SchildiChat-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix message render failures caused by Element's ListHandler 

Fixes https://github.com/SchildiChat/SchildiChat-android/issues/206

On repeated render, we sometimes get
`java.lang.NumberFormatException: For input string: ""`

Note: this doesn't necessarily happen on messages with lists, but any,
not sure when...

Change-Id: Icaa5b505c6f8a732d0a04378e0872e82ae40e16d
This commit is contained in:
SpiritCroc 2023-09-05 23:10:00 +02:00
parent 2e6fcad79f
commit 97dc744db3
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
vector/src/main/java/im/vector/app/features/html/ListHandlerWithInitialStart.java
View File

@ -32,6 +32,7 @@ import io.noties.markwon.core.CoreProps;
import io.noties.markwon.html.HtmlTag; import io.noties.markwon.html.HtmlTag;
import io.noties.markwon.html.MarkwonHtmlRenderer; import io.noties.markwon.html.MarkwonHtmlRenderer;
import io.noties.markwon.html.TagHandler; import io.noties.markwon.html.TagHandler;
import timber.log.Timber;
/** /**
* Copied from https://github.com/noties/Markwon/blob/master/markwon-html/src/main/java/io/noties/markwon/html/tag/ListHandler.java#L44 * Copied from https://github.com/noties/Markwon/blob/master/markwon-html/src/main/java/io/noties/markwon/html/tag/ListHandler.java#L44
@ -63,8 +64,17 @@ public class ListHandlerWithInitialStart extends TagHandler {
final RenderProps renderProps = visitor.renderProps(); final RenderProps renderProps = visitor.renderProps();
final SpanFactory spanFactory = configuration.spansFactory().get(ListItem.class); final SpanFactory spanFactory = configuration.spansFactory().get(ListItem.class);
// Modified line // Modified part start
int number = Integer.parseInt(block.attributes().containsKey(START_KEY) ? block.attributes().get(START_KEY) : "1"); int number;
try {
number = Integer.parseInt(block.attributes().containsKey(START_KEY) ? block.attributes().get(START_KEY) : "1");
} catch (Exception e) {
// On repeated render, we get `java.lang.NumberFormatException: For input string: ""`
// See also https://github.com/SchildiChat/SchildiChat-android/issues/206
//Timber.v(e, "Failed to read list start");
number = 1;
}
// Modified part end
final int bulletLevel = currentBulletListLevel(block); final int bulletLevel = currentBulletListLevel(block);