From 937d497a1f7d16abf42a22f650b00abe7f122a3f Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoitm@matrix.org>
Date: Fri, 6 Mar 2020 17:24:57 +0100
Subject: [PATCH] Revert the check box in case of error

---
 .../VectorSettingsNotificationPreferenceFragment.kt        | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/vector/src/main/java/im/vector/riotx/features/settings/VectorSettingsNotificationPreferenceFragment.kt b/vector/src/main/java/im/vector/riotx/features/settings/VectorSettingsNotificationPreferenceFragment.kt
index bd79f081a3..f191b43724 100644
--- a/vector/src/main/java/im/vector/riotx/features/settings/VectorSettingsNotificationPreferenceFragment.kt
+++ b/vector/src/main/java/im/vector/riotx/features/settings/VectorSettingsNotificationPreferenceFragment.kt
@@ -168,11 +168,14 @@ class VectorSettingsNotificationPreferenceFragment @Inject constructor(
                 pushManager.unregisterPusher(it, object : MatrixCallback<Unit> {
                     override fun onSuccess(data: Unit) {
                         session.refreshPushers()
-                        super.onSuccess(data)
                     }
 
                     override fun onFailure(failure: Throwable) {
-                        session.refreshPushers()
+                        if (!isAdded) {
+                            return
+                        }
+                        // revert the check box
+                        switchPref.isChecked = !switchPref.isChecked
                         Toast.makeText(activity, R.string.unknown_error, Toast.LENGTH_SHORT).show()
                     }
                 })