filippodb/SchildiChat-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adding TODO to confirm

Browse Source
This commit is contained in:
Maxime Naturel 2022-02-18 14:22:51 +01:00
parent 8115b4b6e6
commit 7df5372d4d
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt
View File

@ -51,8 +51,9 @@ class LoginWebFragment @Inject constructor(
private val assetReader: AssetReader private val assetReader: AssetReader
) : AbstractLoginFragment<FragmentLoginWebBinding>() { ) : AbstractLoginFragment<FragmentLoginWebBinding>() {
// TODO confirm the need of this viewModel // TODO I noticed in the Git history this variable was a local variable inside notifyViewModel method
val softLogoutViewModel: SoftLogoutViewModel by activityViewModel() // TODO was there any reason ? To be able to create this ViewModel we must be sure we will have a valid session
private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel()
override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentLoginWebBinding { override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentLoginWebBinding {
return FragmentLoginWebBinding.inflate(inflater, container, false) return FragmentLoginWebBinding.inflate(inflater, container, false)
@ -71,6 +72,7 @@ class LoginWebFragment @Inject constructor(
override fun updateWithState(state: LoginViewState) { override fun updateWithState(state: LoginViewState) {
setupTitle(state) setupTitle(state)
// TODO check how it is possible to arrive in this case
isForSessionRecovery = state.deviceId?.isNotBlank() == true isForSessionRecovery = state.deviceId?.isNotBlank() == true
if (!isWebViewLoaded) { if (!isWebViewLoaded) {

6
vector/src/main/java/im/vector/app/features/login2/LoginWebFragment2.kt
View File

@ -56,8 +56,9 @@ class LoginWebFragment2 @Inject constructor(
return FragmentLoginWebBinding.inflate(inflater, container, false) return FragmentLoginWebBinding.inflate(inflater, container, false)
} }
// TODO confirm the need of this viewModel // TODO I noticed in the Git history this variable was a local variable inside notifyViewModel method
val softLogoutViewModel: SoftLogoutViewModel by activityViewModel() // TODO was there any reason ? To be able to create this ViewModel we must be sure we will have a valid session
private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel()
private var isWebViewLoaded = false private var isWebViewLoaded = false
private var isForSessionRecovery = false private var isForSessionRecovery = false
@ -72,6 +73,7 @@ class LoginWebFragment2 @Inject constructor(
override fun updateWithState(state: LoginViewState2) { override fun updateWithState(state: LoginViewState2) {
setupTitle(state) setupTitle(state)
// TODO check how it is possible to arrive in this case
isForSessionRecovery = state.deviceId?.isNotBlank() == true isForSessionRecovery = state.deviceId?.isNotBlank() == true
if (!isWebViewLoaded) { if (!isWebViewLoaded) {