From 9d5197b1c8421bf80a08e4b75435fcc016b9bde6 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoitm@matrix.org>
Date: Mon, 13 Jan 2020 22:41:44 +0100
Subject: [PATCH] Show all hidden event in the timeline when the developer
 settings is ON

---
 .../riotx/features/home/room/detail/RoomDetailViewModel.kt   | 3 +--
 .../home/room/detail/timeline/factory/TimelineItemFactory.kt | 4 ++--
 .../room/detail/timeline/helper/TimelineDisplayableEvents.kt | 5 -----
 .../src/main/res/xml/vector_settings_advanced_settings.xml   | 2 --
 4 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/RoomDetailViewModel.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/RoomDetailViewModel.kt
index 94291905e9..44a8ca6795 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/RoomDetailViewModel.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/RoomDetailViewModel.kt
@@ -90,8 +90,7 @@ class RoomDetailViewModel @AssistedInject constructor(@Assisted initialState: Ro
     private val timelineSettings = if (userPreferencesProvider.shouldShowHiddenEvents()) {
         TimelineSettings(30,
                 filterEdits = false,
-                filterTypes = true,
-                allowedTypes = TimelineDisplayableEvents.DEBUG_DISPLAYABLE_TYPES,
+                filterTypes = false,
                 buildReadReceipts = userPreferencesProvider.shouldShowReadReceipts())
     } else {
         TimelineSettings(30,
diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
index 6d27cf7211..15df3bc5c9 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
@@ -68,12 +68,12 @@ class TimelineItemFactory @Inject constructor(
                         encryptedItemFactory.create(event, nextEvent, highlight, callback)
                     }
                 }
-
                 // Unhandled event types (yet)
                 EventType.STATE_ROOM_THIRD_PARTY_INVITE -> defaultItemFactory.create(event, highlight, callback)
                 else                                    -> {
+                    // Should only happen when shouldShowHiddenEvents() settings is ON
                     Timber.v("Type ${event.root.getClearType()} not handled")
-                    null
+                    defaultItemFactory.create(event, highlight, callback)
                 }
             }
         } catch (throwable: Throwable) {
diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/helper/TimelineDisplayableEvents.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/helper/TimelineDisplayableEvents.kt
index 1c9ff6dac5..8d85ffb676 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/helper/TimelineDisplayableEvents.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/helper/TimelineDisplayableEvents.kt
@@ -42,11 +42,6 @@ object TimelineDisplayableEvents {
             EventType.STATE_ROOM_TOMBSTONE,
             EventType.STATE_ROOM_JOIN_RULES
     )
-
-    val DEBUG_DISPLAYABLE_TYPES = DISPLAYABLE_TYPES + listOf(
-            EventType.REDACTION,
-            EventType.REACTION
-    )
 }
 
 fun TimelineEvent.canBeMerged(): Boolean {
diff --git a/vector/src/main/res/xml/vector_settings_advanced_settings.xml b/vector/src/main/res/xml/vector_settings_advanced_settings.xml
index 131b43c8d5..ad698f0036 100644
--- a/vector/src/main/res/xml/vector_settings_advanced_settings.xml
+++ b/vector/src/main/res/xml/vector_settings_advanced_settings.xml
@@ -30,8 +30,6 @@
             android:summary="@string/settings_developer_mode_fail_fast_summary"
             android:title="@string/settings_developer_mode_fail_fast_title" />
 
-        <!-- TODO Display unsupported events -->
-
     </im.vector.riotx.core.preference.VectorPreferenceCategory>
 
     <im.vector.riotx.core.preference.VectorPreferenceCategory