filippodb
/
SchildiChat-android
mirror of https://github.com/SchildiChat/SchildiChat-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4770 from vector-im/feature/adm/emoji-27-and-below-crash 

Fixing Android 8.1.1 / 27 and below emoji crash
This commit is contained in:
ganfra 2021-12-20 11:41:18 +01:00 committed by GitHub
parent c6a118fc1f 18df540487
commit 721bf4fbd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/4769.bugfix Normal file
View File

@ -0,0 +1 @@
Fixing emoji related crashes on android 8.1.1 and below

11
vector/src/main/java/im/vector/app/features/html/SpanUtils.kt
View File

@ -16,7 +16,6 @@
package im.vector.app.features.html package im.vector.app.features.html
import android.os.Build
import android.text.Spanned import android.text.Spanned
import android.text.style.MetricAffectingSpan import android.text.style.MetricAffectingSpan
import android.text.style.StrikethroughSpan import android.text.style.StrikethroughSpan
@ -41,13 +40,11 @@ class SpanUtils @Inject constructor(
) )
} }
// Workaround for https://issuetracker.google.com/issues/188454876 /**
* TextFutures do not support StrikethroughSpan, UnderlineSpan or MetricAffectingSpan
* Workaround for https://issuetracker.google.com/issues/188454876
*/
private fun canUseTextFuture(spanned: Spanned): Boolean { private fun canUseTextFuture(spanned: Spanned): Boolean {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.P) {
// On old devices, it works correctly
return true
}
return spanned return spanned
.getSpans(0, spanned.length, Any::class.java) .getSpans(0, spanned.length, Any::class.java)
.all { it !is StrikethroughSpan && it !is UnderlineSpan && it !is MetricAffectingSpan } .all { it !is StrikethroughSpan && it !is UnderlineSpan && it !is MetricAffectingSpan }