From 6d7e7446aeabbf083f6a34f4df495b4101789370 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Tue, 5 Nov 2024 09:46:27 +0100
Subject: [PATCH] Upgrade detekt and reduce detected issues (less impact on
 this old code).

---
 build.gradle               | 2 +-
 dependencies_groups.gradle | 2 ++
 tools/detekt/detekt.yml    | 6 +++++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/build.gradle b/build.gradle
index 2e4b5b5817..182211d18f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -43,7 +43,7 @@ plugins {
     // ktlint Plugin
     id "org.jlleitschuh.gradle.ktlint" version "11.3.2"
     // Detekt
-    id "io.gitlab.arturbosch.detekt" version "1.22.0"
+    id "io.gitlab.arturbosch.detekt" version "1.23.7"
     // Ksp
     id "com.google.devtools.ksp" version "1.9.24-1.0.20"
 
diff --git a/dependencies_groups.gradle b/dependencies_groups.gradle
index 4b69468e06..3024963bf8 100644
--- a/dependencies_groups.gradle
+++ b/dependencies_groups.gradle
@@ -203,6 +203,7 @@ ext.groups = [
                         'org.jacoco',
                         'org.java-websocket',
                         'org.jcodec',
+                        'org.jcommander',
                         'org.jetbrains',
                         'org.jetbrains.dokka',
                         'org.jetbrains.intellij.deps',
@@ -229,6 +230,7 @@ ext.groups = [
                         'org.reactivestreams',
                         'org.robolectric',
                         'org.slf4j',
+                        'org.snakeyaml',
                         'org.sonatype.oss',
                         'org.testng',
                         'org.threeten',
diff --git a/tools/detekt/detekt.yml b/tools/detekt/detekt.yml
index 62a4fc408f..c2a6552004 100644
--- a/tools/detekt/detekt.yml
+++ b/tools/detekt/detekt.yml
@@ -25,6 +25,8 @@ style:
     active: false
   UseCheckOrError:
     active: false
+  UnusedPrivateProperty:
+    active: false
 
 empty-blocks:
   EmptyFunctionBlock:
@@ -75,6 +77,8 @@ naming:
 performance:
   SpreadOperator:
     active: false
+  ForEachOnRange:
+    active: false
 
 # Note: all rules for `comments` are disabled by default, but I put them here to be aware of their existence
 comments:
@@ -91,7 +95,7 @@ comments:
   EndOfSentenceFormat:
     active: true
   OutdatedDocumentation:
-    active: true
+    active: false
   UndocumentedPublicClass:
     active: false
   UndocumentedPublicFunction: