Fixes #2778

CHANGES.md

@@ -8,7 +8,7 @@ Improvements 🙌:
  -
 
 Bugfix 🐛:
- -
+ - Join room by alias other federation error (#2778)
 
 Translations 🗣:
  -

matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/peeking/PeekRoomTask.kt

@@ -17,6 +17,7 @@
 package org.matrix.android.sdk.internal.session.room.peeking
 
 import org.matrix.android.sdk.api.MatrixPatterns
+import org.matrix.android.sdk.api.extensions.tryOrNull
 import org.matrix.android.sdk.api.session.events.model.EventType
 import org.matrix.android.sdk.api.session.events.model.toModel
 import org.matrix.android.sdk.api.session.room.model.RoomAvatarContent
@@ -65,23 +66,29 @@ internal class DefaultPeekRoomTask @Inject constructor(
         }
 
         // Is it a public room?
-        val publicRepoResult = when (getRoomDirectoryVisibilityTask.execute(GetRoomDirectoryVisibilityTask.Params(roomId))) {
+        val visibilityRes = tryOrNull("## PEEK: failed to get visibility") {
-            RoomDirectoryVisibility.PRIVATE -> {
+            getRoomDirectoryVisibilityTask.execute(GetRoomDirectoryVisibilityTask.Params(roomId))
-                // We cannot resolve this room :/
-                null
         }
+        val publicRepoResult = when (visibilityRes) {
             RoomDirectoryVisibility.PUBLIC -> {
                 // Try to find it in directory
                 val filter = if (isAlias) PublicRoomsFilter(searchTerm = params.roomIdOrAlias.substring(1))
                 else null
 
+                tryOrNull("## PEEK: failed to GetPublicRoomTask") {
                     getPublicRoomTask.execute(GetPublicRoomTask.Params(
                             server = serverList.firstOrNull(),
                             publicRoomsParams = PublicRoomsParams(
                                     filter = filter,
                                     limit = 20.takeIf { filter != null } ?: 100
                             )
-                )).chunk?.firstOrNull { it.roomId == roomId }
+                    ))
+                }?.chunk?.firstOrNull { it.roomId == roomId }
+            }
+            else                           -> {
+                // RoomDirectoryVisibility.PRIVATE or null
+                // We cannot resolve this room :/
+                null
             }
         }