Fix some crashes

tools/templates/ElementFeature/root/src/app_package/Fragment.kt.ftl

@@ -36,8 +36,8 @@ class ${fragmentClass} @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
 		// Clear your view, unsubscribe...
+        super.onDestroyView()
     }
 
     override fun invalidate() = withState(viewModel) { state ->

vector/src/main/java/im/vector/app/core/platform/VectorBaseBottomSheetDialogFragment.kt

@@ -113,8 +113,8 @@ abstract class VectorBaseBottomSheetDialogFragment<VB: ViewBinding> : BottomShee
 
     @CallSuper
     override fun onDestroyView() {
-        super.onDestroyView()
         uiDisposables.clear()
+        super.onDestroyView()
     }
 
     @CallSuper

vector/src/main/java/im/vector/app/core/platform/VectorBaseFragment.kt

@@ -144,10 +144,10 @@ abstract class VectorBaseFragment<VB: ViewBinding> : BaseMvRxFragment(), HasScre
 
     @CallSuper
     override fun onDestroyView() {
-        super.onDestroyView()
         Timber.i("onDestroyView Fragment ${javaClass.simpleName}")
         uiDisposables.clear()
         _binding = null
+        super.onDestroyView()
     }
 
     override fun onDestroy() {

vector/src/main/java/im/vector/app/features/attachments/preview/AttachmentsPreviewFragment.kt

@@ -123,10 +123,10 @@ class AttachmentsPreviewFragment @Inject constructor(
     override fun getMenuRes() = R.menu.vector_attachments_preview
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.attachmentPreviewerMiniatureList.cleanup()
         views.attachmentPreviewerBigList.cleanup()
         attachmentMiniaturePreviewController.callback = null
+        super.onDestroyView()
     }
 
     override fun invalidate() = withState(viewModel) { state ->

vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileFragment.kt

@@ -174,10 +174,10 @@ class RoomProfileFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.matrixProfileAppBarLayout.removeOnOffsetChangedListener(appBarStateChangeListener)
         views.matrixProfileRecyclerView.cleanup()
         appBarStateChangeListener = null
+        super.onDestroyView()
     }
 
     override fun invalidate() = withState(roomProfileViewModel) { state ->

vector/src/main/java/im/vector/app/features/roomprofile/uploads/files/RoomUploadsFilesFragment.kt

@@ -63,9 +63,9 @@ class RoomUploadsFilesFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericStateViewListRecycler.cleanup()
         controller.listener = null
+        super.onDestroyView()
     }
 
     override fun onOpenClicked(uploadEvent: UploadEvent) {

vector/src/main/java/im/vector/app/features/roomprofile/uploads/media/RoomUploadsMediaFragment.kt

@@ -85,9 +85,9 @@ class RoomUploadsMediaFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericStateViewListRecycler.cleanup()
         controller.listener = null
+        super.onDestroyView()
     }
 
     // It's very strange i can't just access

vector/src/main/java/im/vector/app/features/settings/VectorSettingsBaseFragment.kt

@@ -78,8 +78,8 @@ abstract class VectorSettingsBaseFragment : PreferenceFragmentCompat(), HasScree
 
     @CallSuper
     override fun onDestroyView() {
-        super.onDestroyView()
         uiDisposables.clear()
+        super.onDestroyView()
     }
 
     override fun onDestroy() {

vector/src/main/java/im/vector/app/features/settings/devtools/AccountDataFragment.kt

@@ -68,9 +68,9 @@ class AccountDataFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericRecyclerView.cleanup()
         epoxyController.interactionListener = null
+        super.onDestroyView()
     }
 
     override fun didTap(data: UserAccountDataEvent) {

vector/src/main/java/im/vector/app/features/settings/devtools/GossipingEventsPaperTrailFragment.kt

@@ -60,9 +60,9 @@ class GossipingEventsPaperTrailFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericRecyclerView.cleanup()
         epoxyController.interactionListener = null
+        super.onDestroyView()
     }
 
     override fun didTap(event: Event) {

vector/src/main/java/im/vector/app/features/settings/devtools/IncomingKeyRequestListFragment.kt

@@ -53,7 +53,7 @@ class IncomingKeyRequestListFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericRecyclerView.cleanup()
+        super.onDestroyView()
     }
 }

vector/src/main/java/im/vector/app/features/settings/devtools/OutgoingKeyRequestListFragment.kt

@@ -28,7 +28,6 @@ import im.vector.app.core.platform.VectorBaseFragment
 import im.vector.app.databinding.FragmentGenericRecyclerBinding
 
 import javax.inject.Inject
-
 class OutgoingKeyRequestListFragment @Inject constructor(
         val viewModelFactory: KeyRequestListViewModel.Factory,
         private val epoxyController: OutgoingKeyRequestPagedController
@@ -51,8 +50,8 @@ class OutgoingKeyRequestListFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericRecyclerView.cleanup()
 //        epoxyController.interactionListener = null
+        super.onDestroyView()
     }
 }

vector/src/main/java/im/vector/app/features/settings/locale/LocalePickerFragment.kt

@@ -62,9 +62,9 @@ class LocalePickerFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.localeRecyclerView.cleanup()
         controller.listener = null
+        super.onDestroyView()
     }
 
     override fun invalidate() = withState(viewModel) { state ->

vector/src/main/java/im/vector/app/features/settings/threepids/ThreePidsSettingsFragment.kt

@@ -77,9 +77,9 @@ class ThreePidsSettingsFragment @Inject constructor(
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         views.genericRecyclerView.cleanup()
         epoxyController.interactionListener = null
+        super.onDestroyView()
     }
 
     override fun onResume() {

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

@@ -109,11 +109,11 @@ class WidgetFragment @Inject constructor() :
     }
 
     override fun onDestroyView() {
-        super.onDestroyView()
         if (fragmentArgs.kind.isAdmin()) {
             viewModel.getPostAPIMediator().clearWebView()
         }
         views.widgetWebView.clearAfterWidget()
+        super.onDestroyView()
     }
 
     override fun onResume() {

vector/src/main/java/im/vector/app/features/workers/signout/SignOutBottomSheetActionButton.kt

@@ -77,7 +77,7 @@ class SignOutBottomSheetActionButton @JvmOverloads constructor(
 
         typedArray.recycle()
 
-        setOnClickListener {
+        views.signedOutActionClickable.setOnClickListener {
             action?.invoke()
         }
     }