Merge pull request #3804 from vector-im/feature/ons/fix_deleting_user_device

Fix error when sending encrypted message if someone in the room logs out

changelog.d/3792.bugfix

@@ -0,0 +1 @@
+Fix error when sending encrypted message if someone in the room logs out.

matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/store/db/RealmCryptoStore.kt

@@ -286,12 +286,15 @@ internal class RealmCryptoStore @Inject constructor(
                 val userEntity = UserEntity.getOrCreate(realm, userId)
                 // First delete the removed devices
                 val deviceIds = devices.keys
-                userEntity.devices.iterator().forEach { deviceInfoEntity ->
+                userEntity.devices.toTypedArray().iterator().let {
+                    while (it.hasNext()) {
+                        val deviceInfoEntity = it.next()
                         if (deviceInfoEntity.deviceId !in deviceIds) {
                             Timber.d("Remove device ${deviceInfoEntity.deviceId} of user $userId")
                             deviceInfoEntity.deleteOnCascade()
                         }
                     }
+                }
                 // Then update existing devices or add new one
                 devices.values.forEach { cryptoDeviceInfo ->
                     val existingDeviceInfoEntity = userEntity.devices.firstOrNull { it.deviceId == cryptoDeviceInfo.deviceId }