VoIP: PR review remarks
This commit is contained in:
parent
0ed327646a
commit
5c4cf3f7c9
|
@ -211,7 +211,7 @@ internal class CallSignalingHandler @Inject constructor(private val activeCallHa
|
||||||
activeCallHandler.getCallWithId(it)
|
activeCallHandler.getCallWithId(it)
|
||||||
}
|
}
|
||||||
if (currentCall == null) {
|
if (currentCall == null) {
|
||||||
Timber.v("Call for content: $this is null")
|
Timber.v("Call with id $callId is null")
|
||||||
}
|
}
|
||||||
return currentCall
|
return currentCall
|
||||||
}
|
}
|
||||||
|
|
|
@ -41,7 +41,7 @@ internal class MxCallFactory @Inject constructor(
|
||||||
) {
|
) {
|
||||||
|
|
||||||
fun createIncomingCall(roomId: String, opponentUserId: String, content: CallInviteContent): MxCall? {
|
fun createIncomingCall(roomId: String, opponentUserId: String, content: CallInviteContent): MxCall? {
|
||||||
if (content.callId == null) return null
|
content.callId ?: return null
|
||||||
return MxCallImpl(
|
return MxCallImpl(
|
||||||
callId = content.callId,
|
callId = content.callId,
|
||||||
isOutgoing = false,
|
isOutgoing = false,
|
||||||
|
|
|
@ -60,7 +60,7 @@
|
||||||
app:layout_constraintStart_toStartOf="@+id/itemVerificationActionTitle"
|
app:layout_constraintStart_toStartOf="@+id/itemVerificationActionTitle"
|
||||||
app:layout_constraintTop_toBottomOf="@+id/itemVerificationActionTitle"
|
app:layout_constraintTop_toBottomOf="@+id/itemVerificationActionTitle"
|
||||||
tools:text="For maximum security, do this in person"
|
tools:text="For maximum security, do this in person"
|
||||||
/>
|
tools:visibility="visible" />
|
||||||
|
|
||||||
<ImageView
|
<ImageView
|
||||||
android:id="@+id/itemVerificationActionIcon"
|
android:id="@+id/itemVerificationActionIcon"
|
||||||
|
|
Loading…
Reference in New Issue