From 4d3e21d0469d9cb4bbc6962875256e252dd885e4 Mon Sep 17 00:00:00 2001
From: Adam Brown <adampsbrown@gmail.com>
Date: Wed, 3 Aug 2022 16:41:06 +0100
Subject: [PATCH] reusing lint file

---
 {vector-app => tools/lint}/lint.xml |   0
 vector-app/build.gradle             |   2 +-
 vector/build.gradle                 |   2 +-
 vector/lint.xml                     | 109 ----------------------------
 4 files changed, 2 insertions(+), 111 deletions(-)
 rename {vector-app => tools/lint}/lint.xml (100%)
 delete mode 100644 vector/lint.xml

diff --git a/vector-app/lint.xml b/tools/lint/lint.xml
similarity index 100%
rename from vector-app/lint.xml
rename to tools/lint/lint.xml
diff --git a/vector-app/build.gradle b/vector-app/build.gradle
index fd9eaba2af..2ed03ab8ed 100644
--- a/vector-app/build.gradle
+++ b/vector-app/build.gradle
@@ -311,7 +311,7 @@ android {
     }
 
     lintOptions {
-        lintConfig file("lint.xml")
+        lintConfig file("../tools/lint/lint.xml")
 
         checkDependencies true
         abortOnError true
diff --git a/vector/build.gradle b/vector/build.gradle
index 0c335db4a7..e20b462e08 100644
--- a/vector/build.gradle
+++ b/vector/build.gradle
@@ -103,7 +103,7 @@ android {
     }
 
     lintOptions {
-        lintConfig file("lint.xml")
+        lintConfig file("../tools/lint/lint.xml")
 
         checkDependencies true
         abortOnError true
diff --git a/vector/lint.xml b/vector/lint.xml
deleted file mode 100644
index b4b6ebc12f..0000000000
--- a/vector/lint.xml
+++ /dev/null
@@ -1,109 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<lint>
-
-    <!-- Ensure this file does not contain unknown Ids -->
-    <issue id="UnknownIssueId" severity="error" />
-
-    <!-- Modify some severity -->
-
-    <!-- Resource -->
-    <issue id="MissingTranslation" severity="ignore" />
-    <issue id="TypographyEllipsis" severity="error" />
-    <issue id="ImpliedQuantity" severity="warning" />
-    <issue id="MissingQuantity" severity="warning" />
-    <issue id="UnusedQuantity" severity="error" />
-    <issue id="IconXmlAndPng" severity="error" />
-    <issue id="IconDipSize" severity="error" />
-    <issue id="IconDuplicatesConfig" severity="error" />
-    <issue id="IconDuplicates" severity="error" />
-    <issue id="IconExpectedSize" severity="error" />
-    <issue id="LocaleFolder" severity="error" />
-
-    <issue id="TooManyViews" severity="warning">
-        <!-- Ignore TooManyViews in debug build type -->
-        <ignore path="**/src/debug/**" />
-    </issue>
-
-    <issue id="UnusedResources" severity="error">
-        <!-- Ignore unused resource in debug build type -->
-        <ignore path="**/src/debug/**" />
-
-        <!-- Following resources are for F-Droid variant only, so ignore for GPlay -->
-        <ignore regexp="settings_troubleshoot_test_service_boot_*" />
-        <ignore regexp="settings_troubleshoot_test_bg_restricted_*" />
-        <ignore regexp="settings_troubleshoot_test_battery_*" />
-
-        <!-- Following resources are for GPlay variant only, so ignore for F-Droid -->
-        <ignore regexp="settings_troubleshoot_test_play_services_" />
-        <ignore regexp="settings_troubleshoot_test_push_loop_" />
-        <ignore regexp="settings_troubleshoot_test_token_registration_" />
-        <ignore regexp="settings_troubleshoot_test_fcm_" />
-        <ignore regexp="no_valid_google_play_services_apk" />
-        <ignore regexp="sas_error_unknown" />
-    </issue>
-
-    <!-- UX -->
-    <issue id="ButtonOrder" severity="error" />
-    <issue id="TextFields" severity="error" />
-
-    <!-- Accessibility -->
-    <issue id="LabelFor" severity="error" />
-    <issue id="ContentDescription" severity="error" />
-    <issue id="SpUsage" severity="error" />
-
-    <!-- Layout -->
-    <issue id="UnknownIdInLayout" severity="error" />
-    <issue id="StringFormatCount" severity="error" />
-    <issue id="HardcodedText" severity="error" />
-    <issue id="ObsoleteLayoutParam" severity="error" />
-    <issue id="InefficientWeight" severity="error" />
-    <issue id="DisableBaselineAlignment" severity="error" />
-    <issue id="ScrollViewSize" severity="error" />
-    <issue id="NegativeMargin" severity="error" />
-    <issue id="UseCompatTextViewDrawableXml" severity="error" />
-
-    <!-- RTL -->
-    <issue id="RtlEnabled" severity="error" />
-    <issue id="RtlHardcoded" severity="error" />
-    <issue id="RtlSymmetry" severity="error" />
-
-    <!-- Code -->
-    <issue id="NewApi" severity="error" />
-    <issue id="SetTextI18n" severity="error" />
-    <issue id="ViewConstructor" severity="error" />
-    <issue id="UseValueOf" severity="error" />
-    <issue id="ObsoleteSdkInt" severity="error" />
-    <issue id="Recycle" severity="error" />
-    <issue id="KotlinPropertyAccess" severity="error" />
-    <issue id="DefaultLocale" severity="error" />
-    <issue id="CheckResult" severity="error" />
-
-    <issue id="InvalidPackage">
-        <!-- Ignore error from HtmlCompressor lib -->
-        <ignore path="**/htmlcompressor-1.4.jar" />
-        <!-- Ignore error from dropbox-core-sdk-3.0.8 lib, which comes with Jitsi library -->
-        <ignore path="**/dropbox-core-sdk-3.0.8.jar" />
-    </issue>
-
-    <!-- Manifest -->
-    <issue id="PermissionImpliesUnsupportedChromeOsHardware" severity="error" />
-
-    <!-- Performance -->
-    <issue id="UselessParent" severity="error" />
-
-    <!-- Dependencies -->
-    <issue id="KtxExtensionAvailable" severity="error" />
-
-    <!-- Timber -->
-    <!--    This rule is failing on CI because it's marked as unknwown rule id :/-->
-    <!--    <issue id="BinaryOperationInTimber" severity="error" />-->
-    <issue id="LogNotTimber" severity="error" />
-
-    <!-- Wording -->
-    <issue id="Typos" severity="error" />
-    <issue id="TypographyDashes" severity="error" />
-    <issue id="PluralsCandidate" severity="error" />
-
-    <!-- DI -->
-    <issue id="JvmStaticProvidesInObjectDetector" severity="error" />
-</lint>