From 489a594027d0fa07b672e1391ed988d744494d45 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Fri, 22 Nov 2019 11:17:50 +0100 Subject: [PATCH] Login screens: ensure forms are scrollable on small screens --- vector/src/main/res/layout/fragment_login.xml | 192 ++++++----- .../res/layout/fragment_login_captcha.xml | 11 +- ...fragment_login_generic_text_input_form.xml | 143 ++++---- .../layout/fragment_login_reset_password.xml | 147 ++++---- ...login_reset_password_mail_confirmation.xml | 65 ++-- .../fragment_login_reset_password_success.xml | 65 ++-- .../fragment_login_server_selection.xml | 325 +++++++++--------- .../layout/fragment_login_server_url_form.xml | 132 +++---- ...fragment_login_signup_signin_selection.xml | 121 +++---- .../main/res/layout/fragment_login_terms.xml | 10 +- .../layout/fragment_login_wait_for_email.xml | 55 +-- vector/src/main/res/layout/item_policy.xml | 4 +- vector/src/main/res/values/styles_login.xml | 15 +- 13 files changed, 674 insertions(+), 611 deletions(-) diff --git a/vector/src/main/res/layout/fragment_login.xml b/vector/src/main/res/layout/fragment_login.xml index 5539a8dfb9..583a060050 100644 --- a/vector/src/main/res/layout/fragment_login.xml +++ b/vector/src/main/res/layout/fragment_login.xml @@ -12,123 +12,127 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - - + - - - - - - - + tools:src="@drawable/ic_logo_matrix_org" /> - + - + + android:layout_marginTop="32dp" + android:hint="@string/login_signup_username_hint" + app:errorEnabled="true"> + android:inputType="textEmailAddress" + android:maxLines="1" /> - - - - - - - + android:layout_marginTop="16dp"> - + + + + + + + + + + + android:layout_marginTop="22dp" + android:orientation="horizontal"> - + - + + + + + + + diff --git a/vector/src/main/res/layout/fragment_login_captcha.xml b/vector/src/main/res/layout/fragment_login_captcha.xml index 03c56e89a7..e81a86ac2e 100644 --- a/vector/src/main/res/layout/fragment_login_captcha.xml +++ b/vector/src/main/res/layout/fragment_login_captcha.xml @@ -11,8 +11,9 @@ tools:ignore="ContentDescription,MissingConstraints" /> + + app:layout_constraintBottom_toBottomOf="@id/loginFormScrollView" + app:layout_constraintEnd_toEndOf="@id/loginFormScrollView" + app:layout_constraintStart_toStartOf="@id/loginFormScrollView" + app:layout_constraintTop_toTopOf="@id/loginFormScrollView" /> diff --git a/vector/src/main/res/layout/fragment_login_generic_text_input_form.xml b/vector/src/main/res/layout/fragment_login_generic_text_input_form.xml index 7d8edf705d..bfca7e78fb 100644 --- a/vector/src/main/res/layout/fragment_login_generic_text_input_form.xml +++ b/vector/src/main/res/layout/fragment_login_generic_text_input_form.xml @@ -12,86 +12,91 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - - - - - - - - - - - - - + + + + - + app:errorEnabled="true" + tools:hint="@string/login_set_email_optional_hint"> - + - + + + + + + + + + + + + + diff --git a/vector/src/main/res/layout/fragment_login_reset_password.xml b/vector/src/main/res/layout/fragment_login_reset_password.xml index 964d8c30dd..257ac5566f 100644 --- a/vector/src/main/res/layout/fragment_login_reset_password.xml +++ b/vector/src/main/res/layout/fragment_login_reset_password.xml @@ -11,97 +11,102 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - - - - - + android:textAppearance="@style/TextAppearance.Vector.Login.Title" + tools:text="@string/login_reset_password_on" /> - - - + + android:layout_marginTop="32dp" + android:hint="@string/login_reset_password_email_hint" + app:errorEnabled="true"> + android:inputType="textEmailAddress" + android:maxLines="1" /> - + + + + + + + + + + + + + android:text="@string/login_reset_password_submit" + tools:ignore="RelativeOverlap" /> - + - - - + diff --git a/vector/src/main/res/layout/fragment_login_reset_password_mail_confirmation.xml b/vector/src/main/res/layout/fragment_login_reset_password_mail_confirmation.xml index e1263ccfe7..c9b24e4a65 100644 --- a/vector/src/main/res/layout/fragment_login_reset_password_mail_confirmation.xml +++ b/vector/src/main/res/layout/fragment_login_reset_password_mail_confirmation.xml @@ -10,42 +10,47 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - + - + - + - + + + + + diff --git a/vector/src/main/res/layout/fragment_login_reset_password_success.xml b/vector/src/main/res/layout/fragment_login_reset_password_success.xml index ca8cb02bb7..dfa8dae2d3 100644 --- a/vector/src/main/res/layout/fragment_login_reset_password_success.xml +++ b/vector/src/main/res/layout/fragment_login_reset_password_success.xml @@ -10,42 +10,47 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - + - + - + - + + + + + diff --git a/vector/src/main/res/layout/fragment_login_server_selection.xml b/vector/src/main/res/layout/fragment_login_server_selection.xml index d120aa3a75..b8404b14ec 100644 --- a/vector/src/main/res/layout/fragment_login_server_selection.xml +++ b/vector/src/main/res/layout/fragment_login_server_selection.xml @@ -1,188 +1,195 @@ + + android:transitionName="loginLogoTransition" + tools:ignore="ContentDescription,MissingConstraints,UnusedAttribute" /> - + + - - - - - - - + + + - - - - - - - - - - - - - - - - + app:layout_constraintTop_toBottomOf="@+id/loginServerTitle" /> - + + + + + + + + + + + + + + + + + + + + + + + + + + + app:layout_constraintTop_toBottomOf="@+id/loginServerChoiceOther" /> - + - - - + diff --git a/vector/src/main/res/layout/fragment_login_server_url_form.xml b/vector/src/main/res/layout/fragment_login_server_url_form.xml index 81d004307e..a5d5844c2c 100644 --- a/vector/src/main/res/layout/fragment_login_server_url_form.xml +++ b/vector/src/main/res/layout/fragment_login_server_url_form.xml @@ -12,81 +12,87 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - + - + - + - + - + android:layout_marginTop="26dp" + app:errorEnabled="true" + tools:hint="@string/login_server_url_form_modular_hint"> - + - + - - + + + + + + + diff --git a/vector/src/main/res/layout/fragment_login_signup_signin_selection.xml b/vector/src/main/res/layout/fragment_login_signup_signin_selection.xml index 379059274e..bcf0fa8ff3 100644 --- a/vector/src/main/res/layout/fragment_login_signup_signin_selection.xml +++ b/vector/src/main/res/layout/fragment_login_signup_signin_selection.xml @@ -11,73 +11,76 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - + - + - - + - - + + - + + + + + diff --git a/vector/src/main/res/layout/fragment_login_terms.xml b/vector/src/main/res/layout/fragment_login_terms.xml index 78b12b9b1b..10bf9683b4 100644 --- a/vector/src/main/res/layout/fragment_login_terms.xml +++ b/vector/src/main/res/layout/fragment_login_terms.xml @@ -12,8 +12,10 @@ @@ -30,6 +34,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginTop="12dp" + android:paddingStart="36dp" + android:paddingEnd="36dp" android:text="@string/auth_accept_policies" app:layout_constraintTop_toBottomOf="@+id/loginTermsTitle" /> @@ -46,10 +52,12 @@ + diff --git a/vector/src/main/res/layout/fragment_login_wait_for_email.xml b/vector/src/main/res/layout/fragment_login_wait_for_email.xml index 346f010b0b..dcf3d8209b 100644 --- a/vector/src/main/res/layout/fragment_login_wait_for_email.xml +++ b/vector/src/main/res/layout/fragment_login_wait_for_email.xml @@ -11,36 +11,41 @@ tools:ignore="ContentDescription,MissingConstraints" /> - - + - + - + - + + + + + diff --git a/vector/src/main/res/layout/item_policy.xml b/vector/src/main/res/layout/item_policy.xml index d1c9b199e1..b5a14b27db 100644 --- a/vector/src/main/res/layout/item_policy.xml +++ b/vector/src/main/res/layout/item_policy.xml @@ -5,7 +5,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:foreground="?attr/selectableItemBackground" - android:minHeight="72dp"> + android:minHeight="72dp" + android:paddingStart="16dp" + android:paddingEnd="16dp"> + - + + -