filippodb
/
SchildiChat-android
mirror of https://github.com/SchildiChat/SchildiChat-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use `@id` and not `@+id` when referencing ids in layouts - accessibilityTraversal

This commit is contained in:
Benoit Marty 2021-12-01 22:16:28 +01:00
parent 6d3df0d802
commit 2d17156861
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/check/forbidden_strings_in_layout.txt
View File

@ -27,4 +27,5 @@
android:textSize===9 android:textSize===9
### Use `@id` and not `@+id` when referencing ids in layouts ### Use `@id` and not `@+id` when referencing ids in layouts
Of="@\+id Of="@\+id
accessibilityTraversal(.*)="@\+id

4
vector/src/main/res/layout/fragment_room_list.xml
View File

@ -31,7 +31,7 @@
android:layout_gravity="bottom|end" android:layout_gravity="bottom|end"
android:layout_marginEnd="16dp" android:layout_marginEnd="16dp"
android:layout_marginBottom="16dp" android:layout_marginBottom="16dp"
android:accessibilityTraversalBefore="@+id/roomListView" android:accessibilityTraversalBefore="@id/roomListView"
android:contentDescription="@string/a11y_create_direct_message" android:contentDescription="@string/a11y_create_direct_message"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_fab_add_chat" android:src="@drawable/ic_fab_add_chat"
@ -47,7 +47,7 @@
android:layout_gravity="bottom|end" android:layout_gravity="bottom|end"
android:layout_marginEnd="16dp" android:layout_marginEnd="16dp"
android:layout_marginBottom="16dp" android:layout_marginBottom="16dp"
android:accessibilityTraversalBefore="@+id/roomListView" android:accessibilityTraversalBefore="@id/roomListView"
android:contentDescription="@string/a11y_create_room" android:contentDescription="@string/a11y_create_room"
android:src="@drawable/ic_fab_add_room" android:src="@drawable/ic_fab_add_room"
android:visibility="gone" android:visibility="gone"

6
vector/src/main/res/layout/motion_notifs_fab_menu_merge.xml
View File

@ -24,7 +24,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="bottom|end" android:layout_gravity="bottom|end"
android:accessibilityTraversalBefore="@+id/roomListView" android:accessibilityTraversalBefore="@id/roomListView"
android:contentDescription="@string/a11y_create_room" android:contentDescription="@string/a11y_create_room"
android:src="@drawable/ic_fab_add_room" android:src="@drawable/ic_fab_add_room"
app:backgroundTint="#FFFFFF" app:backgroundTint="#FFFFFF"
@ -48,7 +48,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_gravity="bottom|end" android:layout_gravity="bottom|end"
android:accessibilityTraversalBefore="@+id/createRoomItemGroup" android:accessibilityTraversalBefore="@id/createRoomItemGroup"
android:contentDescription="@string/a11y_create_direct_message" android:contentDescription="@string/a11y_create_direct_message"
android:src="@drawable/ic_fab_add_chat" android:src="@drawable/ic_fab_add_chat"
app:backgroundTint="#FFFFFF" app:backgroundTint="#FFFFFF"
@ -71,7 +71,7 @@
android:id="@+id/createRoomButton" android:id="@+id/createRoomButton"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:accessibilityTraversalBefore="@+id/createRoomItemChat" android:accessibilityTraversalBefore="@id/createRoomItemChat"
android:contentDescription="@string/a11y_create_menu_open" android:contentDescription="@string/a11y_create_menu_open"
android:src="@drawable/ic_fab_add" android:src="@drawable/ic_fab_add"
app:maxImageSize="14dp" /> app:maxImageSize="14dp" />