From 2cc2844abf78e015115cdce8c2c0dad4d47479c5 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 6 Jun 2019 15:16:56 +0200 Subject: [PATCH] Fix issue in theme --- .../home/room/list/RoomCategoryItem.kt | 4 +- .../res/drawable/bg_unread_notification.xml | 3 +- vector/src/main/res/drawable/circle.xml | 2 +- .../src/main/res/drawable/fg_group_item.xml | 13 ----- .../main/res/layout/activity_bug_report.xml | 2 +- .../layout/bottom_sheet_logout_and_backup.xml | 6 ++- .../layout/bottom_sheet_message_actions.xml | 10 ++-- .../main/res/layout/fragment_public_rooms.xml | 12 ++--- ...nt_settings_notifications_troubleshoot.xml | 2 +- .../res/layout/item_autocomplete_command.xml | 5 +- vector/src/main/res/layout/item_loading.xml | 1 + .../layout/item_notification_troubleshoot.xml | 2 +- .../src/main/res/layout/item_public_room.xml | 53 ++++++++++--------- .../main/res/layout/item_room_category.xml | 4 +- ...item_timeline_event_merged_header_stub.xml | 2 +- .../src/main/res/layout/reaction_button.xml | 2 +- .../src/main/res/layout/view_button_state.xml | 8 +-- vector/src/main/res/values/colors.xml | 13 ----- vector/src/main/res/values/colors_riotx.xml | 3 ++ 19 files changed, 67 insertions(+), 80 deletions(-) delete mode 100644 vector/src/main/res/drawable/fg_group_item.xml delete mode 100644 vector/src/main/res/values/colors.xml diff --git a/vector/src/main/java/im/vector/riotredesign/features/home/room/list/RoomCategoryItem.kt b/vector/src/main/java/im/vector/riotredesign/features/home/room/list/RoomCategoryItem.kt index b19ff8e257..ef021938ee 100644 --- a/vector/src/main/java/im/vector/riotredesign/features/home/room/list/RoomCategoryItem.kt +++ b/vector/src/main/java/im/vector/riotredesign/features/home/room/list/RoomCategoryItem.kt @@ -25,6 +25,7 @@ import com.airbnb.epoxy.EpoxyModelClass import im.vector.riotredesign.R import im.vector.riotredesign.core.epoxy.VectorEpoxyHolder import im.vector.riotredesign.core.epoxy.VectorEpoxyModel +import im.vector.riotredesign.features.themes.ThemeUtils @EpoxyModelClass(layout = R.layout.item_room_category) abstract class RoomCategoryItem : VectorEpoxyModel() { @@ -36,8 +37,7 @@ abstract class RoomCategoryItem : VectorEpoxyModel() { @EpoxyAttribute var listener: (() -> Unit)? = null override fun bind(holder: Holder) { - // TODO Theme get text secondary color instead - val tintColor = ContextCompat.getColor(holder.rootView.context, R.color.bluey_grey_two) + val tintColor = ThemeUtils.getColor(holder.rootView.context, R.attr.riotx_text_secondary) val expandedArrowDrawableRes = if (expanded) R.drawable.ic_expand_more_white else R.drawable.ic_expand_less_white val expandedArrowDrawable = ContextCompat.getDrawable(holder.rootView.context, expandedArrowDrawableRes)?.also { DrawableCompat.setTint(it, tintColor) diff --git a/vector/src/main/res/drawable/bg_unread_notification.xml b/vector/src/main/res/drawable/bg_unread_notification.xml index 1f93e4dd97..f53f2f5704 100644 --- a/vector/src/main/res/drawable/bg_unread_notification.xml +++ b/vector/src/main/res/drawable/bg_unread_notification.xml @@ -5,5 +5,6 @@ - + + \ No newline at end of file diff --git a/vector/src/main/res/drawable/circle.xml b/vector/src/main/res/drawable/circle.xml index 853d7c36e7..2c2d89ae25 100644 --- a/vector/src/main/res/drawable/circle.xml +++ b/vector/src/main/res/drawable/circle.xml @@ -2,5 +2,5 @@ - + \ No newline at end of file diff --git a/vector/src/main/res/drawable/fg_group_item.xml b/vector/src/main/res/drawable/fg_group_item.xml deleted file mode 100644 index c6272163e8..0000000000 --- a/vector/src/main/res/drawable/fg_group_item.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - - - - - - - \ No newline at end of file diff --git a/vector/src/main/res/layout/activity_bug_report.xml b/vector/src/main/res/layout/activity_bug_report.xml index b7727f0363..2afeaa41e9 100644 --- a/vector/src/main/res/layout/activity_bug_report.xml +++ b/vector/src/main/res/layout/activity_bug_report.xml @@ -84,7 +84,7 @@ android:layout_height="wrap_content" android:hint="@string/send_bug_report_placeholder" android:minHeight="40dp" - android:textColor="?android:textColorPrimary" /> + android:textColor="?riotx_text_primary" /> diff --git a/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml b/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml index c4e6adbf9a..aeaa2fb97c 100644 --- a/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml +++ b/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml @@ -16,6 +16,7 @@ android:layout_marginEnd="@dimen/layout_horizontal_margin" android:layout_marginBottom="8dp" android:text="@string/action_sign_out" + android:textColor="?riotx_text_primary" android:textSize="18sp" android:textStyle="bold" /> @@ -26,7 +27,7 @@ android:layout_marginStart="@dimen/layout_horizontal_margin" android:layout_marginEnd="@dimen/layout_horizontal_margin" android:layout_marginBottom="8dp" - android:textColor="?android:attr/textColorSecondary" + android:textColor="?riotx_text_secondary" tools:text="@string/sign_out_bottom_sheet_warning_no_backup" /> @@ -95,6 +97,7 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:text="@string/keys_backup_setup" + android:textColor="?riotx_text_secondary" android:textSize="17sp" /> @@ -128,6 +131,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center_vertical" + android:textColor="?riotx_text_secondary" android:text="@string/keys_backup_activate" android:textSize="17sp" /> diff --git a/vector/src/main/res/layout/bottom_sheet_message_actions.xml b/vector/src/main/res/layout/bottom_sheet_message_actions.xml index 967bbe4232..0de471bdd1 100644 --- a/vector/src/main/res/layout/bottom_sheet_message_actions.xml +++ b/vector/src/main/res/layout/bottom_sheet_message_actions.xml @@ -42,6 +42,7 @@ android:ellipsize="end" android:fontFamily="sans-serif-bold" android:singleLine="true" + android:textColor="?riotx_text_primary" android:textSize="14sp" android:textStyle="bold" app:layout_constraintEnd_toEndOf="parent" @@ -49,8 +50,7 @@ app:layout_constraintTop_toTopOf="@id/bottom_sheet_message_preview_avatar" tools:text="@tools:sample/full_names" /> - + app:layout_constraintTop_toTopOf="parent"> + app:layout_constraintTop_toBottomOf="@+id/publicRoomsToolbar" /> @@ -26,6 +28,7 @@ android:layout_toEndOf="@+id/commandName" android:layout_toRightOf="@+id/commandName" android:maxLines="1" + android:textColor="?riotx_text_secondary" android:textSize="12sp" android:textStyle="italic" tools:text="<user-id>" /> @@ -39,7 +42,7 @@ android:layout_alignParentLeft="true" android:layout_gravity="center_vertical" android:maxLines="1" - android:textColor="?android:attr/textColorSecondary" + android:textColor="?riotx_text_secondary" android:textSize="12sp" tools:text="@string/command_description_invite_user" /> diff --git a/vector/src/main/res/layout/item_loading.xml b/vector/src/main/res/layout/item_loading.xml index 62543a335f..4e723f8b6d 100644 --- a/vector/src/main/res/layout/item_loading.xml +++ b/vector/src/main/res/layout/item_loading.xml @@ -3,4 +3,5 @@ android:id="@+id/progressBar" android:layout_width="match_parent" android:layout_height="80dp" + android:background="?riotx_background" android:padding="16dp" /> \ No newline at end of file diff --git a/vector/src/main/res/layout/item_notification_troubleshoot.xml b/vector/src/main/res/layout/item_notification_troubleshoot.xml index 23ce817425..2a2a23ed11 100644 --- a/vector/src/main/res/layout/item_notification_troubleshoot.xml +++ b/vector/src/main/res/layout/item_notification_troubleshoot.xml @@ -49,7 +49,7 @@ android:layout_marginRight="16dp" android:paddingTop="4dp" android:paddingBottom="4dp" - android:textColor="?android:attr/textColorSecondary" + android:textColor="?riotx_text_secondary" android:visibility="gone" app:layout_constraintBottom_toTopOf="@id/troubleshootTestButton" app:layout_constraintEnd_toStartOf="@+id/troubleshootStatusIcon" diff --git a/vector/src/main/res/layout/item_public_room.xml b/vector/src/main/res/layout/item_public_room.xml index ccfc4dd07e..6970e100e7 100644 --- a/vector/src/main/res/layout/item_public_room.xml +++ b/vector/src/main/res/layout/item_public_room.xml @@ -35,18 +35,38 @@ android:textColor="?riotx_text_primary" android:textSize="15sp" android:textStyle="bold" - app:layout_constraintBottom_toTopOf="@+id/itemPublicRoomMembersCount" + app:layout_constraintBottom_toTopOf="@+id/itemPublicRoomTopic" app:layout_constraintEnd_toStartOf="@+id/itemPublicRoomButtonState" app:layout_constraintStart_toEndOf="@id/itemPublicRoomAvatar" app:layout_constraintTop_toTopOf="parent" app:layout_constraintVertical_chainStyle="packed" tools:text="@sample/matrix.json/data/roomName" /> + + - - + android:paddingBottom="8dp"> + tools:layout_marginTop="80dp" /> + tools:layout_marginTop="160dp" /> \ No newline at end of file diff --git a/vector/src/main/res/values/colors.xml b/vector/src/main/res/values/colors.xml deleted file mode 100644 index a9b572ef42..0000000000 --- a/vector/src/main/res/values/colors.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - - #f2f5f8 - #7ac9a1 - #929eb4 - #4ac1c9d6 - - #61708B - #000000 - - diff --git a/vector/src/main/res/values/colors_riotx.xml b/vector/src/main/res/values/colors_riotx.xml index 89aa589ccd..eecbf3f823 100644 --- a/vector/src/main/res/values/colors_riotx.xml +++ b/vector/src/main/res/values/colors_riotx.xml @@ -23,6 +23,9 @@ #5c56f5 #74d12c + + #FF000000 + #FFFFFFFF