filippodb/SchildiChat-android
1
0
Fork 0
mirror of https://github.com/SchildiChat/SchildiChat-android.git synced 2024-12-25 09:10:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Removing TODOs

Browse Source
This commit is contained in:
Maxime Naturel 2022-02-22 17:44:59 +01:00
parent f050fc1e4a
commit 21fa0267f6
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt
View File

@ -51,8 +51,6 @@ class LoginWebFragment @Inject constructor(
private val assetReader: AssetReader private val assetReader: AssetReader
) : AbstractLoginFragment<FragmentLoginWebBinding>() { ) : AbstractLoginFragment<FragmentLoginWebBinding>() {
// TODO I noticed in the Git history this variable was a local variable inside notifyViewModel method
// TODO was there any reason ? To be able to create this ViewModel we must be sure we will have a valid session
private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel() private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel()
override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentLoginWebBinding { override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentLoginWebBinding {

4
vector/src/main/java/im/vector/app/features/login2/LoginWebFragment2.kt
View File

@ -56,8 +56,6 @@ class LoginWebFragment2 @Inject constructor(
return FragmentLoginWebBinding.inflate(inflater, container, false) return FragmentLoginWebBinding.inflate(inflater, container, false)
} }
// TODO I noticed in the Git history this variable was a local variable inside notifyViewModel method
// TODO was there any reason ? To be able to create this ViewModel we must be sure we will have a valid session
private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel() private val softLogoutViewModel: SoftLogoutViewModel by activityViewModel()
private var isWebViewLoaded = false private var isWebViewLoaded = false
@ -84,7 +82,7 @@ class LoginWebFragment2 @Inject constructor(
private fun setupTitle(state: LoginViewState2) { private fun setupTitle(state: LoginViewState2) {
toolbar?.title = when (state.signMode) { toolbar?.title = when (state.signMode) {
SignMode2.SignIn -> getString(R.string.login_signin) SignMode2.SignIn -> getString(R.string.login_signin)
else -> getString(R.string.login_signup) else -> getString(R.string.login_signup)
} }
} }