Merge pull request #3773 from pvagner/a11yAvatarVerbosity

a11y: change some content descriptions
This commit is contained in:
Benoit Marty 2021-08-23 12:15:43 +02:00 committed by GitHub
commit 18936122a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
43 changed files with 74 additions and 76 deletions

View File

@ -76,7 +76,6 @@
android:id="@+id/otherMemberAvatar"
android:layout_width="80dp"
android:layout_height="80dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerCrop"
app:layout_constraintBottom_toBottomOf="parent"
@ -186,4 +185,4 @@
</FrameLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -12,7 +12,7 @@
android:id="@+id/ivUserAvatar"
android:layout_width="40dp"
android:layout_height="40dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/alerter_texts"
app:layout_constraintStart_toStartOf="parent"
@ -78,4 +78,4 @@
</LinearLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -25,7 +25,7 @@
android:id="@+id/inviterAvatarImage"
android:layout_width="40dp"
android:layout_height="40dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:transitionName="profile"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintHorizontal_bias="0"
@ -75,4 +75,4 @@
</LinearLayout>
</androidx.core.widget.NestedScrollView>
</androidx.core.widget.NestedScrollView>

View File

@ -45,7 +45,7 @@
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="center"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/user_round_avatars" />
<LinearLayout
@ -118,4 +118,4 @@
</LinearLayout>
</LinearLayout>
</LinearLayout>

View File

@ -21,7 +21,7 @@
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:adjustViewBounds="true"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerCrop"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"

View File

@ -29,7 +29,7 @@
android:id="@+id/composerRelatedMessageAvatar"
android:layout_width="0dp"
android:layout_height="0dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:ignore="MissingConstraints" />
<TextView

View File

@ -32,7 +32,7 @@
android:id="@+id/composerRelatedMessageAvatar"
android:layout_width="40dp"
android:layout_height="40dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:visibility="invisible"
app:layout_constraintBottom_toTopOf="parent"
app:layout_constraintEnd_toStartOf="parent" />
@ -192,4 +192,4 @@
app:layout_constraintEnd_toEndOf="parent" />
-->
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -33,7 +33,7 @@
android:layout_marginStart="8dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toTopOf="@id/composerRelatedMessageActionIcon"
app:layout_constraintEnd_toStartOf="@+id/composerRelatedMessageTitle"
app:layout_constraintStart_toStartOf="parent"
@ -192,4 +192,4 @@
tools:ignore="MissingPrefix"
tools:visibility="visible" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -22,7 +22,7 @@
android:layout_height="40dp"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:layout_marginTop="24dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:transitionName="profile"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -174,4 +174,4 @@
app:tint="?vctr_content_secondary"
tools:ignore="MissingPrefix" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -60,7 +60,7 @@
android:id="@+id/loginAccountCreatedAvatar"
android:layout_width="44dp"
android:layout_height="44dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
tools:src="@tools:sample/avatars" />

View File

@ -19,7 +19,7 @@
android:layout_width="60dp"
android:layout_height="60dp"
android:layout_marginTop="20dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:elevation="4dp"
android:transitionName="profile"
app:layout_constraintEnd_toEndOf="parent"

View File

@ -29,7 +29,7 @@
android:layout_height="40dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"

View File

@ -31,7 +31,7 @@
android:layout_height="40dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -149,4 +149,4 @@
</LinearLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>

View File

@ -31,7 +31,7 @@
android:layout_height="40dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"

View File

@ -29,7 +29,7 @@
android:layout_height="40dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -81,4 +81,4 @@
android:layout_height="match_parent"
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
</androidx.coordinatorlayout.widget.CoordinatorLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>

View File

@ -33,7 +33,7 @@
android:layout_height="40dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -120,4 +120,4 @@
</LinearLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>

View File

@ -135,6 +135,7 @@
android:id="@+id/showUserCodeQRImage"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="@string/a11y_qr_code_for_verification"
tools:src="@drawable/ic_qr_code_add" />
</com.google.android.material.card.MaterialCardView>
@ -147,7 +148,7 @@
android:id="@+id/showUserCodeAvatar"
android:layout_width="76dp"
android:layout_height="76dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:elevation="4dp"
android:transitionName="profile"
app:layout_constraintBottom_toTopOf="@id/showUserCodeCard"
@ -203,4 +204,4 @@
</androidx.constraintlayout.widget.ConstraintLayout>
</ScrollView>
</ScrollView>

View File

@ -16,7 +16,6 @@
android:layout_marginBottom="8dp"
android:adjustViewBounds="true"
android:background="@drawable/circle"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerCrop"
app:layout_constraintBottom_toBottomOf="parent"

View File

@ -14,7 +14,7 @@
android:id="@+id/contactAvatar"
android:layout_width="48dp"
android:layout_height="48dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -37,4 +37,4 @@
app:layout_constraintTop_toTopOf="parent"
tools:text="@tools:sample/full_names" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -24,7 +24,7 @@
android:id="@+id/createDirectRoomUserAvatar"
android:layout_width="40dp"
android:layout_height="40dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/user_round_avatars" />
<ImageView
@ -72,4 +72,4 @@
app:layout_constraintTop_toBottomOf="@+id/createDirectRoomUserName"
tools:text="@sample/users.json/data/id" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -16,7 +16,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_marginEnd="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/user_round_avatars" />
<TextView
@ -29,4 +29,4 @@
style="@style/BottomSheetItemTime"
tools:text="10:44" />
</LinearLayout>
</LinearLayout>

View File

@ -16,7 +16,7 @@
android:layout_height="42dp"
android:layout_gravity="center"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:duplicateParentState="true"
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
app:layout_constraintStart_toStartOf="parent"
@ -62,4 +62,4 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />
</im.vector.app.core.platform.CheckableConstraintLayout>
</im.vector.app.core.platform.CheckableConstraintLayout>

View File

@ -24,7 +24,7 @@
android:id="@+id/knownUserAvatar"
android:layout_width="40dp"
android:layout_height="40dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/user_round_avatars" />
<ImageView
@ -71,4 +71,4 @@
app:layout_constraintTop_toBottomOf="@+id/knownUserName"
tools:text="@sample/users.json/data/id" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -19,7 +19,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_centerVertical="true"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerInside"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"

View File

@ -19,7 +19,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_centerVertical="true"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerInside"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"

View File

@ -17,7 +17,7 @@
android:layout_width="56dp"
android:layout_height="56dp"
android:layout_marginStart="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toTopOf="@+id/itemPublicRoomBottomSeparator"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -116,4 +116,4 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -34,7 +34,7 @@
android:id="@+id/roomAvatarImageView"
android:layout_width="56dp"
android:layout_height="56dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/room_round_avatars" />
<ImageView

View File

@ -18,7 +18,7 @@
android:layout_marginTop="4dp"
android:layout_marginBottom="4dp"
android:background="@drawable/circle"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:padding="8dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
@ -71,7 +71,7 @@
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:layout_marginEnd="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:contentDescription="@string/a11y_selected"
android:padding="8dp"
android:src="@drawable/ic_check_on"
android:visibility="gone"
@ -80,4 +80,4 @@
app:layout_constraintTop_toTopOf="parent"
tools:visibility="visible" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -53,7 +53,7 @@
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:layout_marginEnd="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:contentDescription="@string/remove"
android:padding="8dp"
android:src="@drawable/ic_delete"
android:visibility="gone"
@ -64,4 +64,4 @@
tools:ignore="MissingPrefix"
tools:visibility="visible" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -16,7 +16,7 @@
android:layout_height="56dp"
android:layout_marginStart="8dp"
android:layout_marginTop="12dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
tools:src="@sample/room_round_avatars" />

View File

@ -16,7 +16,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_marginStart="16dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -53,4 +53,4 @@
tools:src="@drawable/ic_checkbox_on" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -16,7 +16,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_marginStart="16dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -70,4 +70,4 @@
tools:src="@drawable/ic_checkbox_on" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -12,7 +12,7 @@
android:layout_height="44dp"
android:layout_marginStart="8dp"
android:layout_marginTop="4dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
tools:src="@sample/user_round_avatars" />
@ -61,4 +61,4 @@
app:layout_constraintTop_toBottomOf="@+id/messageMemberNameView"
tools:text="@sample/messages.json/data/message" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -26,7 +26,7 @@
android:layout_height="42dp"
android:layout_gravity="center"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:duplicateParentState="true"
app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator"
app:layout_constraintStart_toEndOf="@id/indent"
@ -148,4 +148,4 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />
</im.vector.app.core.platform.CheckableConstraintLayout>
</im.vector.app.core.platform.CheckableConstraintLayout>

View File

@ -18,7 +18,6 @@
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:background="@drawable/rounded_rect_shape_8"
android:backgroundTint="?colorPrimary"
android:contentDescription="@string/avatar"
android:duplicateParentState="true"
android:importantForAccessibility="no"
android:padding="10dp"
@ -43,4 +42,4 @@
app:layout_constraintStart_toEndOf="@+id/groupAvatarImageView"
app:layout_constraintTop_toTopOf="parent" />
</im.vector.app.core.platform.CheckableConstraintLayout>
</im.vector.app.core.platform.CheckableConstraintLayout>

View File

@ -31,7 +31,7 @@
android:layout_height="40dp"
android:layout_marginStart="8dp"
android:layout_marginTop="12dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:scaleType="centerInside"
android:visibility="visible"
app:layout_constraintStart_toStartOf="parent"
@ -115,4 +115,4 @@
</androidx.constraintlayout.widget.ConstraintLayout>
</LinearLayout>
</LinearLayout>

View File

@ -26,7 +26,7 @@
android:layout_height="26dp"
android:layout_gravity="center"
android:layout_marginStart="@dimen/layout_horizontal_margin"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
android:duplicateParentState="true"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toEndOf="@id/indent"
@ -119,4 +119,4 @@
app:tint="?vctr_content_primary"
tools:ignore="MissingPrefix" />
</im.vector.app.core.platform.CheckableConstraintLayout>
</im.vector.app.core.platform.CheckableConstraintLayout>

View File

@ -21,7 +21,7 @@
android:id="@+id/roomAvatarImageView"
android:layout_width="56dp"
android:layout_height="56dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/room_round_avatars" />
</FrameLayout>

View File

@ -11,7 +11,7 @@
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_gravity="center_horizontal"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
tools:src="@sample/user_round_avatars" />
<TextView
@ -92,4 +92,4 @@
</androidx.constraintlayout.widget.ConstraintLayout>
</LinearLayout>
</LinearLayout>

View File

@ -17,7 +17,7 @@
android:layout_width="56dp"
android:layout_height="56dp"
android:layout_marginStart="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintBottom_toTopOf="@+id/itemPublicRoomBottomSeparator"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -50,4 +50,4 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -16,7 +16,7 @@
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_marginStart="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
tools:src="@sample/user_round_avatars" />
@ -56,4 +56,4 @@
tools:text="@sample/users.json/data/displayName"
tools:visibility="visible" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.constraintlayout.widget.ConstraintLayout>

View File

@ -13,7 +13,7 @@
android:layout_marginStart="8dp"
android:layout_marginTop="86dp"
android:layout_marginEnd="8dp"
android:contentDescription="@string/avatar"
android:importantForAccessibility="no"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
@ -94,4 +94,4 @@
app:layout_constraintTop_toBottomOf="@id/inviteAcceptView" />
</merge>
</merge>

View File

@ -3305,7 +3305,7 @@
<string name="a11y_change_avatar">Change avatar</string>
<string name="a11y_delete_avatar">Delete avatar</string>
<string name="a11y_error_some_message_not_sent">Some messages have not been sent</string>
<string name="a11y_unsent_draft">This room has unsent draft</string>
<string name="a11y_unsent_draft">has unsent draft</string>
<string name="a11y_video">Video</string>
<string name="a11y_selected">Selected</string>
<string name="a11y_trust_level_default">Default trust level</string>
@ -3320,8 +3320,8 @@
<string name="a11y_rule_notify_silent">Notify without sound</string>
<string name="a11y_rule_notify_off">Do not notify</string>
<string name="a11y_view_read_receipts">View read receipts</string>
<string name="a11y_public_room">This room is public</string>
<string name="a11y_public_space">This Space is public</string>
<string name="a11y_public_room">Public room</string>
<string name="a11y_public_space">Public space</string>
<string name="dev_tools_menu_name">Dev Tools</string>
<string name="dev_tools_explore_room_state">Explore Room State</string>