From 17ddb5ce43fedebe818e5e15e0fa60063ca65451 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoitm@matrix.org>
Date: Mon, 4 May 2020 18:19:49 +0200
Subject: [PATCH] if all events are rendered in the timeline (developer mode),
 render the room creation event.

---
 .../src/main/res/values/strings.xml           |  1 +
 .../timeline/factory/RoomCreateItemFactory.kt | 24 ++++++++++++-------
 .../timeline/factory/TimelineItemFactory.kt   |  2 +-
 .../timeline/format/NoticeEventFormatter.kt   |  8 +++++++
 4 files changed, 26 insertions(+), 9 deletions(-)

diff --git a/matrix-sdk-android/src/main/res/values/strings.xml b/matrix-sdk-android/src/main/res/values/strings.xml
index 50169fd982..69907e5835 100644
--- a/matrix-sdk-android/src/main/res/values/strings.xml
+++ b/matrix-sdk-android/src/main/res/values/strings.xml
@@ -5,6 +5,7 @@
     <string name="summary_user_sent_sticker">%1$s sent a sticker.</string>
 
     <string name="notice_room_invite_no_invitee">%s\'s invitation</string>
+    <string name="notice_room_created">%1$s created the room</string>
     <string name="notice_room_invite">%1$s invited %2$s</string>
     <string name="notice_room_invite_you">%1$s invited you</string>
     <string name="notice_room_join">%1$s joined the room</string>
diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/RoomCreateItemFactory.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/RoomCreateItemFactory.kt
index bf3b82ab4d..d5471d7f4f 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/RoomCreateItemFactory.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/RoomCreateItemFactory.kt
@@ -21,21 +21,21 @@ import im.vector.matrix.android.api.session.events.model.toModel
 import im.vector.matrix.android.api.session.room.model.create.RoomCreateContent
 import im.vector.matrix.android.api.session.room.timeline.TimelineEvent
 import im.vector.riotx.R
-import im.vector.riotx.core.resources.ColorProvider
+import im.vector.riotx.core.epoxy.VectorEpoxyModel
 import im.vector.riotx.core.resources.StringProvider
+import im.vector.riotx.core.resources.UserPreferencesProvider
 import im.vector.riotx.features.home.room.detail.timeline.TimelineEventController
-import im.vector.riotx.features.home.room.detail.timeline.item.RoomCreateItem
 import im.vector.riotx.features.home.room.detail.timeline.item.RoomCreateItem_
 import me.gujun.android.span.span
 import javax.inject.Inject
 
-class RoomCreateItemFactory @Inject constructor(private val colorProvider: ColorProvider,
-                                                private val stringProvider: StringProvider) {
+class RoomCreateItemFactory @Inject constructor(private val stringProvider: StringProvider,
+                                                private val userPreferencesProvider: UserPreferencesProvider,
+                                                private val noticeItemFactory: NoticeItemFactory) {
 
-    fun create(event: TimelineEvent, callback: TimelineEventController.Callback?): RoomCreateItem? {
-        val createRoomContent = event.root.getClearContent().toModel<RoomCreateContent>()
-                                ?: return null
-        val predecessorId = createRoomContent.predecessor?.roomId ?: return null
+    fun create(event: TimelineEvent, callback: TimelineEventController.Callback?): VectorEpoxyModel<*>? {
+        val createRoomContent = event.root.getClearContent().toModel<RoomCreateContent>() ?: return null
+        val predecessorId = createRoomContent.predecessor?.roomId ?: return defaultRendering(event, callback)
         val roomLink = PermalinkFactory.createPermalink(predecessorId) ?: return null
         val text = span {
             +stringProvider.getString(R.string.room_tombstone_continuation_description)
@@ -48,4 +48,12 @@ class RoomCreateItemFactory @Inject constructor(private val colorProvider: Color
         return RoomCreateItem_()
                 .text(text)
     }
+
+    private fun defaultRendering(event: TimelineEvent, callback: TimelineEventController.Callback?): VectorEpoxyModel<*>? {
+        return if (userPreferencesProvider.shouldShowHiddenEvents()) {
+            noticeItemFactory.create(event, false, callback)
+        } else {
+            null
+        }
+    }
 }
diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
index 7e6c387934..f2ac7018aa 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/factory/TimelineItemFactory.kt
@@ -58,7 +58,7 @@ class TimelineItemFactory @Inject constructor(private val messageItemFactory: Me
                 EventType.CALL_HANGUP,
                 EventType.CALL_ANSWER,
                 EventType.REACTION,
-                EventType.REDACTION -> noticeItemFactory.create(event, highlight, callback)
+                EventType.REDACTION                     -> noticeItemFactory.create(event, highlight, callback)
                 EventType.STATE_ROOM_ENCRYPTION         -> {
                     encryptionItemFactory.create(event, highlight, callback)
                 }
diff --git a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/format/NoticeEventFormatter.kt b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/format/NoticeEventFormatter.kt
index 39e17b7c35..f29bd72e0a 100644
--- a/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/format/NoticeEventFormatter.kt
+++ b/vector/src/main/java/im/vector/riotx/features/home/room/detail/timeline/format/NoticeEventFormatter.kt
@@ -32,6 +32,7 @@ import im.vector.matrix.android.api.session.room.model.RoomMemberContent
 import im.vector.matrix.android.api.session.room.model.RoomNameContent
 import im.vector.matrix.android.api.session.room.model.RoomTopicContent
 import im.vector.matrix.android.api.session.room.model.call.CallInviteContent
+import im.vector.matrix.android.api.session.room.model.create.RoomCreateContent
 import im.vector.matrix.android.api.session.room.timeline.TimelineEvent
 import im.vector.matrix.android.internal.crypto.MXCRYPTO_ALGORITHM_MEGOLM
 import im.vector.matrix.android.internal.crypto.model.event.EncryptionEventContent
@@ -47,6 +48,7 @@ class NoticeEventFormatter @Inject constructor(private val sessionHolder: Active
     fun format(timelineEvent: TimelineEvent): CharSequence? {
         return when (val type = timelineEvent.root.getClearType()) {
             EventType.STATE_ROOM_JOIN_RULES         -> formatJoinRulesEvent(timelineEvent.root, timelineEvent.getDisambiguatedDisplayName())
+            EventType.STATE_ROOM_CREATE             -> formatRoomCreateEvent(timelineEvent.root)
             EventType.STATE_ROOM_NAME               -> formatRoomNameEvent(timelineEvent.root, timelineEvent.getDisambiguatedDisplayName())
             EventType.STATE_ROOM_TOPIC              -> formatRoomTopicEvent(timelineEvent.root, timelineEvent.getDisambiguatedDisplayName())
             EventType.STATE_ROOM_MEMBER             -> formatRoomMemberEvent(timelineEvent.root, timelineEvent.getDisambiguatedDisplayName())
@@ -98,6 +100,12 @@ class NoticeEventFormatter @Inject constructor(private val sessionHolder: Active
         return "{ \"type\": ${event.getClearType()} }"
     }
 
+    private fun formatRoomCreateEvent(event: Event): CharSequence? {
+        return event.getClearContent().toModel<RoomCreateContent>()
+                ?.takeIf { it.creator.isNullOrBlank().not() }
+                ?.let { sp.getString(R.string.notice_room_created, it.creator) }
+    }
+
     private fun formatRoomNameEvent(event: Event, senderName: String?): CharSequence? {
         val content = event.getClearContent().toModel<RoomNameContent>() ?: return null
         return if (content.name.isNullOrBlank()) {