From 0707877b3c925ba447e405a5cd2bc63245cbe409 Mon Sep 17 00:00:00 2001
From: Maxime Naturel <maxime.naturel@niji.fr>
Date: Wed, 2 Mar 2022 11:07:33 +0100
Subject: [PATCH] Using correct string resources for options

---
 .../layout/view_location_sharing_option_picker.xml   | 12 ++++++------
 vector/src/main/res/values/strings.xml               |  8 ++++++++
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/vector/src/main/res/layout/view_location_sharing_option_picker.xml b/vector/src/main/res/layout/view_location_sharing_option_picker.xml
index 277f0f0604..ecb96fc1e4 100644
--- a/vector/src/main/res/layout/view_location_sharing_option_picker.xml
+++ b/vector/src/main/res/layout/view_location_sharing_option_picker.xml
@@ -16,12 +16,12 @@
         app:icon="@drawable/ic_attachment_location_white"
         app:iconBackground="@drawable/circle"
         app:iconBackgroundTint="?colorPrimary"
-        app:iconDescription="@string/a11y_location_share_icon"
+        app:iconDescription="@string/a11y_location_share_option_pinned_icon"
         app:layout_constraintBottom_toTopOf="@id/locationSharingOptionUserCurrentLocation"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        app:title="@string/location_share" />
+        app:title="@string/location_share_option_pinned" />
 
     <im.vector.app.features.location.view.LocationSharingOptionView
         android:id="@+id/locationSharingOptionUserCurrentLocation"
@@ -30,12 +30,12 @@
         app:icon="@drawable/ic_attachment_location_white"
         app:iconBackground="@drawable/circle"
         app:iconBackgroundTint="?colorPrimary"
-        app:iconDescription="@string/a11y_location_share_icon"
+        app:iconDescription="@string/a11y_location_share_option_user_current_icon"
         app:layout_constraintBottom_toTopOf="@id/locationSharingOptionUserLiveLocation"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@+id/locationSharingOptionPinned"
-        app:title="@string/location_share" />
+        app:title="@string/location_share_option_user_current" />
 
     <im.vector.app.features.location.view.LocationSharingOptionView
         android:id="@+id/locationSharingOptionUserLiveLocation"
@@ -44,12 +44,12 @@
         app:icon="@drawable/ic_attachment_location_live_white"
         app:iconBackground="@drawable/circle"
         app:iconBackgroundTint="?colorPrimary"
-        app:iconDescription="@string/a11y_location_share_icon"
+        app:iconDescription="@string/a11y_location_share_option_user_live_icon"
         app:iconPadding="3dp"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/locationSharingOptionUserCurrentLocation"
-        app:title="@string/location_share" />
+        app:title="@string/location_share_option_user_live" />
 
 </merge>
diff --git a/vector/src/main/res/values/strings.xml b/vector/src/main/res/values/strings.xml
index dc52d2cf5d..8cdbe122f3 100644
--- a/vector/src/main/res/values/strings.xml
+++ b/vector/src/main/res/values/strings.xml
@@ -2924,9 +2924,17 @@
     <!-- Location -->
     <string name="location_activity_title_static_sharing">Share location</string>
     <string name="location_activity_title_preview">Location</string>
+    <!-- TODO delete -->
     <string name="a11y_location_share_icon">Share location</string>
     <string name="a11y_static_map_image">Map</string>
+    <!-- TODO delete -->
     <string name="location_share">Share location</string>
+    <string name="location_share_option_user_current">Share my current location</string>
+    <string name="a11y_location_share_option_user_current_icon">Share my current location</string>
+    <string name="location_share_option_user_live">Share live location</string>
+    <string name="a11y_location_share_option_user_live_icon">Share live location</string>
+    <string name="location_share_option_pinned">Share this location</string>
+    <string name="a11y_location_share_option_pinned_icon">Share this location</string>
     <string name="location_not_available_dialog_title">${app_name} could not access your location</string>
     <string name="location_not_available_dialog_content">${app_name} could not access your location. Please try again later.</string>
     <string name="location_share_external">Open with</string>